From patchwork Tue Nov 3 14:33:17 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 539447 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id A8D61140311 for ; Wed, 4 Nov 2015 01:33:50 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=WsYenscI; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :subject:to:references:cc:from:message-id:date:mime-version :in-reply-to:content-type; q=dns; s=default; b=gktWz9v0b97d64+L6 11D9Sh4RNm5t2F6vSaBB+jw7cPIQ24lXG3X6n5D1ruxAnzf8r0N3kUoqOReQs3Z5 G4tjfTkq6KLmPJ+uG6ly1j3YEUShfOhCL1Db00O44fUHPPov/Ek+/r4rj+cp1X4s q5FPRM5l/I3ZI1BYyxJM8lnJDI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :subject:to:references:cc:from:message-id:date:mime-version :in-reply-to:content-type; s=default; bh=kX8Z/5jU2iee7Xurys4CVSs GJKY=; b=WsYenscI8u3lppSkq5Yt19OUQhsWqGeiDSeqte4lucp4X2sN/C+WgpU xPl8cl4eT2pu55pruZG/ftFKdZeBQy/Mgy+0xY+Z0vVIlbfByJU0TSAz1IwpWLyW sbCxI2avV4BWMWXup1mM61TDG5eIQ2egvd2E70bNSZq1M8HNwGY0= Received: (qmail 55249 invoked by alias); 3 Nov 2015 14:33:41 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 55238 invoked by uid 89); 3 Nov 2015 14:33:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL, BAYES_00, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: fencepost.gnu.org Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (208.118.235.10) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 03 Nov 2015 14:33:39 +0000 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41057) by fencepost.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ZtceW-0008Ir-Py for gcc-patches@gnu.org; Tue, 03 Nov 2015 09:33:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtceT-00069B-1M for gcc-patches@gnu.org; Tue, 03 Nov 2015 09:33:36 -0500 Received: from relay1.mentorg.com ([192.94.38.131]:62286) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtceS-00068t-Q3 for gcc-patches@gnu.org; Tue, 03 Nov 2015 09:33:32 -0500 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1ZtceR-0001zc-BF from Tom_deVries@mentor.com for gcc-patches@gnu.org; Tue, 03 Nov 2015 06:33:31 -0800 Received: from [127.0.0.1] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.3.224.2; Tue, 3 Nov 2015 14:33:29 +0000 Subject: Re: [gomp4, committed] Implement -foffload-alias To: Nathan Sidwell References: <56095EEF.7010700@mentor.com> <5638C276.7070206@mentor.com> CC: "gcc-patches@gnu.org" From: Tom de Vries Message-ID: <5638C5AD.5090208@mentor.com> Date: Tue, 3 Nov 2015 15:33:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <5638C276.7070206@mentor.com> X-detected-operating-system: by eggs.gnu.org: Windows NT kernel [generic] [fuzzy] X-Received-From: 192.94.38.131 On 03/11/15 15:19, Tom de Vries wrote: > I've dropped the two testcases from this patch, I'll commit in a > follow-up patch. Committed to gomp-4_0-branch, as attached. Thanks, - Tom Add goacc/kernels-loop-offload-alias-{none,ptr}.c 2015-11-03 Tom de Vries * c-c++-common/goacc/kernels-loop-offload-alias-none.c: New test. * c-c++-common/goacc/kernels-loop-offload-alias-ptr.c: New test. --- .../goacc/kernels-loop-offload-alias-none.c | 61 ++++++++++++++++++++++ .../goacc/kernels-loop-offload-alias-ptr.c | 44 ++++++++++++++++ 2 files changed, 105 insertions(+) create mode 100644 gcc/testsuite/c-c++-common/goacc/kernels-loop-offload-alias-none.c create mode 100644 gcc/testsuite/c-c++-common/goacc/kernels-loop-offload-alias-ptr.c diff --git a/gcc/testsuite/c-c++-common/goacc/kernels-loop-offload-alias-none.c b/gcc/testsuite/c-c++-common/goacc/kernels-loop-offload-alias-none.c new file mode 100644 index 0000000..bb96330 --- /dev/null +++ b/gcc/testsuite/c-c++-common/goacc/kernels-loop-offload-alias-none.c @@ -0,0 +1,61 @@ +/* { dg-additional-options "-O2" } */ +/* { dg-additional-options "-fdump-tree-optimized" } */ +/* { dg-additional-options "-fdump-tree-alias-all" } */ +/* { dg-additional-options "-foffload-alias=none" } */ + +#include + +#define N (1024 * 512) +#define COUNTERTYPE unsigned int + +static void +foo (unsigned int *a, unsigned int *b, unsigned int *c) +{ + for (COUNTERTYPE i = 0; i < N; i++) + a[i] = i * 2; + + for (COUNTERTYPE i = 0; i < N; i++) + b[i] = i * 4; + +#pragma acc kernels copyin (a[0:N], b[0:N]) copyout (c[0:N]) + { + for (COUNTERTYPE ii = 0; ii < N; ii++) + c[ii] = a[ii] + b[ii]; + } + + for (COUNTERTYPE i = 0; i < N; i++) + if (c[i] != a[i] + b[i]) + abort (); +} + +int +main (void) +{ + unsigned int *a; + unsigned int *b; + unsigned int *c; + + a = (unsigned int *)malloc (N * sizeof (unsigned int)); + b = (unsigned int *)malloc (N * sizeof (unsigned int)); + c = (unsigned int *)malloc (N * sizeof (unsigned int)); + + foo (a, b, c); + + free (a); + free (b); + free (c); + + return 0; +} + +/* Check that the loop has been split off into a function. */ +/* { dg-final { scan-tree-dump-times "(?n);; Function .*foo._omp_fn.0" 1 "optimized" } } */ + +/* { dg-final { scan-tree-dump-times "clique 1 base 1" 3 "alias" } } */ +/* { dg-final { scan-tree-dump-times "clique 1 base 2" 1 "alias" } } */ +/* { dg-final { scan-tree-dump-times "clique 1 base 3" 1 "alias" } } */ +/* { dg-final { scan-tree-dump-times "clique 1 base 4" 1 "alias" } } */ +/* { dg-final { scan-tree-dump-times "clique 1 base 5" 1 "alias" } } */ +/* { dg-final { scan-tree-dump-times "clique 1 base 6" 1 "alias" } } */ +/* { dg-final { scan-tree-dump-times "clique 1 base 7" 1 "alias" } } */ +/* { dg-final { scan-tree-dump-times "(?n)clique .* base .*" 9 "alias" } } */ diff --git a/gcc/testsuite/c-c++-common/goacc/kernels-loop-offload-alias-ptr.c b/gcc/testsuite/c-c++-common/goacc/kernels-loop-offload-alias-ptr.c new file mode 100644 index 0000000..de4f45a --- /dev/null +++ b/gcc/testsuite/c-c++-common/goacc/kernels-loop-offload-alias-ptr.c @@ -0,0 +1,44 @@ +/* { dg-additional-options "-O2" } */ +/* { dg-additional-options "-fdump-tree-optimized" } */ +/* { dg-additional-options "-fdump-tree-alias-all" } */ +/* { dg-additional-options "-foffload-alias=pointer" } */ + +#include + +#define N (1024 * 512) +#define COUNTERTYPE unsigned int + +unsigned int a[N]; +unsigned int b[N]; +unsigned int c[N]; + +int +main (void) +{ + for (COUNTERTYPE i = 0; i < N; i++) + a[i] = i * 2; + + for (COUNTERTYPE i = 0; i < N; i++) + b[i] = i * 4; + +#pragma acc kernels copyin (a[0:N], b[0:N]) copyout (c[0:N]) + { + for (COUNTERTYPE ii = 0; ii < N; ii++) + c[ii] = a[ii] + b[ii]; + } + + for (COUNTERTYPE i = 0; i < N; i++) + if (c[i] != a[i] + b[i]) + abort (); + + return 0; +} + +/* Check that the loop has been split off into a function. */ +/* { dg-final { scan-tree-dump-times "(?n);; Function .*main._omp_fn.0" 1 "optimized" } } */ + +/* { dg-final { scan-tree-dump-times "clique 1 base 1" 3 "alias" } } */ +/* { dg-final { scan-tree-dump-times "clique 1 base 2" 1 "alias" } } */ +/* { dg-final { scan-tree-dump-times "clique 1 base 3" 1 "alias" } } */ +/* { dg-final { scan-tree-dump-times "clique 1 base 4" 1 "alias" } } */ +/* { dg-final { scan-tree-dump-times "(?n)clique .* base .*" 6 "alias" } } */ -- 1.9.1