From patchwork Tue Oct 27 13:07:09 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 536618 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id B9015141365 for ; Wed, 28 Oct 2015 00:07:48 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=bxzOeGCZ; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :subject:to:references:cc:from:message-id:date:mime-version :in-reply-to:content-type; q=dns; s=default; b=ZICUotfTyNljuK9ME tdF+LRk2HbeEa8RAnZZt3hZdCB/mYbasM7fTH5Y8/DimnLosgkw4ANsUgZR/a/NO TphiYrCddSFcJbCD5nCg9bTNYl6MD1OgXgMo5Ct+Zq1K2wBMbPTBQTNy39ct1sg6 wy2aZm9KHXDOl6sJ/m5msrnqhg= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :subject:to:references:cc:from:message-id:date:mime-version :in-reply-to:content-type; s=default; bh=z7onoJfbtm2jP9BjVZ7/6by vn5Y=; b=bxzOeGCZuQSJJRvQjuJGAoN/JJDbvkT+r7S9PkQYnx2JSscPi4JYmpP ROG+vmOuDfJnbXCjrLZ9DgIZCJHSnbKQ07hzmHOsRMw0XVbI4UOaAgcZlBTttr5F OG2TGD8LiuHIQdP/apdZQcRkTYpn8+iJcrJmE0Xbx2NTOo+rG2iw= Received: (qmail 34209 invoked by alias); 27 Oct 2015 13:07:40 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 34187 invoked by uid 89); 27 Oct 2015 13:07:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-HELO: fencepost.gnu.org Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (208.118.235.10) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 27 Oct 2015 13:07:37 +0000 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57813) by fencepost.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1Zr3yQ-0000yH-U5 for gcc-patches@gnu.org; Tue, 27 Oct 2015 09:07:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zr3yK-0006BK-Lx for gcc-patches@gnu.org; Tue, 27 Oct 2015 09:07:34 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:65325) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zr3yK-0006BG-G6 for gcc-patches@gnu.org; Tue, 27 Oct 2015 09:07:28 -0400 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1Zr3yJ-0007HV-Mi from Tom_deVries@mentor.com ; Tue, 27 Oct 2015 06:07:28 -0700 Received: from [127.0.0.1] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.3.224.2; Tue, 27 Oct 2015 13:07:26 +0000 Subject: [PATCH, 5/6] Handle recursive restrict pointer in create_variable_info_for_1 To: Richard Biener References: <562E0CF5.8000606@mentor.com> <562E5381.5@mentor.com> <562F26E2.40906@mentor.com> <562F6D1A.4010001@mentor.com> CC: Richard Biener , "gcc-patches@gnu.org" From: Tom de Vries Message-ID: <562F76FD.1020904@mentor.com> Date: Tue, 27 Oct 2015 14:07:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <562F6D1A.4010001@mentor.com> X-detected-operating-system: by eggs.gnu.org: Windows NT kernel [generic] [fuzzy] X-Received-From: 192.94.38.131 On 27/10/15 13:24, Tom de Vries wrote: > Thinking it over a bit more, I realized the constraint handling started > to be messy. I've reworked the patch series to simplify that first. > > 1 Simplify constraint handling > 2 Rename make_restrict_var_constraints to make_param_constraints > 3 Add recursion to make_param_constraints > 4 Add handle_param parameter to create_variable_info_for_1 > 5 Handle recursive restrict pointer in create_variable_info_for_1 > 6 Handle restrict struct fields recursively > > Currently doing bootstrap and regtest on x86_64. > > I'll repost the patch series in reply to this message. A repost of the patch at https://gcc.gnu.org/ml/gcc-patches/2015-10/msg02779.html . With the constraint handling dealt with earlier, it has become rather minimal. Thanks, - Tom Handle recursive restrict pointer in create_variable_info_for_1 2015-10-26 Tom de Vries * tree-ssa-structalias.c (create_variable_info_for_1): Enable recursive handling of restrict pointers. * gcc.dg/tree-ssa/restrict-7.c: New test. --- gcc/testsuite/gcc.dg/tree-ssa/restrict-7.c | 12 ++++++++++++ gcc/tree-ssa-structalias.c | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.dg/tree-ssa/restrict-7.c diff --git a/gcc/testsuite/gcc.dg/tree-ssa/restrict-7.c b/gcc/testsuite/gcc.dg/tree-ssa/restrict-7.c new file mode 100644 index 0000000..f7a68c7 --- /dev/null +++ b/gcc/testsuite/gcc.dg/tree-ssa/restrict-7.c @@ -0,0 +1,12 @@ +/* { dg-do compile } */ +/* { dg-options "-O2 -fdump-tree-fre1" } */ + +int +f (int *__restrict__ *__restrict__ *__restrict__ a, int *b) +{ + *b = 1; + ***a = 2; + return *b; +} + +/* { dg-final { scan-tree-dump-times "return 1" 1 "fre1" } } */ diff --git a/gcc/tree-ssa-structalias.c b/gcc/tree-ssa-structalias.c index a639944..a297a36 100644 --- a/gcc/tree-ssa-structalias.c +++ b/gcc/tree-ssa-structalias.c @@ -5728,7 +5728,7 @@ create_variable_info_for_1 (tree decl, const char *name, bool handle_param) varinfo_t rvi; tree heapvar = build_fake_var_decl (TREE_TYPE (decl_type)); DECL_EXTERNAL (heapvar) = 1; - rvi = create_variable_info_for_1 (heapvar, "PARM_NOALIAS", false); + rvi = create_variable_info_for_1 (heapvar, "PARM_NOALIAS", true); rvi->is_restrict_var = 1; insert_vi_for_tree (heapvar, rvi); insert_restrict_pointed_var (vi, rvi); -- 1.9.1