From patchwork Tue Oct 13 16:11:53 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 529848 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4888A1402A8 for ; Wed, 14 Oct 2015 03:18:43 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=tdw5Agn4; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :subject:to:references:from:message-id:date:mime-version :in-reply-to:content-type; q=dns; s=default; b=YUQLNQguaz3TrHtsP FVN/70pzDSrZ4bSbs7n7lRni07kDEOvP4FY1d/I5J3dWPgRXY7fCa67/NbFBhdeS cA+wLJ2Us6sOZheB+gkF3LoD7i/QBD5wOYUmdgegMl+RMzV1GfPA0cyKWeuo4Sd0 I1XQyrlv49/unF6L5z1wv7QKv4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :subject:to:references:from:message-id:date:mime-version :in-reply-to:content-type; s=default; bh=aA/hJLpmCYhi/zkVPMjIdlP TDOg=; b=tdw5Agn4pdCHtGC0cpRAzo23X1PtowCSj/LQYST5ObROts1Qvphfq7G 2mjg6LMpY5pF5EGgjT26JXaJ/PEzL6kXWJIn6f2f1FNOvXF3y2fpQCFzNiA9NeFc YSjC64hBZN0uX0slDlAIlC7cuHVslUNwFfgbzV87m0E3lV4qlWzc= Received: (qmail 85264 invoked by alias); 13 Oct 2015 16:18:36 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 85251 invoked by uid 89); 13 Oct 2015 16:18:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL, BAYES_00, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: fencepost.gnu.org Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (208.118.235.10) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 13 Oct 2015 16:18:29 +0000 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40463) by fencepost.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1Zm2HT-0001Nd-7y for gcc-patches@gnu.org; Tue, 13 Oct 2015 12:18:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zm2Ch-0004zR-Ep for gcc-patches@gnu.org; Tue, 13 Oct 2015 12:13:36 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:50097) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zm2Ch-0004zA-8n for gcc-patches@gnu.org; Tue, 13 Oct 2015 12:13:31 -0400 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1Zm2Cf-0001ku-IV from Tom_deVries@mentor.com ; Tue, 13 Oct 2015 09:13:29 -0700 Received: from [127.0.0.1] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.3.224.2; Tue, 13 Oct 2015 17:12:40 +0100 Subject: Re: [gomp4, committed] Move kernels pass group before pass_fre To: "gcc-patches@gnu.org" , Jakub Jelinek References: <561D2A5B.8080002@mentor.com> From: Tom de Vries Message-ID: <561D2D49.5000100@mentor.com> Date: Tue, 13 Oct 2015 18:11:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <561D2A5B.8080002@mentor.com> X-detected-operating-system: by eggs.gnu.org: Windows NT kernel [generic] [fuzzy] X-Received-From: 192.94.38.131 On 13/10/15 17:59, Tom de Vries wrote: > Hi, > > this patch moves the kernels pass group to before pass_fre. Instead we > use pass_dominator_oacc_kernels in the pass group. > And that means we can get rid of the .omp_data_i init handling in tree-ssa-sccvn.c. Committed to gomp-4_0-branch. Thanks, - Tom Revert .omp_data_i init handling in tree-ssa-sccvn.c 2015-10-13 Tom de Vries Revert: 2015-04-21 Tom de Vries * tree-ssa-sccvn.c: Include omp-low.h. (visit_use): Handle .omp_data_i init conservatively. --- gcc/tree-ssa-sccvn.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/gcc/tree-ssa-sccvn.c b/gcc/tree-ssa-sccvn.c index d5964b4..5b06d29 100644 --- a/gcc/tree-ssa-sccvn.c +++ b/gcc/tree-ssa-sccvn.c @@ -58,7 +58,6 @@ along with GCC; see the file COPYING3. If not see #include "domwalk.h" #include "cgraph.h" #include "gimple-iterator.h" -#include "omp-low.h" /* This algorithm is based on the SCC algorithm presented by Keith Cooper and L. Taylor Simpson in "SCC-Based Value numbering" @@ -3623,8 +3622,7 @@ visit_use (tree use) { if (gimple_code (stmt) == GIMPLE_PHI) changed = visit_phi (stmt); - else if (gimple_has_volatile_ops (stmt) - || gimple_stmt_omp_data_i_init_p (stmt)) + else if (gimple_has_volatile_ops (stmt)) changed = defs_to_varying (stmt); else if (is_gimple_assign (stmt)) { -- 1.9.1