2015-10-02 Mikael Morin <mikael@gcc.gnu.org>
PR fortran/67758
* match.c (gfc_match_common): Delay the common_block pointer
assignment after error checking.
Delay the call to gfc_add_in_common attribute after the handling
of array specs.
* resolve.c (resolve_common_vars): Call gfc_add_in_common again.
2015-10-02 Mikael Morin <mikael@gcc.gnu.org>
PR fortran/67758
* gfortran.dg/common_24.f: New.
@@ -4330,10 +4330,6 @@ gfc_match_common (void)
if (m == MATCH_NO)
goto syntax;
- /* Store a ref to the common block for error checking. */
- sym->common_block = t;
- sym->common_block->refs++;
-
/* See if we know the current common block is bind(c), and if
so, then see if we can check if the symbol is (which it'll
need to be). This can happen if the bind(c) attr stmt was
@@ -4376,8 +4372,8 @@ gfc_match_common (void)
goto cleanup;
}
- if (!gfc_add_in_common (&sym->attr, sym->name, NULL))
- goto cleanup;
+ sym->common_block = t;
+ sym->common_block->refs++;
if (tail != NULL)
tail->common_next = sym;
@@ -4416,6 +4412,10 @@ gfc_match_common (void)
}
+ /* Add the in_common attribute, but ignore the reported errors
+ if any, and continue matching. */
+ gfc_add_in_common (&sym->attr, sym->name, NULL);
+
sym->common_head = t;
/* Check to see if the symbol is already in an equivalence group.
@@ -918,6 +918,12 @@ resolve_common_vars (gfc_common_head *common_block, bool named_common)
for (; csym; csym = csym->common_next)
{
+ /* gfc_add_in_common may have been called before, but the reported errors
+ have been ignored to continue parsing.
+ We do the checks again here. */
+ if (!csym->attr.use_assoc)
+ gfc_add_in_common (&csym->attr, csym->name, &common_block->where);
+
if (csym->value || csym->attr.data)
{
if (!csym->ns->is_block_data)
new file mode 100644
@@ -0,0 +1,11 @@
+c { dg-do compile }
+c PR fortran/67758
+c
+c Check the absence of ICE after emitting the error message
+c
+c Contributed by Ilya Enkovich <ienkovich@gcc.gnu.org>
+
+ COMMON /FMCOM / X(80 000 000)
+ CALL T(XX(A))
+ COMMON /FMCOM / XX(80 000 000) ! { dg-error "Unexpected COMMON" }
+ END