From patchwork Tue Sep 29 10:22:59 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 523765 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 5D9C414029C for ; Tue, 29 Sep 2015 20:23:44 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=BNtfgSlU; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :subject:to:references:from:message-id:date:mime-version :in-reply-to:content-type; q=dns; s=default; b=d6flaEb3MZqMEG+25 iZMwYcb3M8WLDdJtS4dY5Odg1gvWxHo9aVgsopXJj81WLK/0jjsORYwkX1Jsbgkh p4ca8vvLXNxZqvLFOUXzNEFhZxIWUAy9oWZjkUpE+ha2zmxmr9lmwhR8bxZ/98Kw CRUaEJJXuPVnDGBFd+tss+GaHY= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :subject:to:references:from:message-id:date:mime-version :in-reply-to:content-type; s=default; bh=iRN7UAUnZm79gD8WAYcXhC/ NcPk=; b=BNtfgSlUMJ/ggOhHtWnUwDa9tYROM1cuyLXG5o6hTpneDEV6nHU64P5 n8oHoQWr0OlcbbG8Yuk6tRPkBgpZjZetSGTPimCwcMKckISJI6PNP/ycJkq/mmpF 0oiybFpbWADxqFPKMrJqyEIkWxEBStiCXNfZswDzNWmBdsoON/IY= Received: (qmail 102405 invoked by alias); 29 Sep 2015 10:23:37 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 102394 invoked by uid 89); 29 Sep 2015 10:23:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL, BAYES_00, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: fencepost.gnu.org Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (208.118.235.10) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 29 Sep 2015 10:23:34 +0000 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35956) by fencepost.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1Zgs4K-0005eS-0r for gcc-patches@gnu.org; Tue, 29 Sep 2015 06:23:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zgs4F-0008MA-N4 for gcc-patches@gnu.org; Tue, 29 Sep 2015 06:23:31 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:49369) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zgs4F-0008LK-IC for gcc-patches@gnu.org; Tue, 29 Sep 2015 06:23:27 -0400 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1Zgs4D-0003zI-SV from Tom_deVries@mentor.com for gcc-patches@gnu.org; Tue, 29 Sep 2015 03:23:26 -0700 Received: from [127.0.0.1] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.3.224.2; Tue, 29 Sep 2015 11:23:24 +0100 Subject: Re: [gomp4, committed] Ignore reduction clauses in kernels region To: "gcc-patches@gnu.org" References: <560A5EC5.5060009@mentor.com> From: Tom de Vries Message-ID: <560A6683.5000605@mentor.com> Date: Tue, 29 Sep 2015 12:22:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <560A5EC5.5060009@mentor.com> X-detected-operating-system: by eggs.gnu.org: Windows NT kernel [generic] [fuzzy] X-Received-From: 192.94.38.131 On 29/09/15 11:49, Tom de Vries wrote: > Hi, > > this patch filters out reduction clauses in an oacc kernels region. This > fixes an ICE in the test-case. > > Committed to gomp-4_0-branch. I've committed this follow-up patch that marks the function ctx_in_oacc_kernels_region static, and adds the missing function header comment. Thanks, - Tom Make ctx_in_oacc_kernels_region static 2015-09-29 Tom de Vries * omp-low.c (ctx_in_oacc_kernels_region): Make static. Add missing function header comment. --- gcc/omp-low.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/gcc/omp-low.c b/gcc/omp-low.c index 75044a5..64f6168 100644 --- a/gcc/omp-low.c +++ b/gcc/omp-low.c @@ -2579,7 +2579,9 @@ oacc_loop_or_target_p (gimple *stmt) && gimple_omp_for_kind (stmt) == GF_OMP_FOR_KIND_OACC_LOOP)); } -bool +/* Return true if ctx is part of an oacc kernels region. */ + +static bool ctx_in_oacc_kernels_region (omp_context *ctx) { for (;ctx != NULL; ctx = ctx->outer) -- 1.9.1