From patchwork Tue Sep 1 16:23:25 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 512922 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 7C5E214056B for ; Wed, 2 Sep 2015 02:23:56 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=MzPfFUOV; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :subject:to:references:cc:from:message-id:date:mime-version :in-reply-to:content-type; q=dns; s=default; b=QF+nzJhoroRTnBJIV 1Dqvg3J3ZUJK6pxYYCyIOA8LupQK2N7LTRd+qmhTTcKKwtMmx6quiVm8J5h9cVN4 V/dkaQNExVsJpqPD+C4rHla2IEFeLB9ZXZu+4UA76vz8ZHpKuC3Yzpu1T4Cc2pFv nqPPfddm1LditIFH0KAuHo1+4g= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :subject:to:references:cc:from:message-id:date:mime-version :in-reply-to:content-type; s=default; bh=EACgPiVbi2otyH203KB4LPE /Nw4=; b=MzPfFUOVr6I5wVgcGx6KTL4Vqfg98zsCpKtEkwsWEB9H/pEjIDSgJDg 7BOXIJngy4j3yFrinNwQBNTEvdGXly7sQ17/iuhx0eYneSYRa0jOPYSNrvopdzQe i3EreflGDTw4vR4liKtLGYHHUwV/Ma6U0uBdglmRL4QvTU0GCAss= Received: (qmail 122878 invoked by alias); 1 Sep 2015 16:23:49 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 122865 invoked by uid 89); 1 Sep 2015 16:23:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 01 Sep 2015 16:23:42 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-03.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1ZWoLS-0000ND-Jx from Tom_deVries@mentor.com ; Tue, 01 Sep 2015 09:23:39 -0700 Received: from [127.0.0.1] (137.202.0.76) by SVR-IES-FEM-03.mgc.mentorg.com (137.202.0.108) with Microsoft SMTP Server id 14.3.224.2; Tue, 1 Sep 2015 17:23:37 +0100 Subject: Re: [gomp4] New reduction infrastructure for OpenACC To: Cesar Philippidis References: <55D4DC16.7020106@codesourcery.com> <55E59FBA.1010005@mentor.com> CC: "gcc-patches@gcc.gnu.org" , Nathan Sidwell , Jakub Jelinek From: Tom de Vries Message-ID: <55E5D0FD.5000408@mentor.com> Date: Tue, 1 Sep 2015 18:23:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <55E59FBA.1010005@mentor.com> On 01/09/15 14:53, Tom de Vries wrote: > On 19/08/15 21:42, Cesar Philippidis wrote: >> +DEFHOOK >> +(reduction, >> +"This hook is used by the oacc_transform pass to expand calls to the\n\ >> +internal functions @var{GOACC_REDUCTION_SETUP},\n\ >> +@var{GOACC_REDUCTION_INIT},\n\ @var{GOACC_REDUCTION_FINI} and\n\ >> @var{GOACC_REDUCTION_TEARDOWN} into a sequence of gimple >> instructions.\n\ @var{call} is gimple statement containing the call to >> the function. This\n\ hook removes statement @var{call} after the >> expanded sequence has been\n\ inserted. This hook is also responsible >> for allocating any storage for\n\ reductions when necessary. It >> returns @var{true} if the expanded\n\ >> +sequence introduces any calls to OpenACC-specific internal functions.", >> +bool, (gimple call), >> +default_goacc_reduction) >> + > > This causes a gomp-4_0-branch bootstrap error: > ... > src/gcc/target.def:1685:1: error: unknown escape sequence: '\040' [-Werror] > ... > > Currently testing attached patch, which allows 'make build/genhooks.o' > to succeed. > Committed as attached. Thanks, - Tom Fix unknown escape sequence error in DEFHOOK reduction 2015-09-01 Tom de Vries * target.def: Fix unknown escape sequence \040 error in reduction DEFHOOK. * doc/tm.texi: Regenerate. --- gcc/doc/tm.texi | 12 ++++++------ gcc/target.def | 8 +++++++- 2 files changed, 13 insertions(+), 7 deletions(-) diff --git a/gcc/doc/tm.texi b/gcc/doc/tm.texi index f53a54e..a151a10 100644 --- a/gcc/doc/tm.texi +++ b/gcc/doc/tm.texi @@ -5772,12 +5772,12 @@ is no RTL expanders for them. This hook is used by the oacc_transform pass to expand calls to the internal functions @var{GOACC_REDUCTION_SETUP}, @var{GOACC_REDUCTION_INIT}, - @var{GOACC_REDUCTION_FINI} and - @var{GOACC_REDUCTION_TEARDOWN} into a sequence of gimple instructions. - @var{call} is gimple statement containing the call to the function. This - hook removes statement @var{call} after the expanded sequence has been - inserted. This hook is also responsible for allocating any storage for - reductions when necessary. It returns @var{true} if the expanded +@var{GOACC_REDUCTION_FINI} and +@var{GOACC_REDUCTION_TEARDOWN} into a sequence of gimple instructions. +@var{call} is gimple statement containing the call to the function. This +hook removes statement @var{call} after the expanded sequence has been +inserted. This hook is also responsible for allocating any storage for +reductions when necessary. It returns @var{true} if the expanded sequence introduces any calls to OpenACC-specific internal functions. @end deftypefn diff --git a/gcc/target.def b/gcc/target.def index 22e04f6..80b401f 100644 --- a/gcc/target.def +++ b/gcc/target.def @@ -1684,7 +1684,13 @@ DEFHOOK (reduction, "This hook is used by the oacc_transform pass to expand calls to the\n\ internal functions @var{GOACC_REDUCTION_SETUP},\n\ -@var{GOACC_REDUCTION_INIT},\n\ @var{GOACC_REDUCTION_FINI} and\n\ @var{GOACC_REDUCTION_TEARDOWN} into a sequence of gimple instructions.\n\ @var{call} is gimple statement containing the call to the function. This\n\ hook removes statement @var{call} after the expanded sequence has been\n\ inserted. This hook is also responsible for allocating any storage for\n\ reductions when necessary. It returns @var{true} if the expanded\n\ +@var{GOACC_REDUCTION_INIT},\n\ +@var{GOACC_REDUCTION_FINI} and\n\ +@var{GOACC_REDUCTION_TEARDOWN} into a sequence of gimple instructions.\n\ +@var{call} is gimple statement containing the call to the function. This\n\ +hook removes statement @var{call} after the expanded sequence has been\n\ +inserted. This hook is also responsible for allocating any storage for\n\ +reductions when necessary. It returns @var{true} if the expanded\n\ sequence introduces any calls to OpenACC-specific internal functions.", bool, (gimple call), default_goacc_reduction) -- 1.9.1