From patchwork Tue Sep 1 12:53:14 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 512810 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 98451140761 for ; Tue, 1 Sep 2015 22:53:39 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=ZMPo8Inj; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :subject:to:references:from:cc:message-id:date:mime-version :in-reply-to:content-type; q=dns; s=default; b=mo3g3DA6H3pw+qMsv fALL1N8UodwI8ELKXUs3ZRlxATHLn4rKnkuNjcYSfwDp7G8SwdWsCgDFFp2jqHKk +8bYbvciJ+JRVpK/MnirP27KL4zmFBU0w+lhef+GkbEF067ixQbno3YBwUjWFnBe ML+r/aXIIxaPCKw5cT4bwPwtW4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :subject:to:references:from:cc:message-id:date:mime-version :in-reply-to:content-type; s=default; bh=iFcbXP8CiC+eMRTyrgsW/0C J9V0=; b=ZMPo8InjBcXfE9cl6x3AecKSKF6pZr2YAoF8z2kVOTPjku3hJhciwND 5w34CyMayCn+m3E+VY1oIxgVLwjujNllioHYfCo4+AbwF6m7HSk6KFvGvBH4HUMB GoEmGktz+HeNIWzYftWd8sIGmmUeLCewco4TdYDTIO3gZ95tEC6M= Received: (qmail 44770 invoked by alias); 1 Sep 2015 12:53:32 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 44756 invoked by uid 89); 1 Sep 2015 12:53:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 01 Sep 2015 12:53:30 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-02.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1ZWl43-0000vU-EI from Tom_deVries@mentor.com ; Tue, 01 Sep 2015 05:53:27 -0700 Received: from [127.0.0.1] (137.202.0.76) by SVR-IES-FEM-02.mgc.mentorg.com (137.202.0.106) with Microsoft SMTP Server id 14.3.224.2; Tue, 1 Sep 2015 13:53:26 +0100 Subject: Re: [gomp4] New reduction infrastructure for OpenACC To: Cesar Philippidis References: <55D4DC16.7020106@codesourcery.com> From: Tom de Vries CC: "gcc-patches@gcc.gnu.org" , Nathan Sidwell , Jakub Jelinek Message-ID: <55E59FBA.1010005@mentor.com> Date: Tue, 1 Sep 2015 14:53:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <55D4DC16.7020106@codesourcery.com> On 19/08/15 21:42, Cesar Philippidis wrote: > +DEFHOOK > +(reduction, > +"This hook is used by the oacc_transform pass to expand calls to the\n\ > +internal functions @var{GOACC_REDUCTION_SETUP},\n\ > +@var{GOACC_REDUCTION_INIT},\n\ @var{GOACC_REDUCTION_FINI} and\n\ @var{GOACC_REDUCTION_TEARDOWN} into a sequence of gimple instructions.\n\ @var{call} is gimple statement containing the call to the function. This\n\ hook removes statement @var{call} after the expanded sequence has been\n\ inserted. This hook is also responsible for allocating any storage for\n\ reductions when necessary. It returns @var{true} if the expanded\n\ > +sequence introduces any calls to OpenACC-specific internal functions.", > +bool, (gimple call), > +default_goacc_reduction) > + This causes a gomp-4_0-branch bootstrap error: ... src/gcc/target.def:1685:1: error: unknown escape sequence: '\040' [-Werror] ... Currently testing attached patch, which allows 'make build/genhooks.o' to succeed. Thanks, - Tom --- gcc/target.def 2015-09-01 01:45:41.851372425 -0700 +++ gcc/target.def 2015-09-01 05:41:48.280961137 -0700 @@ -1684,7 +1684,13 @@ (reduction, "This hook is used by the oacc_transform pass to expand calls to the\n\ internal functions @var{GOACC_REDUCTION_SETUP},\n\ -@var{GOACC_REDUCTION_INIT},\n\ @var{GOACC_REDUCTION_FINI} and\n\ @var{GOACC_REDUCTION_TEARDOWN} into a sequence of gimple instructions.\n\ @var{call} is gimple statement containing the call to the function. This\n\ hook removes statement @var{call} after the expanded sequence has been\n\ inserted. This hook is also responsible for allocating any storage for\n\ reductions when necessary. It returns @var{true} if the expanded\n\ +@var{GOACC_REDUCTION_INIT},\n\ +@var{GOACC_REDUCTION_FINI} and\n\ +@var{GOACC_REDUCTION_TEARDOWN} into a sequence of gimple instructions.\n\ +@var{call} is gimple statement containing the call to the function. This\n\ +hook removes statement @var{call} after the expanded sequence has been\n\ +inserted. This hook is also responsible for allocating any storage for\n\ +reductions when necessary. It returns @var{true} if the expanded\n\ sequence introduces any calls to OpenACC-specific internal functions.", bool, (gimple call), default_goacc_reduction)