From patchwork Mon Jul 13 09:49:33 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 494483 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 32BE3140774 for ; Mon, 13 Jul 2015 19:49:58 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=r12HJaI2; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; q=dns; s=default; b=tg3JDR7ho/uRcQcZV kDC09oZ3ocbrtfrWlVt8x2drCQposjE90SRqg6iK8QvUcmm8myNRUjvj+JFIpFcC AxnbLV9hb/n3jwfO/GuArXRiIzWhYhVDIhU71JcJhJmEDwTKZUPRzNHusMAS9sB6 1cwKYGIZEmegHiOyyE/S/SVGOA= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; s=default; bh=F6JUUoxGzDBn8zfO4u1Hof4 1eMs=; b=r12HJaI2Vqa0adZAVqfPwVF8f+mQydhcK5duvX+QlHksVezRBCHvVoC EQ35QTLH1FKAVRM6gjkC1YA2EhmNiI6uRzhu1ze2tO+GMFLQYC6HlUOSgx2hUgnc WN07u+Zkk58IBUqbKYlNvrbbeT+iLCkKCUy3T1jjIAnj8fpldWJM= Received: (qmail 18287 invoked by alias); 13 Jul 2015 09:49:52 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 18278 invoked by uid 89); 13 Jul 2015 09:49:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-HELO: fencepost.gnu.org Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (208.118.235.10) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 13 Jul 2015 09:49:51 +0000 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35914) by fencepost.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ZEaMu-0004ZZ-JE for gcc-patches@gnu.org; Mon, 13 Jul 2015 05:49:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZEaMr-0000p6-41 for gcc-patches@gnu.org; Mon, 13 Jul 2015 05:49:48 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:64013) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZEaMq-0000op-Te for gcc-patches@gnu.org; Mon, 13 Jul 2015 05:49:45 -0400 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1ZEaMo-0001aj-4j from Tom_deVries@mentor.com ; Mon, 13 Jul 2015 02:49:42 -0700 Received: from [127.0.0.1] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.3.224.2; Mon, 13 Jul 2015 10:49:40 +0100 Message-ID: <55A389AD.5010203@mentor.com> Date: Mon, 13 Jul 2015 11:49:33 +0200 From: Tom de Vries User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Jakub Jelinek , Thomas Schwinge CC: "gcc-patches@gnu.org" Subject: [Committed] Mark *.omp_data_i as non-trapping References: <55A2618A.7050503@mentor.com> <87io9o1nbn.fsf@kepler.schwinge.homeip.net> <20150713083642.GO1788@tucnak.redhat.com> In-Reply-To: <20150713083642.GO1788@tucnak.redhat.com> X-detected-operating-system: by eggs.gnu.org: Windows NT kernel [generic] [fuzzy] X-Received-From: 192.94.38.131 [ was: Re: [gomp4, committed] Handle nested loops in kernels regions ] On 13/07/15 10:36, Jakub Jelinek wrote: > On Mon, Jul 13, 2015 at 10:19:56AM +0200, Thomas Schwinge wrote: >>> We rely on pass_lim to move the *.omp_data_i loads out of the loop nest. >>> For the test-case, pass_lim was managing to move the load out of the >>> inner loop, but not the outer loop, because the load was classified as >>> 'MOVE_PRESERVE_EXECUTION'. By marking the *.omp_data_i load >>> non-trapping, it's now classified as 'MOVE_POSSIBLE', and moved out of >>> the loop nest. >> >> Should this go into trunk already? (Jakub?) > > I think so. > I already bootstrapped and regtested (on x86_64) the patch on top of trunk. Committed to trunk. Thanks, - Tom Mark *.omp_data_i as non-trapping 2015-07-12 Tom de Vries * omp-low.c (build_receiver_ref): Mark *.omp_data_i as non-trapping. --- gcc/omp-low.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gcc/omp-low.c b/gcc/omp-low.c index 22848a0..3135606 100644 --- a/gcc/omp-low.c +++ b/gcc/omp-low.c @@ -1127,6 +1127,7 @@ build_receiver_ref (tree var, bool by_ref, omp_context *ctx) field = x; x = build_simple_mem_ref (ctx->receiver_decl); + TREE_THIS_NOTRAP (x) = 1; x = omp_build_component_ref (x, field); if (by_ref) x = build_simple_mem_ref (x); -- 1.9.1