From patchwork Wed Jul 8 12:45:49 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 492887 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 14E661402B5 for ; Wed, 8 Jul 2015 22:46:34 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=u1PTXFBw; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; q=dns; s=default; b=pJP+sekWLZLAoNmM+ AW5vEavFNnLTVg2sHzOdvx2+9WEHRAJzJNEwf66c5jmnqJJtLMAtY9Ay/FAqmGl7 Avkf2B00wkqBNlA/Z0YFgu0R1JV/emxRYNiMHR3NsMg7t3J8ND4PPPc2ujSf153T YDBk9C2rzf0DB5AZiKyqx5UdNc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; s=default; bh=B1zedcnUQ55E+Eb+ncVEHON wteE=; b=u1PTXFBwgqLm4XIzeA6vtjXDvAatAnCuG/ATSOLzlVyppr3lpfzLcCZ 3MmaLzSPCRLwmxYicE0t36sErh7mDE9TUJLVNd5J9PuemCTys80cnACYPCwIodE1 HAZbqzgoRe8DCayY7NG1UNORJ97IZFj+4YvbdJchaDRmzlszmlPw= Received: (qmail 125629 invoked by alias); 8 Jul 2015 12:46:28 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 123527 invoked by uid 89); 8 Jul 2015 12:46:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-HELO: fencepost.gnu.org Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (208.118.235.10) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 08 Jul 2015 12:46:26 +0000 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60780) by fencepost.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ZCok4-0000De-3l for gcc-patches@gnu.org; Wed, 08 Jul 2015 08:46:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZCojy-0004JS-Uw for gcc-patches@gnu.org; Wed, 08 Jul 2015 08:46:23 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:46319) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCojy-0004FI-P3 for gcc-patches@gnu.org; Wed, 08 Jul 2015 08:46:18 -0400 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1ZCojr-0000IM-2L from Tom_deVries@mentor.com ; Wed, 08 Jul 2015 05:46:11 -0700 Received: from [127.0.0.1] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.3.224.2; Wed, 8 Jul 2015 13:46:09 +0100 Message-ID: <559D1B7D.6020209@mentor.com> Date: Wed, 8 Jul 2015 14:45:49 +0200 From: Tom de Vries User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Andreas Schwab CC: Richard Biener , "gcc-patches@gnu.org" Subject: Re: [PATCH, 2/2][PR66642] Add empty loop exit block in transform_to_exit_first_loop_alt References: <558BB12B.7060108@mentor.com> In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Windows NT kernel [generic] [fuzzy] X-Received-From: 192.94.38.131 On 08/07/15 12:40, Andreas Schwab wrote: > Tom de Vries writes: > >> * testsuite/libgomp.c/parloops-exit-first-loop-alt-3.c (main): Test low >> iteration count case. > > ../../../../libgomp/testsuite/libgomp.c/parloops-exit-first-loop-alt-3.c: In function 'main': > ../../../../libgomp/testsuite/libgomp.c/parloops-exit-first-loop-alt-3.c:40:9: error: too few arguments to function 'f' > ../../../../libgomp/testsuite/libgomp.c/parloops-exit-first-loop-alt-3.c:13:1: note: declared here > Hi, Thanks for letting me know. The failure is due to interference with the test-case bit of patch 'Use max_loop_iterations in transform_to_exit_first_loop_alt'. Fixed and committed as obvious in attached patch. Thanks, - Tom Fix libgomp.c/parloops-exit-first-loop-alt{,-3}.c testcases 2015-07-08 Tom de Vries * testsuite/libgomp.c/parloops-exit-first-loop-alt-3.c (main): Fix second call to f. * testsuite/libgomp.c/parloops-exit-first-loop-alt.c: Same. --- libgomp/testsuite/libgomp.c/parloops-exit-first-loop-alt-3.c | 2 +- libgomp/testsuite/libgomp.c/parloops-exit-first-loop-alt.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libgomp/testsuite/libgomp.c/parloops-exit-first-loop-alt-3.c b/libgomp/testsuite/libgomp.c/parloops-exit-first-loop-alt-3.c index 958e554..78365e8 100644 --- a/libgomp/testsuite/libgomp.c/parloops-exit-first-loop-alt-3.c +++ b/libgomp/testsuite/libgomp.c/parloops-exit-first-loop-alt-3.c @@ -37,7 +37,7 @@ main (void) abort (); /* Test low iteration count case. */ - res = f (10); + res = f (10, a); if (res != 25) abort (); diff --git a/libgomp/testsuite/libgomp.c/parloops-exit-first-loop-alt.c b/libgomp/testsuite/libgomp.c/parloops-exit-first-loop-alt.c index 557764d..9d94cf8 100644 --- a/libgomp/testsuite/libgomp.c/parloops-exit-first-loop-alt.c +++ b/libgomp/testsuite/libgomp.c/parloops-exit-first-loop-alt.c @@ -59,7 +59,7 @@ main (void) init (); - f (10); + f (10, a, b, c); for (i = 0; i < N; i++) { -- 1.9.1