From patchwork Wed Jul 1 10:10:37 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 490024 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 7AE641402B0 for ; Wed, 1 Jul 2015 20:11:02 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=vHAsUSeD; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; q=dns; s=default; b=T9BlwNEuDqXyBiSiQ HnCK8LcIs0h5fHnCF6z31b+C8b3DAICYf6/DU21h/JgAudPIm9Wo5cCPtMa99Pp1 12IdZHX+jDCgBcBsaHIEFuw0L2LLyvIXqkjxbkJnuhocZ65FTH5PvnZj3LHTkfaN li7LzHpp6HtzR5ZhYob/+WnqVU= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; s=default; bh=gKqHYzeFzEeLrLv1g98h28L CTOk=; b=vHAsUSeDYt+jnnyDNT3vJA4pDY5+/lr4/L9qTQWSSsbGCTFFN9xEnYo HKALIZW1BdWZ8Sms/0mV4pw7/Ils6dvgK66LDhTWPG5BiMYTapfTv9ofZ6lemu1O ki0OdY2jUpSpH3JBD009e68X+YupvPIHW6gYFGIiZth7ZPkIIqgE= Received: (qmail 44776 invoked by alias); 1 Jul 2015 10:10:55 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 44755 invoked by uid 89); 1 Jul 2015 10:10:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 01 Jul 2015 10:10:53 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-02.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1ZAEyd-0004BM-CM from Tom_deVries@mentor.com ; Wed, 01 Jul 2015 03:10:47 -0700 Received: from [127.0.0.1] (137.202.0.76) by SVR-IES-FEM-02.mgc.mentorg.com (137.202.0.106) with Microsoft SMTP Server id 14.3.224.2; Wed, 1 Jul 2015 11:10:45 +0100 Message-ID: <5593BC9D.2030802@mentor.com> Date: Wed, 1 Jul 2015 12:10:37 +0200 From: Tom de Vries User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Thomas Schwinge , CC: Jakub Jelinek Subject: Re: libgomp: libgomp.oacc-c-c++-common/lib-62.c is for acc_device_nvidia only References: <54FF0C91.8020307@mentor.com> <871tj1rdfc.fsf@schwinge.name> <87pp6gvj3v.fsf@kepler.schwinge.homeip.net> <878ud3pdfr.fsf@schwinge.name> <87zj5jnmk1.fsf@schwinge.name> <87r3p8cf27.fsf@kepler.schwinge.homeip.net> In-Reply-To: <87r3p8cf27.fsf@kepler.schwinge.homeip.net> On 19/06/15 09:50, Thomas Schwinge wrote: > Hi! > > On Tue, 5 May 2015 16:09:18 +0200, I wrote: >> I don't know why libgomp.oacc-c-c++-common/lib-62.c contains this >> explicit acc_init call with acc_device_nvidia -- generally, the test >> cases should not contain such unconditional statements. So, let's then >> please remove this. See >> libgomp/testsuite/libgomp.oacc-c-c++-common/lib-66.c for a very similar >> test case, which does this differently. > > Committed in r224640: > > commit 3625ad60ab1ad783f4afead68f44b19011e4780d > Author: tschwinge > Date: Fri Jun 19 07:41:44 2015 +0000 > > libgomp: libgomp.oacc-c-c++-common/lib-62.c is for acc_device_nvidia only > > libgomp/ > * testsuite/libgomp.oacc-c-c++-common/lib-62.c: Only consider for > acc_device_nvidia. > > git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@224640 138bc75d-0d04-0410-961f-82ee72b054a4 Hi Thomas, I've committed attached patch to gomp-4_0-branch, before finding this patch (which is a bit more thorough). You can drop it with the next merge from trunk. Thanks, - Tom Run libgomp.oacc-c-c++-common/lib-62.c only for nvidia 2015-07-01 Tom de Vries * testsuite/libgomp.oacc-c-c++-common/lib-62.c: Only run for nvidia. --- libgomp/testsuite/libgomp.oacc-c-c++-common/lib-62.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-62.c b/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-62.c index 47dc953..6e6f8c5 100644 --- a/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-62.c +++ b/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-62.c @@ -1,4 +1,4 @@ -/* { dg-do run } */ +/* { dg-do run { target openacc_nvidia_accel_selected } } */ #include #include -- 1.9.1