From patchwork Thu Jun 25 07:02:36 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 488303 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 8FB1F14007F for ; Thu, 25 Jun 2015 17:03:10 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=gMKguWiD; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; q=dns; s=default; b=uaIflxv9Z8b2gun41 5cZClBeDHeXtApB4hVgsWR8+Y3/7Trlg/HU7sMfz6ISIkXRprkgshY+7brNqFF4U Az8EPQEcAxu0ccUKHQ/M4d6jcV3wmQ5YN25jFHL1VSPoXxVuHRB+EYqUPvejL5VW XyDb+wJMRHfgOjY3D0kEi3cFP4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; s=default; bh=mtB0z60sqRQIK0hSsznaSOq JsYQ=; b=gMKguWiDl7XL1oUIc+G7vCHQGU7s8Wi74DdINWRqzMxeGUqnMAUiomh ukQ+7K9OiBYizBDwUlTpgaqWtOQveO8e/8QtHjNKQ2J8rgcc3rYx2xuhYJD0wnWQ ecajKUMl/03/GY20vs5LfUdI0J59zriTTPiMB/nHqMWuYfT5aTGw= Received: (qmail 21732 invoked by alias); 25 Jun 2015 07:03:03 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 21720 invoked by uid 89); 25 Jun 2015 07:03:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-HELO: fencepost.gnu.org Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (208.118.235.10) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 25 Jun 2015 07:03:01 +0000 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44618) by fencepost.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1Z81Bb-0002fX-Jv for gcc-patches@gnu.org; Thu, 25 Jun 2015 03:02:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z81BW-0003U1-9g for gcc-patches@gnu.org; Thu, 25 Jun 2015 03:02:59 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:37178) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z81BW-0003Tn-3O for gcc-patches@gnu.org; Thu, 25 Jun 2015 03:02:54 -0400 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-02.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1Z81BT-0007Dg-Jz from Tom_deVries@mentor.com ; Thu, 25 Jun 2015 00:02:51 -0700 Received: from [127.0.0.1] (137.202.0.76) by SVR-IES-FEM-02.mgc.mentorg.com (137.202.0.106) with Microsoft SMTP Server id 14.3.224.2; Thu, 25 Jun 2015 08:02:47 +0100 Message-ID: <558BA78C.9020605@mentor.com> Date: Thu, 25 Jun 2015 09:02:36 +0200 From: Tom de Vries User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Richard Biener CC: "gcc-patches@gnu.org" Subject: Re: [PATCH] Check dominator info in compute_dominance_frontiers References: <5587C18A.9050304@mentor.com> <5587F277.1080401@mentor.com> <5588416F.1070702@mentor.com> In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Windows NT kernel [generic] [fuzzy] X-Received-From: 192.94.38.131 On 23/06/15 11:31, Richard Biener wrote: > On Mon, Jun 22, 2015 at 7:10 PM, Tom de Vries wrote: >> On 22/06/15 13:47, Richard Biener wrote: >>>> >>>> (eventually also for the case where we >>>>>> end up only computing the fast-query stuff). >>>> >> >> Like this? >> ... >> diff --git a/gcc/dominance.c b/gcc/dominance.c >> index 9c66ca2..58fc6fd 100644 >> --- a/gcc/dominance.c >> +++ b/gcc/dominance.c >> @@ -679,6 +679,12 @@ calculate_dominance_info (enum cdi_direction dir) >> free_dom_info (&di); >> dom_computed[dir_index] = DOM_NO_FAST_QUERY; >> } >> + else >> + { >> +#if ENABLE_CHECKING >> + verify_dominators (CDI_DOMINATORS); >> +#endif >> + } >> >> compute_dom_fast_query (dir); > > Yeah. > I realized we actually want to verify 'dir' rather than 'CDI_DOMINATORS'. The patch also fixes this for the early-out verification. Bootstrapped and reg-tested on x86_64. Committed to trunk. Thanks, - Tom Verify reused dominators info in calculate_dominance_info 2015-06-24 Tom de Vries * dominance.c (calculate_dominance_info): Fix verify_dominators call argument. Call verify_dominator when reusing dominator info. --- gcc/dominance.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/gcc/dominance.c b/gcc/dominance.c index 9c66ca2..fb61596 100644 --- a/gcc/dominance.c +++ b/gcc/dominance.c @@ -648,7 +648,7 @@ calculate_dominance_info (enum cdi_direction dir) if (dom_computed[dir_index] == DOM_OK) { #if ENABLE_CHECKING - verify_dominators (CDI_DOMINATORS); + verify_dominators (dir); #endif return; } @@ -679,6 +679,12 @@ calculate_dominance_info (enum cdi_direction dir) free_dom_info (&di); dom_computed[dir_index] = DOM_NO_FAST_QUERY; } + else + { +#if ENABLE_CHECKING + verify_dominators (dir); +#endif + } compute_dom_fast_query (dir); -- 1.9.1