From patchwork Fri May 29 10:48:34 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Lawrence X-Patchwork-Id: 477786 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 8F62F140E5E for ; Fri, 29 May 2015 20:48:49 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=B3rzQsGs; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; q=dns; s= default; b=fpnhDuSvyVe5Ec1gatT6Tha9/b8ISxNnazoRjCIWItUxAz02HNfya 0LqYqTYVk2Lo6i4Z01OIgAbIouzg+IkAgvzyANC1PXMjspgrwZqQ+FLlwL9g0R9Q Zp4KLSawGdLtAuLfS9Px5foJ34O3IS1Q9KuTq1vh92G2RqnM1SEwGo= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; s=default; bh=B2QC8tnPD+uWoE1KX8ivNjTLqFw=; b=B3rzQsGs9yHY6xCQFfANGUB6w01q X7bVhemBt/o7bugtFnOv+jiCZHpENX1VXf/zPsjPD3uJgdQwFjXTnTp1MxjNc9hO OfEeORaeadh8KhOam2mKGg9AOPfceAfJ8bQ840DKNJLOtxWScrCa1+VkiUWaO4HW B0k8CtSpK+zTl50= Received: (qmail 97498 invoked by alias); 29 May 2015 10:48:42 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 97484 invoked by uid 89); 29 May 2015 10:48:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL, BAYES_00, SPF_PASS autolearn=ham version=3.3.2 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (207.82.80.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 29 May 2015 10:48:40 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by uk-mta-18.uk.mimecast.lan; Fri, 29 May 2015 11:48:35 +0100 Received: from [10.2.207.65] ([10.1.2.79]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Fri, 29 May 2015 11:48:34 +0100 Message-ID: <55684402.4010307@arm.com> Date: Fri, 29 May 2015 11:48:34 +0100 From: Alan Lawrence User-Agent: Thunderbird 2.0.0.24 (X11/20101213) MIME-Version: 1.0 To: Christophe Lyon CC: "gcc-patches@gcc.gnu.org" , James Greenhalgh Subject: Re: [PATCH][ARM/AArch64 Testsuite] Cleanup advsimd-intrinsics.exp, removing unnecessary loop References: <55674646.4060306@arm.com> In-Reply-To: X-MC-Unique: WB40tPVoRRecks329TlyLA-1 X-IsSubscribed: yes Christophe Lyon wrote: > > This looks OK, but why can't you also drop the other torture-related > lines as you did in your previous patch? > I mean: > load_lib c-torture.exp > load_lib torture-options.exp > etc... We need c-torture.exp in order to set-torture-options; we need to set-torture-options to get the right list of variants, as otherwise we lose "-Og -g" (as I did in my original patch 13/14 for float16). However, I think we can drop the rest - here's v2, which I've cross-tested on aarch64-none-elf, aarch64_be-none-elf and arm-none-eabi: diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/advsimd-intrins index 583832a..4679a73 100644 --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/advsimd-intrinsics.exp +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/advsimd-intrinsics.exp @@ -27,8 +27,6 @@ load_lib gcc-dg.exp # Initialize `dg'. load_lib c-torture.exp -load_lib target-supports.exp -load_lib torture-options.exp dg-init @@ -48,29 +46,15 @@ if {[istarget arm*-*-*]} then { } } -torture-init set-torture-options $C_TORTURE_OPTIONS {{}} $LTO_TORTURE_OPTIONS # Make sure Neon flags are provided, if necessary. set additional_flags [add_options_for_arm_neon ""] # Main loop. -foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.c]] { - # If we're only testing specific files and this isn't one of them, skip it. - if ![runtest_file_p $runtests $src] then { - continue - } - - # runtest_file_p is already run above, and the code below can run - # runtest_file_p again, make sure everything for this test is - # performed if the above runtest_file_p decided this runtest - # instance should execute the test - gcc_parallel_test_enable 0 - gcc-dg-runtest $src "" $additional_flags - gcc_parallel_test_enable 1 -} +gcc-dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.c]] \ + "" ${additional_flags} # All done. set dg-do-what-default ${save-dg-do-what-default}