From patchwork Fri May 15 08:28:57 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ramana Radhakrishnan X-Patchwork-Id: 472669 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id B9F75140D26 for ; Fri, 15 May 2015 18:29:10 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=XTbyjaF2; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; q=dns; s=default; b=OQ3oHW6q3rhcGsR6/ R13XGKh4VosuZxwbwKM8vo7+mccsqwdfs7auOlp+oiL5Bv2RbqCWgwG+Ec7QCTuV NsaE8YlmG1bxfZc4FCDhjCXdndMpkZ8b5p+CA1PW3v/kG5QcKdNJ7LYvZxH6asU7 2N8WMV5D6ThE8aUiEFGns5j1YE= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; s=default; bh=LA7pxVkquTK+1lH9QAkdtGn ZF68=; b=XTbyjaF2jlr1im2LqYFHh4O/KphIbaHcL9gTGsmQ0rHp/SUKbagJCn1 yqhBd+UaLbaay7Eny+hwNsx8dPFdScsDOB62YKE7SAff7aIf/DLOEP3tlOPoVoU5 T3UApVO17VXJKnXFGKWY6g4U3nVxHWvhGXMfUctbSY5DEKiXjMiw= Received: (qmail 26346 invoked by alias); 15 May 2015 08:29:02 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 26329 invoked by uid 89); 15 May 2015 08:29:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL, BAYES_00, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 15 May 2015 08:29:00 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D677729; Fri, 15 May 2015 01:28:19 -0700 (PDT) Received: from collaborate-mta1.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTP id DB8CD3F447; Fri, 15 May 2015 01:28:58 -0700 (PDT) Received: from [10.2.206.27] (e105545-lin.cambridge.arm.com [10.2.206.27]) by collaborate-mta1.arm.com (Postfix) with ESMTPS id 1A64513F6C9; Fri, 15 May 2015 03:28:57 -0500 (CDT) Message-ID: <5555AE49.3030301@arm.com> Date: Fri, 15 May 2015 09:28:57 +0100 From: Ramana Radhakrishnan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Kugan , "gcc-patches@gcc.gnu.org" , Richard Earnshaw CC: Kyrylo Tkachov Subject: Re: [ARM] fix arm bootstrap References: <55559525.5000603@linaro.org> In-Reply-To: <55559525.5000603@linaro.org> On 15/05/15 07:41, Kugan wrote: > Hi Richard, > > r223090 seem to miss a parenthesis and seem to be causing: > > from ../../widen/gcc/fold-const.c:46: > ../../widen/gcc/fold-const.c: In function 'tree_node* > fold_range_test(location_t, tree_code, tree, tree, tree)': > ../../widen/gcc/config/arm/arm.h:2068:4: error: enumeral and > non-enumeral type in conditional expression [-Werror=extra] > ? (TARGET_THUMB ? false : true) \ > ^ Looks like a missing cast - A cast appears to let me continue with the build (fold-const.o builds without any warnings). Will apply it if the bootstrap finishes ok with an appropriate changelog. regards Ramana * config/arm/arm.h (LOGICAL_OP_SHORT_CIRCUIT): Add static casts. > ../../widen/gcc/fold-const.c:5234:12: note: in expansion of macro > 'LOGICAL_OP_NON_SHORT_CIRCUIT' > else if (LOGICAL_OP_NON_SHORT_CIRCUIT > ^ > ../../widen/gcc/fold-const.c: In function 'tree_node* > fold_truth_andor(location_t, tree_code, tree, tree, tree, tree, tree)': > ../../widen/gcc/config/arm/arm.h:2068:4: error: enumeral and > non-enumeral type in conditional expression [-Werror=extra] > ? (TARGET_THUMB ? false : true) \ > ^ > ../../widen/gcc/fold-const.c:8431:7: note: in expansion of macro > 'LOGICAL_OP_NON_SHORT_CIRCUIT' > if (LOGICAL_OP_NON_SHORT_CIRCUIT > > > Regression testing for arm-none-linux-gnueab is ongoing. > Is this OK for trunk if no regression? > > Thanks, > Kugan > > gcc/ChangeLog: > > 2015-05-15 Kugan Vivekanandarajah > > * config/arm/arm.h (enum arm_auto_incmodes): Add parenthesis. > diff --git a/gcc/config/arm/arm.h b/gcc/config/arm/arm.h index 8574388..a58a7b1 100644 --- a/gcc/config/arm/arm.h +++ b/gcc/config/arm/arm.h @@ -2060,8 +2060,8 @@ enum arm_auto_incmodes #define LOGICAL_OP_NON_SHORT_CIRCUIT \ ((optimize_size) \ ? (TARGET_THUMB ? false : true) \ - : TARGET_THUMB ? current_tune->logical_op_non_short_circuit_thumb \ - : current_tune->logical_op_non_short_circuit_arm) + : TARGET_THUMB ? static_cast (current_tune->logical_op_non_short_circuit_thumb) \ + : static_cast (current_tune->logical_op_non_short_circuit_arm)) /* Position Independent Code. */