From patchwork Mon May 11 09:13:55 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Bruel X-Patchwork-Id: 470672 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 286691400A0 for ; Mon, 11 May 2015 19:14:14 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=oW3ucv1t; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:subject:references :in-reply-to:content-type; q=dns; s=default; b=DJpL3uN/CRAwnm531 0+qbUAM5+GNdlBFK/bZ0PETNaxDUztPWFnJDcv+WGQR+//0Lgho/TJgbxr0ptEYy 1Q1/pMi+JxUVtfaAPFNOVk7qFOo6b85dw3QsKMu786RIPPDWwVFi/5dPNEsoZ+Gv CADMJ1sFnTmLnNWdCZO9Rouc0k= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:subject:references :in-reply-to:content-type; s=default; bh=hYwGkAW1wnvAagGudE45T/C pjxY=; b=oW3ucv1tn4fhxCG/pkQxJPyXyLnjqTjEITBJ6VNnU9j47wRvt52CmOc L0v1XjXSIkuMSm2PQlo5CRG3+qhrlWIv1ISA56aPXZo0s9Vr+QkQrHOPx3k6Rjvw s47x/q83b6BYTEFuxE+WqhgDkrcHfYhAwhR9YYeWbr7ZbqiLSBCM= Received: (qmail 126063 invoked by alias); 11 May 2015 09:14:07 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 126051 invoked by uid 89); 11 May 2015 09:14:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.2 required=5.0 tests=AWL, BAYES_50, KAM_ASCII_DIVIDERS, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: mx07-00178001.pphosted.com Received: from mx07-00178001.pphosted.com (HELO mx07-00178001.pphosted.com) (62.209.51.94) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 11 May 2015 09:14:05 +0000 Received: from pps.filterd (m0046668.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.14.5/8.14.5) with SMTP id t4B94hEk006061; Mon, 11 May 2015 11:14:00 +0200 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 1u914f2wkj-1 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 11 May 2015 11:13:59 +0200 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id D2A0738; Mon, 11 May 2015 09:13:56 +0000 (GMT) Received: from Webmail-eu.st.com (safex1hubcas3.st.com [10.75.90.18]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id BB318291D; Mon, 11 May 2015 09:13:56 +0000 (GMT) Received: from [164.129.122.197] (164.129.122.197) by webmail-eu.st.com (10.75.90.13) with Microsoft SMTP Server (TLS) id 8.3.342.0; Mon, 11 May 2015 11:13:56 +0200 Message-ID: <555072D3.8070207@st.com> Date: Mon, 11 May 2015 11:13:55 +0200 From: Christian Bruel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Ramana Radhakrishnan , "gcc-patches@gcc.gnu.org" , Richard Earnshaw , "nickc@redhat.com" Subject: Re: [PATCH, ARM] attribute target (thumb,arm) [1/6] respin (4th) References: <554A22DE.3040800@st.com> <554B22BB.7080904@arm.com> In-Reply-To: <554B22BB.7080904@arm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151, 1.0.33, 0.0.0000 definitions=2015-05-11_01:2015-05-09, 2015-05-10, 1970-01-01 signatures=0 X-IsSubscribed: yes > > > OK with those changes. > > > > Ramana > thanks, done following up the thumb_code cleanup, here is a missing chunk for the vxworks config. arm-vxworks build checked. ok for trunk ? thanks, Christian 2015-05-11 Christian Bruel * config/arm/arm-protos.h (thumb_code, thumb1_code): Remove. * config/arm/vxworks.h (thumb_code): Replace with TARGET_THUMB. Index: gcc/config/arm/arm-protos.h =================================================================== --- gcc/config/arm/arm-protos.h (revision 222997) +++ gcc/config/arm/arm-protos.h (working copy) @@ -462,12 +462,6 @@ /* Nonzero if tuning for Cortex-A9. */ extern int arm_tune_cortex_a9; -/* Nonzero if generating Thumb instructions. */ -extern int thumb_code; - -/* Nonzero if generating Thumb-1 instructions. */ -extern int thumb1_code; - /* Nonzero if we should define __THUMB_INTERWORK__ in the preprocessor. XXX This is a bit of a hack, it's intended to help work around Index: gcc/config/arm/vxworks.h =================================================================== --- gcc/config/arm/vxworks.h (revision 222997) +++ gcc/config/arm/vxworks.h (working copy) @@ -40,7 +40,7 @@ builtin_define ("CPU=ARMARCH5"); \ else if (arm_arch4) \ { \ - if (thumb_code) \ + if (TARGET_THUMB) \ builtin_define ("CPU=ARMARCH4_T"); \ else \ builtin_define ("CPU=ARMARCH4"); \