diff mbox

[1/3] optabs.c: Make vector_compare_rtx cope with VOIDmode constants (e.g. const0_rtx)

Message ID 554397F2.80901@arm.com
State New
Headers show

Commit Message

Alan Lawrence May 1, 2015, 3:12 p.m. UTC 
Alan Lawrence wrote:
> As per introduction, this allows vector_compare_rtx to work on DImode vectors.
> 
> Bootstrapped + check-gcc on x86-unknown-linux-gnu.
> 
> gcc/ChangeLog:
> 
> 	* optabs.c (vector_compare_rtx): Handle RTL operands having VOIDmode.
> 

Ping. (DImode vectors are explicitly allowed by stor-layout.c.)

Comments

Jeff Law May 1, 2015, 4:32 p.m. UTC | #1 
On 05/01/2015 09:12 AM, Alan Lawrence wrote:
> Alan Lawrence wrote:
>> As per introduction, this allows vector_compare_rtx to work on DImode
>> vectors.
>>
>> Bootstrapped + check-gcc on x86-unknown-linux-gnu.
>>
>> gcc/ChangeLog:
>>
>>     * optabs.c (vector_compare_rtx): Handle RTL operands having VOIDmode.
>>
>
> Ping. (DImode vectors are explicitly allowed by stor-layout.c.)
Patch is fine.  If you have a testcase where this patch improves code, 
can you please add it to the testsuite.

Thanks,
Jeff
diff mbox

Patch

diff --git a/gcc/optabs.c b/gcc/optabs.c
index f8d584eeeb11a2c19d8c8d887a0ff18aed5f56b4..135c88938f8bc03eed4dc7f1b5adcb0bb0606b1e 100644
--- a/gcc/optabs.c
+++ b/gcc/optabs.c
@@ -6530,18 +6530,28 @@  vector_compare_rtx (enum tree_code tcode, tree t_op0, tree t_op1,
 {
   struct expand_operand ops[2];
   rtx rtx_op0, rtx_op1;
+  machine_mode m0, m1;
   enum rtx_code rcode = get_rtx_code (tcode, unsignedp);
 
   gcc_assert (TREE_CODE_CLASS (tcode) == tcc_comparison);
 
-  /* Expand operands.  */
+  /* Expand operands.  For vector types with scalar modes, e.g. where int64x1_t
+     has mode DImode, this can produce a constant RTX of mode VOIDmode; in such
+     cases, use the original mode.  */
   rtx_op0 = expand_expr (t_op0, NULL_RTX, TYPE_MODE (TREE_TYPE (t_op0)),
 			 EXPAND_STACK_PARM);
+  m0 = GET_MODE (rtx_op0);
+  if (m0 == VOIDmode)
+    m0 = TYPE_MODE (TREE_TYPE (t_op0));
+
   rtx_op1 = expand_expr (t_op1, NULL_RTX, TYPE_MODE (TREE_TYPE (t_op1)),
 			 EXPAND_STACK_PARM);
+  m1 = GET_MODE (rtx_op1);
+  if (m1 == VOIDmode)
+    m1 = TYPE_MODE (TREE_TYPE (t_op1));
 
-  create_input_operand (&ops[0], rtx_op0, GET_MODE (rtx_op0));
-  create_input_operand (&ops[1], rtx_op1, GET_MODE (rtx_op1));
+  create_input_operand (&ops[0], rtx_op0, m0);
+  create_input_operand (&ops[1], rtx_op1, m1);
   if (!maybe_legitimize_operands (icode, 4, 2, ops))
     gcc_unreachable ();
   return gen_rtx_fmt_ee (rcode, VOIDmode, ops[0].value, ops[1].value);