diff mbox

[AArch64] Do not overwrite cost in bswap case

Message ID 55433884.4030800@arm.com
State New
Headers show

Commit Message

Kyrylo Tkachov May 1, 2015, 8:25 a.m. UTC 
Hi all,

This patch is trivial. We already initialise the cost to COSTS_N_INSNS (1) at the top of the function.
No need to overwrite it again. Just add the cost of a rev and recurse into the operands.

Bootstrapped and tested on aarch64-linux.

Ok for trunk?

Thanks,
Kyrill

2015-05-01  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

     * config/aarch64/aarch64.c (aarch64_rtx_costs): Do not overwrite cost
     with COSTS_N_INSNS (1).

Comments

Marcus Shawcroft May 1, 2015, 8:42 a.m. UTC | #1 
On 1 May 2015 at 09:25, Kyrill Tkachov <kyrylo.tkachov@arm.com> wrote:

> 2015-05-01  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
>
>     * config/aarch64/aarch64.c (aarch64_rtx_costs): Do not overwrite cost
>     with COSTS_N_INSNS (1).

OK /Marcus
diff mbox

Patch

commit 30857e8a8ff816244c49b3c76b6044c1d5cc9f2f
Author: Kyrylo Tkachov <kyrylo.tkachov@arm.com>
Date:   Tue Mar 3 10:10:53 2015 +0000

    [AArch64] Do not overwrite BSWAP rtx cost, let recursion handle the operand

diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c
index 6083fd4..e19b592 100644
--- a/gcc/config/aarch64/aarch64.c
+++ b/gcc/config/aarch64/aarch64.c
@@ -5995,7 +5995,6 @@  cost_plus:
       }
 
     case BSWAP:
-      *cost = COSTS_N_INSNS (1);
 
       if (speed)
         *cost += extra_cost->alu.rev;