From patchwork Thu Mar 12 08:11:33 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 449409 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3A70A1400F1 for ; Thu, 12 Mar 2015 23:15:55 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass reason="1024-bit key; unprotected key" header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=Z3xj8MOa; dkim-adsp=none (unprotected policy); dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:subject:references :in-reply-to:content-type; q=dns; s=default; b=xPCY2aShnWLAZHZTE YmR/FnQGU+OFt9frI6laNFoKgtPk9fqY7M48fIgTxEdXc36lwKBxodSnKTSs3Zp5 b3eMoguPtaQBrawPRnZcryySxvBH8Kp6V4oSDA6q4pXimvm2Gh8RKCMRF/93y/Bq sVI7ajCLlJkyJWrUymqA0Qoi84= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:subject:references :in-reply-to:content-type; s=default; bh=uhkv9Y7+0wgSNwrFfUyFoBB esN8=; b=Z3xj8MOa4DUzQDFfbg0HCn2TEQ/uFybNmMWdwgWIiXloMM18g+BgzIq jORfseXGgfFjBzwvXJDBSc7b17bUt7CVgxQ188aQCQLdF6aEbCG//IspI2ksLylL 2v4nnRzpJN2Ebnp7Wq8ASTA8nNTvd29SZTqDAOiSuKAssd5DMInc= Received: (qmail 1558 invoked by alias); 12 Mar 2015 12:15:44 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 1460 invoked by uid 89); 12 Mar 2015 12:15:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.2 required=5.0 tests=AWL, BAYES_00, SPF_SOFTFAIL, UNWANTED_LANGUAGE_BODY autolearn=no version=3.3.2 X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 12 Mar 2015 12:15:38 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVyIJ-0005md-FR for gcc-patches@gcc.gnu.org; Thu, 12 Mar 2015 04:16:44 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:47209) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVyIJ-0005mN-7x for gcc-patches@gcc.gnu.org; Thu, 12 Mar 2015 04:16:39 -0400 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-03.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1YVyDR-0003mh-EG from Tom_deVries@mentor.com ; Thu, 12 Mar 2015 01:11:37 -0700 Received: from [127.0.0.1] (137.202.0.76) by SVR-IES-FEM-03.mgc.mentorg.com (137.202.0.108) with Microsoft SMTP Server id 14.3.224.2; Thu, 12 Mar 2015 08:11:35 +0000 Message-ID: <55014A35.6050804@mentor.com> Date: Thu, 12 Mar 2015 09:11:33 +0100 From: Tom de Vries User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Uros Bizjak , "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH, i386 testsuite]: Require nonpic target for some tests References: In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Windows NT kernel [generic] [fuzzy] X-Received-From: 192.94.38.131 On 30-01-15 20:49, Uros Bizjak wrote: > Hello! > > Attached patch adds nonpic target requirement for some (obvious) > cases, where data access or PIC register setup confuses scan-asms. > > 2015-01-30 Uros Bizjak > > * gcc.target/i386/fuse-caller-save-rec.c: Require nonpic target. > * gcc.target/i386/fuse-caller-save-xmm.c: Ditto. > * gcc.target/i386/fuse-caller-save.c: Ditto. Hi, I've reverted this part of the patch. The scans were failing because the -fipa-ra optimization was broken for -m32 -fpic (PR64895). Thanks, - Tom 2015-03-12 Tom de Vries PR rtl-optimization/64895 * gcc.target/i386/fuse-caller-save-rec.c: Revert require nonpic target. * gcc.target/i386/fuse-caller-save-xmm.c: Ditto. * gcc.target/i386/fuse-caller-save.c: Ditto. diff --git a/gcc/testsuite/gcc.target/i386/fuse-caller-save-rec.c b/gcc/testsuite/gcc.target/i386/fuse-caller-save-rec.c index ed0984c..c660e01 100644 --- a/gcc/testsuite/gcc.target/i386/fuse-caller-save-rec.c +++ b/gcc/testsuite/gcc.target/i386/fuse-caller-save-rec.c @@ -1,5 +1,4 @@ /* { dg-do compile } */ -/* { dg-require-effective-target nonpic } */ /* { dg-options "-O2 -fipa-ra -fomit-frame-pointer -fno-optimize-sibling-calls" } */ /* { dg-additional-options "-mregparm=1" { target ia32 } } */ diff --git a/gcc/testsuite/gcc.target/i386/fuse-caller-save-xmm.c b/gcc/testsuite/gcc.target/i386/fuse-caller-save-xmm.c index 261ba07..1d02844 100644 --- a/gcc/testsuite/gcc.target/i386/fuse-caller-save-xmm.c +++ b/gcc/testsuite/gcc.target/i386/fuse-caller-save-xmm.c @@ -1,5 +1,4 @@ /* { dg-do compile } */ -/* { dg-require-effective-target nonpic } */ /* { dg-options "-O2 -msse2 -mno-avx -fipa-ra -fomit-frame-pointer" } */ typedef double v2df __attribute__((vector_size (16))); diff --git a/gcc/testsuite/gcc.target/i386/fuse-caller-save.c b/gcc/testsuite/gcc.target/i386/fuse-caller-save.c index b9494ac..7cfd22a 100644 --- a/gcc/testsuite/gcc.target/i386/fuse-caller-save.c +++ b/gcc/testsuite/gcc.target/i386/fuse-caller-save.c @@ -1,5 +1,4 @@ /* { dg-do compile } */ -/* { dg-require-effective-target nonpic } */ /* { dg-options "-O2 -fipa-ra -fomit-frame-pointer" } */ /* { dg-additional-options "-mregparm=1" { target ia32 } } */ -- 1.9.1