From patchwork Wed Mar 4 20:22:02 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Sebor X-Patchwork-Id: 446416 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DC8F14007D for ; Thu, 5 Mar 2015 07:22:16 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass reason="1024-bit key; unprotected key" header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=s7Pgtc1K; dkim-adsp=none (unprotected policy); dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; q=dns; s= default; b=BbZ8Dz7S4poIpc944ItQ+kpwgFato6vCJEuNstbyQ6RUMWFA9oPkZ xQbeDLLHKXwaa/hy2Vv9a3yT4JriuYd+Ayma5v4JdaD0aEw/7r9I7BDJKGc4mt7g rsPgYNZCwiWbEEOJM2m24vhBTomNoGGGASC7uAAbo8Z64Q9HG0sR88= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; s=default; bh=OxXl3aqSkvXwzXciK6J7Ckw0f4M=; b=s7Pgtc1K+5jmRMjy0hKTHDVWCo83 Ok95YKXT+3kylXPUn6l63AUPnRurFWq4IiXeVq1h8jMtRC+EwdO1TqfA5iW4pNPO V0RZun3rbtoLHWicr9nkk9AIW7aa89hV5I1jMbySmzF2E2aj5gEn5PrlVlzQqMIn bqBqpYoF5cs3F08= Received: (qmail 5814 invoked by alias); 4 Mar 2015 20:22:08 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 5805 invoked by uid 89); 4 Mar 2015 20:22:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL, BAYES_00, SPF_HELO_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 04 Mar 2015 20:22:07 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t24KM4pW032588 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 4 Mar 2015 15:22:05 -0500 Received: from [10.10.59.126] (vpn-59-126.rdu2.redhat.com [10.10.59.126]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t24KM3m4026771; Wed, 4 Mar 2015 15:22:03 -0500 Message-ID: <54F7696A.3040307@redhat.com> Date: Wed, 04 Mar 2015 13:22:02 -0700 From: Martin Sebor User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Andreas Schwab CC: Jeff Law , Gcc Patch List Subject: Re: [PATCH] target/65286 - Disable multilib for ppc64le References: <54F658DB.6030200@redhat.com> <54F73089.8040308@redhat.com> <54F73594.6000601@redhat.com> <87a8zsy95u.fsf@igel.home> In-Reply-To: <87a8zsy95u.fsf@igel.home> X-IsSubscribed: yes On 03/04/2015 10:17 AM, Andreas Schwab wrote: > Martin Sebor writes: > >> The configure script explicitly adds --enable-multilib unless >> --disable-multilib is specified. This then results in libraries >> being built with the -m32 option, which fails with errors like >> the one below: >> >> /usr/include/gnu/stubs.h:8:27: fatal error: gnu/stubs-32.h: No such file >> or directory > > So fix the multilib configuration. Makes sense. Does the patch below look closer to what you're suggesting? GCC built and installed correctly with it, although it still accepts the -m32 option which causes build failures. Perhaps the option should be disabled for this target (if so, I assume that would be a separate issue and patch.) Martin +MULTILIB_EXTRA_OPTS := rs6000-linux.o: $(srcdir)/config/rs6000/rs6000-linux.c $(COMPILE) $< diff --git a/ChangeLog b/ChangeLog index bd43281..6c20c4b 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2015-03-04 Martin Sebor + + PR target/65286 + * gcc/config/rs6000/t-linux64: Disable 32-bit configuration + for the powerpc64le target. + 2015-03-13 Jeff Law * MAINTAINERS: Remove Paul Brook as a Fortran and ARM diff --git a/gcc/config/rs6000/t-linux64 b/gcc/config/rs6000/t-linux64 index b6b351d..a336b31 100644 --- a/gcc/config/rs6000/t-linux64 +++ b/gcc/config/rs6000/t-linux64 @@ -25,11 +25,18 @@ # it doesn't tell anything about the 32bit libraries on those systems. Set # MULTILIB_OSDIRNAMES according to what is found on the target. +MULTILIB_OSDIRNAMES := m64=../lib64$(call if_multiarch,:powerpc64-linux-gnu) + +ifeq ($(findstring 64le,$(target)),) MULTILIB_OPTIONS := m64/m32 MULTILIB_DIRNAMES := 64 32 -MULTILIB_EXTRA_OPTS := -MULTILIB_OSDIRNAMES := m64=../lib64$(call if_multiarch,:powerpc64-linux-gnu) MULTILIB_OSDIRNAMES += m32=$(if $(wildcard $(shell echo $(SYSTEM_HEADER_DIR))/. +else +MULTILIB_OPTIONS := m64 +MULTILIB_DIRNAMES := 64 +endif +