From patchwork Thu Jan 29 18:16:17 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthias Klose X-Patchwork-Id: 434617 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 21AD414029C for ; Fri, 30 Jan 2015 05:23:22 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; q=dns; s= default; b=JqBx/Jphw9VrgWBcWZ2LApOjATSP9VJoOka2ZY4cM4YiUbH3NB68V ovjGk3ORT543cniUmP9OSKSBmyVm9YZlRAddMWmlvBomd9e47Db5TBe553+WfYTR V21JVv0T4T1FiQemqZGzqG4Lvx18YzHoY2ZIRV+NrmNmJv976ZANxU= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; s=default; bh=xMfyI6JCST0l1xn56+tzY0+PZuE=; b=Zry5WUP/0tuu5JTD4oWCZaffnQRi xvQyVEjFiH/0uoABuPCuIgX8Xrwb//bdGRKM11aEcPgpdj1qlY4NmMyqvg19o/Fs CVYlqDDay/azQKoOmvgNxPwQibS1U5yhPcmGNvntxPpB1ETAb17Dgbq1nOMQ8oTu VyzeRJvib8UI3WU= Received: (qmail 17663 invoked by alias); 29 Jan 2015 18:16:38 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 17576 invoked by uid 89); 29 Jan 2015 18:16:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: einhorn.in-berlin.de Received: from einhorn.in-berlin.de (HELO einhorn.in-berlin.de) (192.109.42.8) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 29 Jan 2015 18:16:29 +0000 X-Envelope-From: doko@ubuntu.com Received: from [192.168.42.218] (dslb-088-073-070-238.088.073.pools.vodafone-ip.de [88.73.70.238]) (authenticated bits=0) by einhorn.in-berlin.de (8.14.4/8.14.4/Debian-4) with ESMTP id t0TIGO0Z017368 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Thu, 29 Jan 2015 19:16:25 +0100 Message-ID: <54CA78F1.1020204@ubuntu.com> Date: Thu, 29 Jan 2015 19:16:17 +0100 From: Matthias Klose User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: "H.J. Lu" CC: Caroline Tice , Patrick Wollgast , Kai Tietz , Benjamin De Kosnik , "jwakely@redhat.com >> Jonathan Wakely" , gcc-patches , "libstdc++@gcc.gnu.org" Subject: Re: [Ping] Port of VTV for Cygwin and MinGW References: <53FF0C8C.8090507@rub.de> <54369316.7070001@rub.de> <543F9BB8.1040503@rub.de> <54524B43.7000105@rub.de> <5463893D.50807@rub.de> <54639CC5.4050508@rub.de> <5476F20C.5010801@rub.de> <548876B5.70306@rub.de> <54A99E34.2010202@rub.de> <54AEE9B0.3010407@rub.de> <54B6D159.4000002@rub.de> <54B77230.6070704@rub.de> <54B83638.7080509@rub.de> <54C8C89C.1000104@rub.de> <54CA737A.5060102@ubuntu.com> <54CA767F.9040102@ubuntu.com> In-Reply-To: On 01/29/2015 07:12 PM, H.J. Lu wrote: > On Thu, Jan 29, 2015 at 10:05 AM, Matthias Klose wrote: >> that fixes the build failure. ok to commit? >> >> 2015-01-29 Matthias Klose >> >> * acinclude.m4 (GLIBCXX_ENABLE_VTABLE_VERIFY): Define VTV_CYGMIN >> unconditionally. >> * configure: Regenerate. >> > > This is wrong. You are checking vtv_cygmin before it is defined. my bad, somebody should obviously build both variants ... now testing this variant. Index: acinclude.m4 =================================================================== --- acinclude.m4 (revision 220257) +++ acinclude.m4 (working copy) @@ -2320,8 +2320,6 @@ AC_MSG_CHECKING([for vtable verify support]) AC_MSG_RESULT([$enable_vtable_verify]) - AM_CONDITIONAL(VTV_CYGMIN, test $vtv_cygmin = yes) - if test $enable_vtable_verify = yes; then case ${target_os} in cygwin*|mingw32*) @@ -2341,6 +2339,8 @@ VTV_CXXLINKFLAGS= fi + AM_CONDITIONAL(VTV_CYGMIN, test $vtv_cygmin = yes) + AC_SUBST(VTV_CXXFLAGS) AC_SUBST(VTV_PCH_CXXFLAGS) AC_SUBST(VTV_CXXLINKFLAGS)