Message ID | 547491DC.3020302@mentor.com |
---|---|
State | New |
Headers | show |
On Tue, Nov 25, 2014 at 03:27:40PM +0100, Tom de Vries wrote: > This patch fixes that by ensuring that we print that unsupported message only once. > > The resulting test result comparison diff is: > 2014-11-25 Tom de Vries <tom@codesourcery.com> > > * testsuite/libstdc++-prettyprinters/prettyprinters.exp: Add missing > dg-finish. Only print unsupported message once. LGTM. > --- a/libstdc++-v3/testsuite/libstdc++-prettyprinters/prettyprinters.exp > +++ b/libstdc++-v3/testsuite/libstdc++-prettyprinters/prettyprinters.exp > @@ -30,7 +30,14 @@ if ![info exists ::env(GUALITY_GDB_NAME)] { > } > > if {! [gdb_version_check]} { > + dg-finish > + # Only print unsupported message in one instance. > + if ![gcc_parallel_test_run_p prettyprinters] { > + return > + } > + gcc_parallel_test_enable 0 > unsupported "prettyprinters.exp" > + gcc_parallel_test_enable 1 > return > } > > -- > 1.9.1 > Jakub
On Nov 25, 2014, at 12:15 PM, Jakub Jelinek <jakub@redhat.com> wrote: > On Tue, Nov 25, 2014 at 03:27:40PM +0100, Tom de Vries wrote: >> This patch fixes that by ensuring that we print that unsupported message only once. >> >> The resulting test result comparison diff is: >> 2014-11-25 Tom de Vries <tom@codesourcery.com> >> >> * testsuite/libstdc++-prettyprinters/prettyprinters.exp: Add missing >> dg-finish. Only print unsupported message once. > > LGTM. That is the approval. :-)
2014-11-25 Tom de Vries <tom@codesourcery.com> * testsuite/libstdc++-prettyprinters/prettyprinters.exp: Add missing dg-finish. Only print unsupported message once. --- libstdc++-v3/testsuite/libstdc++-prettyprinters/prettyprinters.exp | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/libstdc++-v3/testsuite/libstdc++-prettyprinters/prettyprinters.exp b/libstdc++-v3/testsuite/libstdc++-prettyprinters/prettyprinters.exp index a57660f..e5be5b5 100644 --- a/libstdc++-v3/testsuite/libstdc++-prettyprinters/prettyprinters.exp +++ b/libstdc++-v3/testsuite/libstdc++-prettyprinters/prettyprinters.exp @@ -30,7 +30,14 @@ if ![info exists ::env(GUALITY_GDB_NAME)] { } if {! [gdb_version_check]} { + dg-finish + # Only print unsupported message in one instance. + if ![gcc_parallel_test_run_p prettyprinters] { + return + } + gcc_parallel_test_enable 0 unsupported "prettyprinters.exp" + gcc_parallel_test_enable 1 return } -- 1.9.1