From patchwork Tue Nov 4 22:35:26 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pat Haugen X-Patchwork-Id: 406829 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id DA4C11400A0 for ; Wed, 5 Nov 2014 09:35:47 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; q=dns; s= default; b=emGkF2JxNJlkVJAKFTSYexGDO/09Vf+OT5sqxzPi7gvbIzGTj0S3f 2fuA8h0bZyopTZEUffisDn60FdIr0uRN2qtZvwrmYp2+mrqgVmUJtpFuDjnw6YfU SL/hXPMs3/STxofiP7IJtu4MJtGC4EDGet/t0eBcI/9CGiSS0rr7YE= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; s=default; bh=uhpbQx8ZWGINwx9PgJGgGI9N4uQ=; b=Mi1RpVp6G7+FCV1A4HaTZ0Sgb+gl KboaMHRHaurkjtM5WxzmooT0U6AO7vZk2zB3uKCZ//pRWCYmQDLOWmielAzEQnhA YJm8UemoWZUqV5JmPdBEc182d1IBdTqAgVZNDBLAykgxauK+HfEAGrqXqEYe7gZL ZEzK2eC+cBLx4d4= Received: (qmail 2959 invoked by alias); 4 Nov 2014 22:35:36 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 2848 invoked by uid 89); 4 Nov 2014 22:35:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: e39.co.us.ibm.com Received: from e39.co.us.ibm.com (HELO e39.co.us.ibm.com) (32.97.110.160) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 04 Nov 2014 22:35:34 +0000 Received: from /spool/local by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 4 Nov 2014 15:35:32 -0700 Received: from d01dlp01.pok.ibm.com (9.56.250.166) by e39.co.us.ibm.com (192.168.1.139) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 4 Nov 2014 15:35:30 -0700 Received: from b01cxnp22033.gho.pok.ibm.com (b01cxnp22033.gho.pok.ibm.com [9.57.198.23]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id B0DEB38C8039 for ; Tue, 4 Nov 2014 17:35:40 -0500 (EST) Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by b01cxnp22033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id sA4MZTVA24969222 for ; Tue, 4 Nov 2014 22:35:29 GMT Received: from d01av04.pok.ibm.com (localhost [127.0.0.1]) by d01av04.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id sA4MZRp3004309 for ; Tue, 4 Nov 2014 17:35:28 -0500 Received: from pthw510.ibm.com ([9.50.17.103]) by d01av04.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id sA4MZQBX004234; Tue, 4 Nov 2014 17:35:26 -0500 Message-ID: <545954AE.6070209@linux.vnet.ibm.com> Date: Tue, 04 Nov 2014 16:35:26 -0600 From: Pat Haugen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.8.0 MIME-Version: 1.0 To: "Joseph S. Myers" , gcc-patches@gcc.gnu.org CC: dje.gcc@gmail.com Subject: Re: Implement TARGET_ATOMIC_ASSIGN_EXPAND_FENV for powerpc*-*-linux* soft-float and e500 References: In-Reply-To: X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14110422-0033-0000-0000-0000029265FD X-IsSubscribed: yes On 11/01/2014 07:20 AM, Joseph S. Myers wrote: > This patch implements support for TARGET_ATOMIC_ASSIGN_EXPAND_FENV for > powerpc*-*-linux* soft-float and e500, provided GCC is configured for > glibc 2.19 or later on the target. The patch causes a bootstrap error on targets with glibc < 2.19 for defined but unused variables. The following fixes that and was committed as obvious. -Pat 2014-11-04 Pat Haugen * config/rs6000/rs6000.c (atomic_hold_decl, atomic_clear_decl, atomic_update_decl): Guard declaration with #ifdef. Index: gcc/config/rs6000/rs6000.c =================================================================== --- gcc/config/rs6000/rs6000.c (revision 217101) +++ gcc/config/rs6000/rs6000.c (working copy) @@ -34590,8 +34590,10 @@ make_pass_analyze_swaps (gcc::context *c return new pass_analyze_swaps (ctxt); } +#ifdef RS6000_GLIBC_ATOMIC_FENV /* Function declarations for rs6000_atomic_assign_expand_fenv. */ static tree atomic_hold_decl, atomic_clear_decl, atomic_update_decl; +#endif /* Implement TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook. */