From patchwork Thu Sep 18 22:36:29 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthias Klose X-Patchwork-Id: 390992 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 20BD01400EA for ; Fri, 19 Sep 2014 08:36:47 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; q=dns; s=default; b=SsTpJqJD5EGIlEyZH K6mqNKw3dwuL3vBwmFOlBSq55G5XiSUWJXQFBfn0lkbJtZ23isAkimeWuD1FXNtK Z6SVi697t01GPlzld7YbRxH00xik/nZ+pPXNqiIiPfHyXFI+gSf8/tcpkcZpIvQP HfWiUjXCaWbe+mgmhWO4vql3rE= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; s=default; bh=d6mdy4sd429lDKX5mTEle7f qhuY=; b=DeRk9Ccv4DgV+Hr/bpcE8vVxycC2zbXl+oGzLFgpRNpOURyZz9wOS7x NdZyBgM1a71iL7TLZvqrwbZU+TxFPS6f5OrEDXxqJ2w0JWaE/q2yHk9uQOJJgp+u 3E9heRLgEmy2oY9NkQvHnhp2gGXuEtm/NTXEI4t/UbNv7RNWQjCs= Received: (qmail 31828 invoked by alias); 18 Sep 2014 22:36:41 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 31819 invoked by uid 89); 18 Sep 2014 22:36:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.2 X-HELO: youngberry.canonical.com Received: from youngberry.canonical.com (HELO youngberry.canonical.com) (91.189.89.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 18 Sep 2014 22:36:39 +0000 Received: from 70-35-38-154.static.wiline.com ([70.35.38.154] helo=[10.253.11.141]) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1XUkJV-0006Lu-4X; Thu, 18 Sep 2014 22:36:33 +0000 Message-ID: <541B5E6D.4010301@ubuntu.com> Date: Fri, 19 Sep 2014 00:36:29 +0200 From: Matthias Klose User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: James Greenhalgh , Andrew Pinski CC: Venkataramanan Kumar , Marcus Shawcroft , "gcc-patches@gcc.gnu.org" , Patch Tracking , Richard Earnshaw , steve.mcintyre@linaro.org Subject: Re: [PATCH v2 AArch64]: Re: [PATCH AArch64]: Add constraint letter for stack_protect_test pattern. References: <20140904081855.GA18028@arm.com> <20140916220344.GA31613@arm.com> <54198936.5030106@ubuntu.com> In-Reply-To: <54198936.5030106@ubuntu.com> Am 17.09.2014 um 15:14 schrieb Matthias Klose: > Am 17.09.2014 um 00:03 schrieb James Greenhalgh: >> If you have any other suggestions, or if "=&r" is actually correct and >> I am misreading the documentation please let me know. > > with this patch I see a lot of ICEs in the testsuite for test cases built with > -O3 (and a build defaulting to -fstack-protector-strong by default), all of the > form: I tested with the wrong patch. No regression, and fixing the original issue with the attached patch. Tested with the trunk and the Linaro 4.9 branch, Matthias --- gcc/config/aarch64/aarch64.md +++ gcc/config/aarch64/aarch64.md @@ -4031,7 +4031,7 @@ (unspec:PTR [(match_operand:PTR 1 "memory_operand" "m") (match_operand:PTR 2 "memory_operand" "m")] UNSPEC_SP_TEST)) - (clobber (match_scratch:PTR 3 "&r"))] + (clobber (match_scratch:PTR 3 "=&r"))] "" "ldr\t%3, %x1\;ldr\t%0, %x2\;eor\t%0, %3, %0" [(set_attr "length" "12")