Message ID | 5419AABF.3000006@oracle.com |
---|---|
State | New |
Headers | show |
OK. Jason
Hi Paolo, On Wed, 17 Sep 2014, Paolo Carlini wrote: > clang recently, in 3.5.0 if I remember correctly, stopped -Wnon-virtual-dtor > warning for final classes. I think it makes sense to do the same. mind adding a note to wwwdocs/htdocs/gcc-5/changes.html ? Thanks, Gerald
Hi, On 09/19/2014 08:03 AM, Gerald Pfeifer wrote: > Hi Paolo, > > On Wed, 17 Sep 2014, Paolo Carlini wrote: >> clang recently, in 3.5.0 if I remember correctly, stopped -Wnon-virtual-dtor >> warning for final classes. I think it makes sense to do the same. > mind adding a note to wwwdocs/htdocs/gcc-5/changes.html ? Sure, I will! Paolo.
Index: cp/class.c =================================================================== --- cp/class.c (revision 215325) +++ cp/class.c (working copy) @@ -6506,7 +6506,8 @@ finish_struct_1 (tree t) /* This warning does not make sense for Java classes, since they cannot have destructors. */ if (!TYPE_FOR_JAVA (t) && warn_nonvdtor - && TYPE_POLYMORPHIC_P (t) && accessible_nvdtor_p (t)) + && TYPE_POLYMORPHIC_P (t) && accessible_nvdtor_p (t) + && !CLASSTYPE_FINAL (t)) warning (OPT_Wnon_virtual_dtor, "%q#T has virtual functions and accessible" " non-virtual destructor", t); Index: testsuite/g++.dg/cpp0x/Wdtor1.C =================================================================== --- testsuite/g++.dg/cpp0x/Wdtor1.C (revision 0) +++ testsuite/g++.dg/cpp0x/Wdtor1.C (working copy) @@ -0,0 +1,13 @@ +// PR c++/62232 +// { dg-do compile { target c++11 } } +// { dg-options "-Wnon-virtual-dtor" } + +class base +{ +protected: + ~base () {} + virtual void foo (){}; +}; +class derive final : public base +{ +};