From patchwork Wed Sep 3 13:15:23 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nathan Sidwell X-Patchwork-Id: 385518 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 5118C140275 for ; Wed, 3 Sep 2014 23:16:36 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; q=dns; s=default; b=VuiHWHr/5JJIFWIDO oaOqS6nfoREtPCxic3DTHv4JOjfMGIZAnECJmSfTwo+vIboxACUtIIP0lw67wScG UBOgpAr/vXozIDEoQVIL4rTxS++O6wCdFOrIhr7ntYUV7w+3cIC5ZGzBiXaINjro 0QOLpOGkXqLol9jhJGztauBunE= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; s=default; bh=jKuU9j3MwhMmz/8QMWNX6PR BZgc=; b=tPgMGxhrVbEv0RNBXYJGYKkhIF6ayCmrvtMUYXjtohpkXc2WaKGnI49 O1QFu8LC1AjkCJO5jrxhB2KQ8d03vUNM8UJIHrNUshzdnLBfOfosgbvX4oBqx5g1 M05yar5IHo/F/4F0Ok8RPCEOG+PpShkdjtYAbO1NURXR4ViJUrfY= Received: (qmail 5978 invoked by alias); 3 Sep 2014 13:15:37 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 5955 invoked by uid 89); 3 Sep 2014 13:15:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-qg0-f43.google.com Received: from mail-qg0-f43.google.com (HELO mail-qg0-f43.google.com) (209.85.192.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 03 Sep 2014 13:15:35 +0000 Received: by mail-qg0-f43.google.com with SMTP id f51so8089127qge.2 for ; Wed, 03 Sep 2014 06:15:33 -0700 (PDT) X-Received: by 10.140.41.101 with SMTP id y92mr61961634qgy.69.1409750130727; Wed, 03 Sep 2014 06:15:30 -0700 (PDT) Received: from ?IPv6:2601:6:8380:343:a2a8:cdff:fe3e:b48? ([2601:6:8380:343:a2a8:cdff:fe3e:b48]) by mx.google.com with ESMTPSA id h9sm16828074qaf.38.2014.09.03.06.15.27 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 03 Sep 2014 06:15:29 -0700 (PDT) Message-ID: <5407146B.9080903@acm.org> Date: Wed, 03 Sep 2014 09:15:23 -0400 From: Nathan Sidwell User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: Dominique Dhumieres , gcc-patches@gcc.gnu.org CC: hubicka@ucw.cz, iains@gcc.gnu.org Subject: Re: fix gfcov regression References: <20140903080651.BA876FF@mailhost.lps.ens.fr> In-Reply-To: <20140903080651.BA876FF@mailhost.lps.ens.fr> X-IsSubscribed: yes On 09/03/14 04:06, Dominique Dhumieres wrote: >> I've committed the patch now. > > It (r214840) breaks bootstrap on darwin: does this fix it? nathan 2014-09-03 Nathan sidwell * libgcov-interface.c (STRONG_ALIAS): Rename to ... (ALIAS): ... here. Make weak. Adjust uses. Index: libgcc/libgcov-interface.c =================================================================== --- libgcc/libgcov-interface.c (revision 214840) +++ libgcc/libgcov-interface.c (working copy) @@ -42,11 +42,11 @@ void __gcov_dump (void) {} #else - /* Some functions we want to bind in this dynamic object, but have an - overridable global alias. */ -#define STRONG_ALIAS(src,dst) \ - extern __typeof (src) dst __attribute__((alias (#src))) + overridable global alias. Weak aliases are supported in more + places than non-weak, and is adequate for our needs. */ +#define ALIAS(src,dst) \ + extern __typeof (src) dst __attribute__((weak, alias (#src))) extern __gthread_mutex_t __gcov_flush_mx ATTRIBUTE_HIDDEN; extern __gthread_mutex_t __gcov_flush_mx ATTRIBUTE_HIDDEN; @@ -133,7 +133,7 @@ __gcov_reset_int (void) __gcov_root.dumped = 0; } -STRONG_ALIAS (__gcov_reset_int, __gcov_reset); +ALIAS (__gcov_reset_int, __gcov_reset); #endif /* L_gcov_reset */