From patchwork Fri Aug 8 08:05:06 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kyrylo Tkachov X-Patchwork-Id: 378112 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4F75F140114 for ; Fri, 8 Aug 2014 18:05:22 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:subject:references :in-reply-to:content-type; q=dns; s=default; b=KzpF2qUUfAoY1TBrG k3vVpbVHtRE8NgwjYK4lQfQVMak9SeC8yf23RfPODa+MvYh8kaa1WtR2wciWNZwo KW7oKt3AI3cA4klvbRscKS+f+zsse3C4Rpk1HGyWnffB0fQFFYWm1ri6uupZ39aB BKhdmrGp97tktm7iAIrQZQxNS0= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:subject:references :in-reply-to:content-type; s=default; bh=5Mf3lJ6p4JplvkGe3K7YKHP hl0I=; b=MDGNuGrWHQ0RC1E5LBbtN0qmsj+nxIzdV08x/bTWZfouYb5Poe4p5vt /uIG6nkxcyMqHr3UFnsU+7AM3Uluovd1Tup82Yqvc00LWmNKQcB0m6/zTmLg8qhT TbWORnMUOsG7B/VNygpTeTZUZQsg1f2A1b8vojXM/nMhtGHd3Qv8= Received: (qmail 2321 invoked by alias); 8 Aug 2014 08:05:15 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 2309 invoked by uid 89); 8 Aug 2014 08:05:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL, BAYES_00, SPF_PASS autolearn=ham version=3.3.2 X-HELO: service87.mimecast.com Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 08 Aug 2014 08:05:12 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Fri, 08 Aug 2014 09:05:09 +0100 Received: from [10.1.208.24] ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Fri, 8 Aug 2014 09:05:07 +0100 Message-ID: <53E484B2.10309@arm.com> Date: Fri, 08 Aug 2014 09:05:06 +0100 From: Kyrill Tkachov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Bin Cheng , "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH testcase]Skip test pr61772.c for lto tests References: <000a01cfb224$0ebb81d0$2c328570$@arm.com> In-Reply-To: <000a01cfb224$0ebb81d0$2c328570$@arm.com> X-MC-Unique: 114080809050903001 X-IsSubscribed: yes On 07/08/14 10:43, Bin Cheng wrote: > Hi, > Case pr61772.c scans specific string in assembly file, and it is run for > many different option combinations. When it's tested against different lto > option combinations on targets like ARM, the generated pr61772.s may only > contain lto object content, rather than assembly codes. The scanning check > is failed in these cases. > I think disabling lto won't weaken the test since what it tests has nothing > to do with lto. This patch fixes these failures by disabling lto. > > Is it OK? Hi Bin, Do you think it would be better to just add -ffat-lto-objects instead? That way the output would contain the assembly as well. Example patch attached. We might want check that LTO doesn't optimise the assembly away? Kyrill > Thanks, > bin > > gcc/testsuite/ChangeLog > 2014-08-07 Bin Cheng > > * gcc.dg/torture/pr61772.c: Skip lto running. diff --git a/gcc/testsuite/gcc.dg/torture/pr61772.c b/gcc/testsuite/gcc.dg/torture/pr61772.c index da4c93e..aa60c14 100644 --- a/gcc/testsuite/gcc.dg/torture/pr61772.c +++ b/gcc/testsuite/gcc.dg/torture/pr61772.c @@ -1,4 +1,5 @@ /* { dg-do compile } */ +/* { dg-options "-ffat-lto-objects" } */ /* { dg-final { scan-assembler-times "XXX" 2 } } */ static inline __attribute__((always_inline)) int dec_and_test (int *i)