From patchwork Mon Jul 21 11:33:54 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 372039 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id A87AB140087 for ; Mon, 21 Jul 2014 21:34:16 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; q=dns; s=default; b=S1EpSg/gin+6w1wim B0yEnN9NOeUCwQw8MBJ97dzC4xZuB5Mcn0x27/dnGQs2ra0xBDcSGhgcAcBy++F+ LqGXUdB/ls+5ZOqkCij5RfcyTMZKlo8XucaSueB90IGwB0IctcRpThaeWzsIN0ba yUImUSJ5065QvYGChzuaklPfZI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; s=default; bh=6TTwNyz+2VMHGZR2d0voZbu t15E=; b=WkNYnZyjk3UK/hiVvdbAlDlZdLgFBgqWEg8roIpqMrLMvysxLFJp7ep raJQcGdWFzeyXsKtuA7A7sh9pl3tWfgdphn00Bf+Uy/fLPNH3FANaxjEilvihcUm V7V8ARgqX6JybPlpO1wROc1l+6TL8GPg1Yl7D6goe7y+8Lk+K5OQ= Received: (qmail 19355 invoked by alias); 21 Jul 2014 11:34:08 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 19337 invoked by uid 89); 21 Jul 2014 11:34:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.7 required=5.0 tests=AWL, BAYES_00, KAM_STOCKTIP autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 21 Jul 2014 11:34:05 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1X9Bqz-00043q-5M from Tom_deVries@mentor.com ; Mon, 21 Jul 2014 04:34:01 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 21 Jul 2014 04:34:01 -0700 Received: from [127.0.0.1] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.2.247.3; Mon, 21 Jul 2014 12:33:56 +0100 Message-ID: <53CCFAA2.2010709@mentor.com> Date: Mon, 21 Jul 2014 13:33:54 +0200 From: Tom de Vries User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Uros Bizjak CC: GCC Patches , Dominique Dhumieres Subject: Re: [PATCH, i386, PR61827] Fix fuse-caller-save-xmm.c test-case References: <53CB9931.6030800@mentor.com> <53CCECA7.9070607@mentor.com> In-Reply-To: On 21-07-14 12:40, Uros Bizjak wrote: > On Mon, Jul 21, 2014 at 12:34 PM, Tom de Vries wrote: > >> Dominique noticed that the .LC0 check failed on darwin, since the label LC0 >> is used. This follow-up patch fixes that (and I see now you already Ok-ed >> this change). >> >> Furthermore, I've realized from the comments in the PR that for >> solaris/sun-as and darwin no cfi directives are generated. There are two >> other i386 fuse-caller-save tests which test cfi directives. The reason >> these tests aren't failing for solaris/sun-as and darwin like the >> fuse-caller-save-xmm test did, is because they test for the absence of >> specific cfi directives, which will always pass if no cfi directives are >> generated. So I've removed the cfi directive checks (and removed superfluous >> mains) and added tests on instructions. >> >> >> Tested with -m32 and -m64. >> >> OK for trunk? > > This is OK. > Dominique noticed a symbol matching problem on darwin for fuse-caller-save-rec.c. I've committed this followup patch that fixes that problem. Thanks, - Tom 2014-07-21 Tom de Vries PR target/61827 * gcc.target/i386/fuse-caller-save-rec.c: Allow underscore prefix to bar symbol in scan-assembler-times call check. diff --git a/gcc/testsuite/gcc.target/i386/fuse-caller-save-rec.c b/gcc/testsuite/gcc.target/i386/fuse-caller-save-rec.c index d1441bc..a0fcf9c 100644 --- a/gcc/testsuite/gcc.target/i386/fuse-caller-save-rec.c +++ b/gcc/testsuite/gcc.target/i386/fuse-caller-save-rec.c @@ -26,5 +26,4 @@ foo (int y) /* { dg-final { scan-assembler-times "addl\t%\[re\]?dx, %\[re\]?ax" 1 } } */ /* Verify that bar is self-recursive. */ -/* { dg-final { scan-assembler-times "call\tbar" 2 } } */ - +/* { dg-final { scan-assembler-times "call\t_?bar" 2 } } */