From patchwork Sat Jul 12 22:40:22 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kugan Vivekanandarajah X-Patchwork-Id: 369372 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 7EF1B1400B5 for ; Sun, 13 Jul 2014 08:40:42 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; q=dns; s=default; b=Z5sJMa7KrnRTWqxEc lI8aLyQlo6UajsBih2ps6JYo6ZS506gA7PG6kgFzPvPqwdw2z0Y93EwZLWazReLk xe4XIFRW+yoO66ZClP+CLAktCpkH/JYb9VOGR5vFcNVoF53abJaWCqyS1Rqv9rRn MuVKcOe6PQlEF51vbNRqfVC6iU= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; s=default; bh=6gX6DhoFbFCFEAPILxHKzjN iSw8=; b=Mb6r+TqMz3Eb7BQFU2dbG3slDu2HiVe3jzQe/N+bUUI1f3/OFs9YHxY j6SM5FvsX09kX/IetucljaQSwhHjiEEX6uitMSj7T8Pc3l13X0xm7kJg/lrsWWfw OuQh2dCH1BI9sP40Kf1H6BBCDQPp3w04wyqukGZX3Y5WFlCEo4YY= Received: (qmail 31493 invoked by alias); 12 Jul 2014 22:40:32 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 31478 invoked by uid 89); 12 Jul 2014 22:40:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f49.google.com Received: from mail-pa0-f49.google.com (HELO mail-pa0-f49.google.com) (209.85.220.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 12 Jul 2014 22:40:30 +0000 Received: by mail-pa0-f49.google.com with SMTP id lj1so3305940pab.8 for ; Sat, 12 Jul 2014 15:40:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type; bh=9Q5zxVALNcw8OBRt4PURNGQNP/S6C0LAlC4ok4b79Tg=; b=abEwSSrQu4tdZpwzIG92eQ5uxJo2J++KcN8M/mjpe5avuoLUnnUwGM8S6VUAaNYTCT t34ThFmAi0eGKGVXOQF2oFkNQuZccoG9rWfQIb8Hl7TVrZGceD6ns86Upp3/Alb59oU1 GKzjj4YAhGqlbJVe4aJAeuTNDy4tfb10J/grStDSmjQjIBSbWlDZCI2YCJLPoxr03l1d jkqgurIqofUxeA4OaNY3CLhFd4MvVLZqraq5ttHJDKxzV7/g4LEZCkF/vafWhUu3F9SQ aQlJppMbL78u8oTXpMP5QNpTbZSBj0b+IK95DwVj6LgpU6fz87WElQ2yicBVZbVr5vTq QTCw== X-Gm-Message-State: ALoCoQl810sGQUjbZSva7tXX0d3iEnXcw1HUgPm01LrsxqULOYEda/2JljATPyvpxG+ba6cg9fVx X-Received: by 10.70.90.207 with SMTP id by15mr7359802pdb.31.1405204827525; Sat, 12 Jul 2014 15:40:27 -0700 (PDT) Received: from [10.1.1.4] (58-6-183-210.dyn.iinet.net.au. [58.6.183.210]) by mx.google.com with ESMTPSA id cr3sm8299696pdb.43.2014.07.12.15.40.25 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 12 Jul 2014 15:40:26 -0700 (PDT) Message-ID: <53C1B956.1050407@linaro.org> Date: Sun, 13 Jul 2014 08:40:22 +1000 From: Kugan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Ramana Radhakrishnan , "gcc-patches@gcc.gnu.org" CC: Richard Earnshaw , Jay Foad , Uros Bizjak Subject: Re: [RFC][ARM] TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook References: In-Reply-To: X-IsSubscribed: yes > > - if (!TARGET_VFP) > - return; > + if (!TARGET_VFP || TARGET_THUMB1) > + return default_atomic_assign_expand_fenv (hold, clear, update); > > You don't need to call default function here. It is empty, the > documentation says: > > "The default implementation leaves all three expressions as @code{NULL_TREE}." > > Also, the function is declared as void, so returning something looks > strange to me. Thanks for the comment. Here is a patch to change this. There was also a comment from Jay with respect to a cut and paste error that might confuse the readers. I am fixing that as well. regression tested on qemu for arm-none-linux-gnueabi with no new regressions. Please let me know if this is OK? Thanks, Kugan gcc/ 2014-057-12 Kugan Vivekanandarajah * config/arm/arm.c (bdesc_2arg): Fix typo. (arm_atomic_assign_expand_fenv): Remove The default implementation. diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c index 78cae73..b84594d 100644 --- a/gcc/config/arm/arm.c +++ b/gcc/config/arm/arm.c @@ -24366,8 +24366,8 @@ static const struct builtin_description bdesc_2arg[] = {0, CODE_FOR_##L, "__builtin_arm_"#L, ARM_BUILTIN_##U, \ UNKNOWN, 0}, - FP_BUILTIN (set_fpscr, GET_FPSCR) - FP_BUILTIN (get_fpscr, SET_FPSCR) + FP_BUILTIN (get_fpscr, GET_FPSCR) + FP_BUILTIN (set_fpscr, SET_FPSCR) #undef FP_BUILTIN #define CRC32_BUILTIN(L, U) \ @@ -31582,7 +31582,7 @@ arm_atomic_assign_expand_fenv (tree *hold, tree *clear, tree *update) tree update_call, atomic_feraiseexcept, hold_fnclex; if (!TARGET_VFP || !TARGET_HARD_FLOAT) - return default_atomic_assign_expand_fenv (hold, clear, update); + return; /* Generate the equivalent of : unsigned int fenv_var;