From patchwork Wed Jul 2 08:02:06 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 366283 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3F43C1400B5 for ; Wed, 2 Jul 2014 18:02:30 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; q=dns; s=default; b=LTkbx2vQfAjVWl3LH B28gy20M7RCDZ5SQ/z90II+h9ZRVfK5PUKs1LR2lwMe2OS0sLo3M9adAfBunO+Y0 WHV9k4jA1suQdPWgy1lybMMfwTYpwGtKOlRD6UedgbBaNRvmDPyzO3wACHk+DL9e QbrW/zbeZAW3ZJdcxrZ+xw0+SI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; s=default; bh=ea2R5gA6QvE/K+8zm9ohEYY YCe0=; b=mj2RxZBsOEoe4c31LVsWB838uXOuY1dx8gz21XHjchhJ8z8H6Nsb6B5 Ia6meaYkYDmu0w0gL7khWmk/+T19ZvTitVwdWmZaH2Fh+SSRUL0DFzYrKPcA6yjQ NVJaPWQrQglAFVjxQez2FFNFDpjd+b2rS2aj7izJDFVFzXzyKYqo= Received: (qmail 8654 invoked by alias); 2 Jul 2014 08:02:22 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 8557 invoked by uid 89); 2 Jul 2014 08:02:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL, BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 02 Jul 2014 08:02:20 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1X2FUd-00019q-70 from Tom_deVries@mentor.com ; Wed, 02 Jul 2014 01:02:15 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Wed, 2 Jul 2014 01:02:15 -0700 Received: from [127.0.0.1] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.2.247.3; Wed, 2 Jul 2014 09:02:12 +0100 Message-ID: <53B3BC7E.3040709@mentor.com> Date: Wed, 2 Jul 2014 10:02:06 +0200 From: Tom de Vries User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Marcus Shawcroft CC: GCC Patches , Marc Glisse , Richard Henderson Subject: Re: combination of read/write and earlyclobber constraint modifier References: <53B30B96.2000603@mentor.com> <53B31041.8060608@redhat.com> <53B32D3A.1030700@mentor.com> In-Reply-To: On 02-07-14 08:23, Marc Glisse wrote: > In the first example you gave, looking at the pattern (no match_dup, setting the > full register), it seems that it may have wanted "=&" instead of "+&". [ move discussion from gcc ml to gcc-patches ml ] Marcus, The +& constraint on operand 0 of vec_unpack_trunc_ seems wrong, since the template does not use the operand as input. This patch fixes that. OK for trunk if aarch64 build & regtest succeeds ? Thanks, - Tom 2014-07-02 Tom de Vries * config/aarch64/aarch64-simd.md (define_insn "vec_unpack_trunc_"): Fix constraint. diff --git a/gcc/config/aarch64/aarch64-simd.md b/gcc/config/aarch64/aarch64-simd.md index 1c32f0c..0377de4 100644 --- a/gcc/config/aarch64/aarch64-simd.md +++ b/gcc/config/aarch64/aarch64-simd.md @@ -1018,7 +1018,7 @@ ;; For quads. (define_insn "vec_pack_trunc_" - [(set (match_operand: 0 "register_operand" "+&w") + [(set (match_operand: 0 "register_operand" "=&w") (vec_concat: (truncate: (match_operand:VQN 1 "register_operand" "w")) (truncate: (match_operand:VQN 2 "register_operand" "w"))))] -- 1.9.1