From patchwork Thu Jun 5 07:52:51 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ramana Radhakrishnan X-Patchwork-Id: 356214 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id C829E14007F for ; Thu, 5 Jun 2014 17:53:04 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:subject:content-type; q= dns; s=default; b=hWZCv9PFFG2zCbEqpEAxRHqp9AIH3mGJ1LPGYuqEaCEd/h XQ2gxzzYmDjWsAPZxE4czpF6kqXGqKvZf7hcKgKOfdJPeAx2w7/k5q36IC/CuYFb E+CfGLYVRdszRlG9GJK/TocAPg0TQ30EHe2Y4yVxW+V2EhEblMFBa2doFfuTE= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:subject:content-type; s= default; bh=PmUAZpk0tl7oXQUU+z8spm4zjus=; b=p9oSlWBWK4axvMb8b/tH vZnseCkM7kc/i9niyAgHKZUbA3COOr72qvUAWaFTu6Nk2qyonb6jtz+lN+VPQOfC cjqNYHr952z4H2U5EdlY5hCdyeoGO4maGjRix6WpbHV1D6MKVLWwerJLKJJqthlW mgH8s1RfzFUPUGji0WI1rtA= Received: (qmail 806 invoked by alias); 5 Jun 2014 07:52:57 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 793 invoked by uid 89); 5 Jun 2014 07:52:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-HELO: collaborate-mta1.arm.com Received: from fw-tnat.austin.arm.com (HELO collaborate-mta1.arm.com) (217.140.110.23) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 05 Jun 2014 07:52:54 +0000 Received: from [10.1.209.147] (e104577-lin.cambridge.arm.com [10.1.209.147]) by collaborate-mta1.arm.com (Postfix) with ESMTPS id 83D7813F796 for ; Thu, 5 Jun 2014 02:52:52 -0500 (CDT) Message-ID: <539021D3.6090102@arm.com> Date: Thu, 05 Jun 2014 08:52:51 +0100 From: Ramana Radhakrishnan User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:14.0) Gecko/20120713 Thunderbird/14.0 MIME-Version: 1.0 To: "gcc-patches@gcc.gnu.org ;" Subject: [Patch ARM] Fix bootstrap issue with thumb state + neon. X-IsSubscribed: yes Hi, In certain configurations of our auto-testers bootstrap fails because the enabled attribute depends on "opt_enabled" which is driven by state that is not constant for a compilation unit. We probably need a hot/ cold alternative which may be useful per insn. For now, work around this till we know if we really need this attribute on these patterns and what the impact in reality is. Bootstrapped , tested and applied to trunk. Ramana * config/arm/arm.md (enabled): Disable opt_enabled. diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 2efa59f..484b0c0 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,7 @@ +2014-06-03 Ramana Radhakrishnan + + * config/arm/arm.md (enabled): Remove opt_enabled. + 2014-06-02 Ramana Radhakrishnan PR target/61154 diff --git a/gcc/config/arm/arm.md b/gcc/config/arm/arm.md index bec889a..f58a79b 100644 --- a/gcc/config/arm/arm.md +++ b/gcc/config/arm/arm.md @@ -201,6 +201,17 @@ (const_string "no"))) ; Enable all alternatives that are both arch_enabled and insn_enabled. +; FIXME:: opt_enabled has been temporarily removed till the time we have +; an attribute that allows the use of such alternatives. +; This depends on caching of speed_p, size_p on a per +; alternative basis. The problem is that the enabled attribute +; cannot depend on any state that is not cached or is not constant +; for a compilation unit. We probably need a generic "hot/cold" +; alternative which if implemented can help with this. We disable this +; until such a time as this is implemented and / or the improvements or +; regressions with removing this attribute are double checked. +; See ashldi3_neon and di3_neon in neon.md. + (define_attr "enabled" "no,yes" (cond [(and (eq_attr "predicable_short_it" "no") (and (eq_attr "predicated" "yes") @@ -216,9 +227,6 @@ (const_string "no") (eq_attr "arch_enabled" "no") - (const_string "no") - - (eq_attr "opt_enabled" "no") (const_string "no")] (const_string "yes")))