From patchwork Thu May 29 08:43:17 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 353702 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 9EC2F1400A3 for ; Thu, 29 May 2014 18:43:38 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; q=dns; s=default; b=E7xPitGhOutEI2i4h +Qd1bvbFr4FHbk9hWnOhEddgYvAJ9KRN+BLi3bx53lbQ5WA4Tz3WF437WHugyhN8 pQpWsu6kgQwZQJWwHv1BNnR58KXKColWuGE95zAEYU4wJmQONv6/T/LBZKLhXvDG n41n4jrCZBVW18v0jbSWuGMOBc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; s=default; bh=XVsQRdHMUDlLVdqBxiTCxGO MruU=; b=duGoDQ9chx5aNtGB7bf0q4eZDp8Ha6OBZ8WpsFUK9IrayEj47gPrYCN 0o+tPiXLAlG3P/jAfSmobmDXcL0/M8VwDKyK/hObJhNt6nVGyg/gPmRJ16IW2nkA SjDVCNqiAgWTF9GRV5Dhf/IoQvFOMbJyLzFof6ELtdXoeYAwnQuw= Received: (qmail 25229 invoked by alias); 29 May 2014 08:43:32 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 25219 invoked by uid 89); 29 May 2014 08:43:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL, BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 29 May 2014 08:43:30 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1Wpvvm-0002Mp-W5 from Tom_deVries@mentor.com ; Thu, 29 May 2014 01:43:23 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Thu, 29 May 2014 01:43:22 -0700 Received: from [127.0.0.1] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.2.247.3; Thu, 29 May 2014 09:43:20 +0100 Message-ID: <5386F325.1080604@mentor.com> Date: Thu, 29 May 2014 10:43:17 +0200 From: Tom de Vries User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Bill Schmidt CC: Eric Botcazou , , Jan Hubicka , Subject: Re: -fuse-caller-save - Collect register usage information References: <534ED7BC.50300@mentor.com> <878uqwgjoe.fsf@talisman.default> <535BABD1.8050208@mentor.com> <1426417.RtLpSRnsYv@polaris> <537A1583.7020702@mentor.com> <1401316944.796.29.camel@gnopaine> In-Reply-To: <1401316944.796.29.camel@gnopaine> On 29-05-14 00:42, Bill Schmidt wrote: > Tom, the final version of this patch that you committed breaks bootstrap > on powerpc64le-linux-gnu. The problem is that all uses of the variable > i are guarded by #ifdef STACK_REGS, but the declaration of i is > unconditional. We get an unused variable warning that becomes an error > during stage 3. > Bill, thanks for letting me know. I've bootstrapped attached patch on x86_64, and committed it. Thanks, - Tom 2014-05-29 Tom de Vries * final.c (collect_fn_hard_reg_usage): Guard variable declaration with #ifdef STACK_REGS. diff --git a/gcc/final.c b/gcc/final.c index a345fe7..c32e177 100644 --- a/gcc/final.c +++ b/gcc/final.c @@ -4750,7 +4750,9 @@ static void collect_fn_hard_reg_usage (void) { rtx insn; +#ifdef STACK_REGS int i; +#endif struct cgraph_rtl_info *node; /* ??? To be removed when all the ports have been fixed. */