From patchwork Wed Apr 23 20:57:21 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 341991 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3843B14011D for ; Thu, 24 Apr 2014 06:57:39 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:content-type; q=dns; s=default; b=fmWApvZJR6xw+6rHe2JDNuA8UslN9VLNTHvOLz8wfX2 k7+ML0475ov1HKuQSOpwKJtJ3XYmrDUeUMUHVSAlNYcnIkHLK1g+Zjrib2MnMuyk 5MuaFvR15pgJphsu+5tU1gfWvDvw6hn2hCWqh1P7y0z09V2cwrO1jwt6VLA4y3PI = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:content-type; s=default; bh=OxfNEuGu+/vIiFge2NLdbEBYI44=; b=FTb49uxpd/xK3fcwD eo3LFvkAyp3zYTI9p6NUUX/AQry61/RCelM32AfE/bzQGoKu8OSpNK3TtXR1VoY9 +LahT2/NOSbYG0iFGrmiyADcOyMKtp1/FI2RFb3tMe2ipXwG2Reg7y0gX6XYEROF zNaZsV1WH964rfbXIfUn0goH5s= Received: (qmail 28198 invoked by alias); 23 Apr 2014 20:57:32 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 28188 invoked by uid 89); 23 Apr 2014 20:57:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL, BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 23 Apr 2014 20:57:31 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1Wd4EP-0006mx-Uf from Tom_deVries@mentor.com ; Wed, 23 Apr 2014 13:57:25 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Wed, 23 Apr 2014 13:57:25 -0700 Received: from [127.0.0.1] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.2.247.3; Wed, 23 Apr 2014 21:57:23 +0100 Message-ID: <53582931.5@mentor.com> Date: Wed, 23 Apr 2014 22:57:21 +0200 From: Tom de Vries User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Joern Rennecke CC: GCC Patches Subject: Fix DEFHOOKPOD argument order in target-hooks-macros.h comment Joern, target-hooks-macros.h shows an argument order of DOC, TYPE, NAME, INIT for DEFHOOKPOD in a comment: ... DEFHOOKPOD(DOC, TYPE, NAME, INIT): Define a piece-of-data 'hook'. ... But the first DEFHOOKPOD that I see in target.def: ... DEFHOOKPOD (atomic_test_and_set_trueval, "This value should be set if the result written by\ @code{atomic_test_and_set} is not exactly 1, i.e. the\ @code{bool} @code{true}.", unsigned char, 1) ... seems to have the order NAME, DOC, TYPE, INIT. target.def is the only file to include target-hooks-macros.h, but other defines of DEFHOOKPOD in target.h: ... #define DEFHOOKPOD(NAME, DOC, TYPE, INIT) TYPE NAME; ... and genhooks.c: ... #define DEFHOOKPOD(NAME, DOC, TYPE, INIT) \ ... use the the same order. I'd say that confirms that the argument order for DEFHOOKPOD in the comment in target-hooks-macros.h is wrong. This patch fixes that. I'll commit shortly, as obvious. Thanks, - Tom 2014-04-23 Tom de Vries * target-hooks-macros.h: Fix DEFHOOKPOD argument order in comment. diff --git a/gcc/target-hooks-macros.h b/gcc/target-hooks-macros.h index 5cf4cb1..901f824 100644 --- a/gcc/target-hooks-macros.h +++ b/gcc/target-hooks-macros.h @@ -18,7 +18,7 @@ /* The following macros should be provided by the including file: DEFHOOK(NAME, DOC, TYPE, PARAMS, INIT): Define a function-valued hook. - DEFHOOKPOD(DOC, TYPE, NAME, INIT): Define a piece-of-data 'hook'. */ + DEFHOOKPOD(NAME, DOC, TYPE, INIT): Define a piece-of-data 'hook'. */ /* Defaults for optional macros: DEFHOOKPODX(NAME, TYPE, INIT): Like DEFHOOKPOD, but share documentation