From patchwork Fri Feb 21 04:24:25 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kugan Vivekanandarajah X-Patchwork-Id: 322409 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id D61512C0341 for ; Fri, 21 Feb 2014 15:24:43 +1100 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:content-type; q=dns; s=default; b=tKKlkDVAd8Jv1XFTDo1vqFx97rvg0+YDZcxLjhHKjfz SE4hM1LcsusNGYJoFcj85r8h9LNl16ksjr1b6FUM2rrbNL2AXH1G1i9npcuRdxI0 Um4nu67a/CaOXAQ0bt3qGgmeOOSR/QazPUlrk079Pf0LlOiM8/jX6aCfzDsBMMIQ = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:content-type; s=default; bh=kqjFwfT0BPh70zodNIUC2s8awBc=; b=q7Ps1UKveA2zI1Utv 5FE8FAI6EnBA2GFVCWpQgTgsiLH0mbdNvkVhtgoB6cpEJt3Uc/HHEBu6he8943ZX SosN7ncSrGcIK9KWO79GaJYMUaC/meZFliIIJYAzthWj3InVsrM62LI7fdkhjRvx /42qvgNsAbve3CZQBT/vNAcJbY= Received: (qmail 11933 invoked by alias); 21 Feb 2014 04:24:35 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 11920 invoked by uid 89); 21 Feb 2014 04:24:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL, BAYES_00, KAM_STOCKGEN, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=no version=3.3.2 X-HELO: mail-pb0-f48.google.com Received: from mail-pb0-f48.google.com (HELO mail-pb0-f48.google.com) (209.85.160.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 21 Feb 2014 04:24:33 +0000 Received: by mail-pb0-f48.google.com with SMTP id rr13so2872130pbb.21 for ; Thu, 20 Feb 2014 20:24:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:content-type; bh=fl1jLyKR+TrzHoTP77hYV1giZEeXs/rDBpzb5obr0Ws=; b=fOKaI3b4HvuB5x5UCBrty/aGTYG6fEVqKqMWpk26J73biaQiRSIhZYGGuQGv1lejTe B9YzFGe8kuwcPQpN56DQ66Lgpf2e2lU9xdakFwKI5vqxhvk8/ToUowhcEt3yh4Nv+NsX 71ZmfWdIQZwEsx8ofEv5j7kPx7d5qL6a4wNFEbM3GHXNKFLRv9MruOhsJobywM3wtuKJ BPiHijnB+0CWIEX20PNqwD4LGFk2HoD1CdpB9B/Gf0A8u0+guIi8uF8IwEnsX6wuKJ9k +FTNXUl5aERiYjwF346iZtAAYCBe4XbWEPYxOBygCGZeyYvzOuCFy1bqUSLBKMSj+P1u 0D+g== X-Gm-Message-State: ALoCoQn+qZ+lO0yqAkF5XRiaq3qGPEZuLETpP1b8a2yR0/1i3Dt/xmNK6KDQspeOaJHsh3q/8QKG X-Received: by 10.66.251.42 with SMTP id zh10mr6709681pac.84.1392956671402; Thu, 20 Feb 2014 20:24:31 -0800 (PST) Received: from [192.168.1.100] (pa49-187-68-83.pa.nsw.optusnet.com.au. [49.187.68.83]) by mx.google.com with ESMTPSA id y9sm39963395pas.10.2014.02.20.20.24.27 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 20 Feb 2014 20:24:30 -0800 (PST) Message-ID: <5306D4F9.6040901@linaro.org> Date: Fri, 21 Feb 2014 15:24:25 +1100 From: Kugan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: "gcc-patches@gcc.gnu.org" CC: Marcus Shawcroft , Richard Earnshaw Subject: [PATCH][AARCH64]PR60034 X-IsSubscribed: yes Hi all, Compiling inline asm results in ICE (PR60034). Alignment calculation in aarch64_classify_address for (symbol_ref:DI ("*.LANCHOR4") [flags 0x182])) seems wrong here. Fixing this also caused a regression for pr38151.c, which is due to complex type being allocated with wrong alignment. Attached patch fixes these issues. Regression tested on qemu-aarch64 for aarch64-none-linux-gnu with no new regressions. Is this patch OK? Thanks, Kugan gcc/ +2014-02-21 Kugan Vivekanandarajah + + PR target/60034 + * aarch64/aarch64.c (aarch64_classify_address): Fix alignment for + SYMBOL_REF_FLAGS. + * aarch64/aarch64.h (DATA_ALIGNMENT): Fix alignment for COMPLEX_TYPE. + gcc/testsuite/ +2014-02-21 Kugan Vivekanandarajah + + PR target/60034 + * gcc.target/aarch64/pr60034.c: New file. + diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c index ea90311..89187c0 100644 --- a/gcc/config/aarch64/aarch64.c +++ b/gcc/config/aarch64/aarch64.c @@ -3203,6 +3203,8 @@ aarch64_classify_address (struct aarch64_address_info *info, } else if (SYMBOL_REF_DECL (sym)) align = DECL_ALIGN (SYMBOL_REF_DECL (sym)); + else if (SYMBOL_REF_FLAGS (sym)) + align = GET_MODE_ALIGNMENT (GET_MODE (sym)); else align = BITS_PER_UNIT; diff --git a/gcc/config/aarch64/aarch64.h b/gcc/config/aarch64/aarch64.h index 13c424c..b93e9da 100644 --- a/gcc/config/aarch64/aarch64.h +++ b/gcc/config/aarch64/aarch64.h @@ -132,6 +132,7 @@ ((((ALIGN) < BITS_PER_WORD) \ && (TREE_CODE (EXP) == ARRAY_TYPE \ || TREE_CODE (EXP) == UNION_TYPE \ + || TREE_CODE (EXP) == COMPLEX_TYPE \ || TREE_CODE (EXP) == RECORD_TYPE)) \ ? BITS_PER_WORD : (ALIGN)) diff --git a/gcc/testsuite/gcc.target/aarch64/pr60034.c b/gcc/testsuite/gcc.target/aarch64/pr60034.c index e69de29..99c821d 100644 --- a/gcc/testsuite/gcc.target/aarch64/pr60034.c +++ b/gcc/testsuite/gcc.target/aarch64/pr60034.c @@ -0,0 +1,10 @@ +/* { dg-do compile } */ +/* { dg-options "-std=gnu99 -fgnu89-inline -O -Wall -Winline -Wwrite-strings -fmerge-all-constants -frounding-math -g -Wstrict-prototypes" } */ + +static unsigned long global_max_fast; + +int __libc_mallopt (int param_number, int value) +{ + __asm__ __volatile__ ("# %[_SDT_A21]" :: [_SDT_A21] "nr" ((global_max_fast))); + global_max_fast = 1; +}