From patchwork Fri Jan 17 22:20:32 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Law X-Patchwork-Id: 312210 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id C42AB2C009E for ; Sat, 18 Jan 2014 09:20:45 +1100 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; q=dns; s=default; b=fLxeaY3BSqwW5E2HV SeGpZ1vZ73aqXljbWoVwDJtcNkaWJBVRHaVnEZmrQJCkArUmUUF/WLrpqovMczLG amm2/hLYSJHICYG4BKFQbue6nyGkefMZtVpCaAo2LW53J51vMneQ4e1tiqNg4oVn 5j/45kFtXVy2geg5D79RYg6m2Y= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; s=default; bh=8O7LRseU3V5WabbgHISLoZj gosE=; b=Q9PEJE/loq3gkZcuMRLcHSbs6hUDoFzduQv0HIcLRXjbNv7v4fk4nbD MLzrjiDn7rwCb89ESZA9Qy0HHtGV6cEC7Ah3o5vlw9u02FVScIEL3uVkCIpP3kbR Kumuw5xY3txwkp8Hwo4zajJ7LHlTZHeJyz0qsjuB7zFoFXtjBXcA= Received: (qmail 26609 invoked by alias); 17 Jan 2014 22:20:37 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 26599 invoked by uid 89); 17 Jan 2014 22:20:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 17 Jan 2014 22:20:36 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0HMKXrZ001009 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 17 Jan 2014 17:20:34 -0500 Received: from stumpy.slc.redhat.com (ovpn-113-120.phx2.redhat.com [10.3.113.120]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s0HMKXXD007952; Fri, 17 Jan 2014 17:20:33 -0500 Message-ID: <52D9ACB0.1020506@redhat.com> Date: Fri, 17 Jan 2014 15:20:32 -0700 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Jakub Jelinek CC: Eric Botcazou , gcc-patches@gcc.gnu.org Subject: Re: [RFA] [PATCH][PR tree-optimization/59749] Fix recently introduced ree bug References: <52D067EF.7020005@redhat.com> <20140110215227.GJ892@tucnak.redhat.com> <52D38607.4090700@redhat.com> <1664880.Zr9CfWiqlj@polaris> <52D84F9D.8050503@redhat.com> <20140116220741.GY892@tucnak.redhat.com> <52D9A5CA.8050005@redhat.com> In-Reply-To: <52D9A5CA.8050005@redhat.com> X-IsSubscribed: yes On 01/17/14 14:51, Jeff Law wrote: > > Anyway, I clearly need to rethink that test. Given this is something we > haven't seen in the wild, I'm going to disable it over the > weekend/monday so that enable-checking bugs pass and continue to ponder. And the patch which disables the test. > > jeff > > commit 78f81be0894b38090cd6280f1e303610434d75c5 Author: Jeff Law Date: Thu Jan 16 14:23:15 2014 -0700 * ree.c (combine_set_extension): Temporarily disable test for changing number of hard registers. diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 37023c8..fabe408 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2014-01-17 Jeff Law + + * ree.c (combine_set_extension): Temporarily disable test for + changing number of hard registers. + 2014-01-17 Jan Hubicka PR middle-end/58125 diff --git a/gcc/ree.c b/gcc/ree.c index 19d821c..421eb6c 100644 --- a/gcc/ree.c +++ b/gcc/ree.c @@ -297,11 +297,15 @@ combine_set_extension (ext_cand *cand, rtx curr_insn, rtx *orig_set) else new_reg = gen_rtx_REG (cand->mode, REGNO (SET_DEST (*orig_set))); +#if 0 + /* Rethinking test. Temporarily disabled. */ /* We're going to be widening the result of DEF_INSN, ensure that doing so doesn't change the number of hard registers needed for the result. */ if (HARD_REGNO_NREGS (REGNO (new_reg), cand->mode) - != HARD_REGNO_NREGS (REGNO (orig_src), GET_MODE (SET_DEST (*orig_set)))) + != HARD_REGNO_NREGS (REGNO (SET_DEST (*orig_set)), + GET_MODE (SET_DEST (*orig_set)))) return false; +#endif /* Merge constants by directly moving the constant into the register under some conditions. Recall that RTL constants are sign-extended. */