From patchwork Wed Dec 4 21:59:26 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Law X-Patchwork-Id: 296637 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 790232C0089 for ; Thu, 5 Dec 2013 08:59:45 +1100 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:subject:content-type; q= dns; s=default; b=dG2Ra7m6uWJAGwUR+3nEYNyZMC8YZRPc4cQKAm2S1/WlAp vjNvPxRzghamZ2HcjbbV+sNqRT7Zju9Az37DTVYhHwT70UGCex+TLXA4UEWNwKQZ R+420U1frW1Zt0HEpCzBlD9SjDS7m733uthvR9Ld1cGxGHkC3+WXb7dTwmkrE= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:subject:content-type; s= default; bh=8JFw6Dsv7F4YX9i99r+O3RXqHGM=; b=YTUCEybHCfSogmnTGTUL pM1AT3FUiDHfELmpaPIkkxUEWUeoNXzuTW56CbsPYIr5M/hu8YgokSa0j9vC71PK omGwFkcUQNcD1D10XLYeMhdgUSQar1ofZ5D+9kMtjMngLyGSOd2bnTEoMbdQIJ8p 5ipGcMr0+jZGJmv7TQaTHrs= Received: (qmail 31319 invoked by alias); 4 Dec 2013 21:59:36 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 31309 invoked by uid 89); 4 Dec 2013 21:59:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.7 required=5.0 tests=AWL, BAYES_40, RDNS_NONE, SPF_HELO_PASS, SPF_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 04 Dec 2013 21:59:34 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rB4LxRPX008292 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 4 Dec 2013 16:59:27 -0500 Received: from stumpy.slc.redhat.com (ovpn-113-102.phx2.redhat.com [10.3.113.102]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rB4LxQcx013917 for ; Wed, 4 Dec 2013 16:59:27 -0500 Message-ID: <529FA5BE.9030008@redhat.com> Date: Wed, 04 Dec 2013 14:59:26 -0700 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: gcc-patches Subject: [PATCH] Fix out-of-date comments in expr.c X-IsSubscribed: yes Based on discussions with Bernd Edlinger.. These two comments were definitely in need to revision. Installed on the trunk. Jeff * expr.c (expand_assignment): Update comments. diff --git a/gcc/expr.c b/gcc/expr.c index 4e0e54f..2a13d8f 100644 --- a/gcc/expr.c +++ b/gcc/expr.c @@ -4869,8 +4869,8 @@ expand_assignment (tree to, tree from, bool nontemporal) if (GET_MODE (offset_rtx) != address_mode) offset_rtx = convert_to_mode (address_mode, offset_rtx, 0); - /* A constant address in TO_RTX can have VOIDmode, we must not try - to call force_reg for that case. Avoid that case. */ + /* The check for a constant address in TO_RTX not having VOIDmode + is probably no longer necessary. */ if (MEM_P (to_rtx) && GET_MODE (to_rtx) == BLKmode && GET_MODE (XEXP (to_rtx, 0)) != VOIDmode @@ -10062,8 +10062,8 @@ expand_expr_real_1 (tree exp, rtx target, enum machine_mode tmode, offset_rtx = convert_to_mode (address_mode, offset_rtx, 0); if (GET_MODE (op0) == BLKmode - /* A constant address in OP0 can have VOIDmode, we must - not try to call force_reg in that case. */ + /* The check for a constant address in OP0 not having VOIDmode + is probably no longer necessary. */ && GET_MODE (XEXP (op0, 0)) != VOIDmode && bitsize != 0 && (bitpos % bitsize) == 0