From patchwork Mon Nov 18 14:47:03 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kyrylo Tkachov X-Patchwork-Id: 292114 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id A826C2C00C2 for ; Tue, 19 Nov 2013 01:48:22 +1100 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; q=dns; s=default; b=PBj3T+ztyjtsvFmzE xvCmQvlsYzmzZQqx+gqjp4H+2QMOLYbl+16dpggF3weOZ3rFTqgq3Fsb0va/PYJa 8xpNFrR5DFYZhn9Foq9QF55Os+VGOof9kMSYg/IJgteHwzLDFY6vzVdxyohAi1Ln 9P/+WyJjhAC0fgoL6W+Gg3SS7g= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; s=default; bh=fRIaZrdgMCKUWcUkd3dm9p2 QaXM=; b=fFz9z/e3xqwcc2GHW1tKy5RIrkVzg9Aqm0uwh4sygQtztK4q8eSBLm0 CFMfBhb0HPXXUmQwTULZKNF0LNV07e8+KqQ8KsGxCA++LN0xPJp5NktDK3maRhBQ BtgYwpsbtqkGZmQBYe883oz14HtkEuJJLTQ53Gg23xAER3VJ/Qk8= Received: (qmail 15823 invoked by alias); 18 Nov 2013 14:48:13 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 15811 invoked by uid 89); 18 Nov 2013 14:48:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.0 required=5.0 tests=AWL, BAYES_50, RDNS_NONE, SPF_PASS, URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: service87.mimecast.com Received: from Unknown (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 18 Nov 2013 14:47:13 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Mon, 18 Nov 2013 14:47:04 +0000 Received: from [10.1.208.24] ([10.1.255.212]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Mon, 18 Nov 2013 14:47:03 +0000 Message-ID: <528A2867.7020003@arm.com> Date: Mon, 18 Nov 2013 14:47:03 +0000 From: Kyrill Tkachov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-Version: 1.0 To: Aldy Hernandez CC: Jakub Jelinek , Jason Merrill , gcc-patches , "Iyer, Balaji V" Subject: Re: PING: Fwd: Re: [patch] implement Cilk Plus simd loops on trunk References: <52618287.8010705@redhat.com> <52740D59.50104@redhat.com> <5284FF25.7020401@redhat.com> <20131114170553.GD27813@tucnak.zalov.cz> <52850AB6.2070408@redhat.com> <20131114180147.GE27813@tucnak.zalov.cz> <5285790E.9050000@redhat.com> <20131115073757.GA892@tucnak.redhat.com> <52863CB4.50900@redhat.com> <528695CD.5080705@redhat.com> <20131115214950.GS892@tucnak.redhat.com> <52869AB6.7070709@redhat.com> <5286C84D.2060905@redhat.com> In-Reply-To: <5286C84D.2060905@redhat.com> X-MC-Unique: 113111814470426301 X-IsSubscribed: yes On 16/11/13 01:20, Aldy Hernandez wrote: > On 11/15/13 15:05, Aldy Hernandez wrote: >>> Why all this, and not keep everything but >>> GF_OMP_FOR_KIND_SIMD and GF_OMP_FOR_KIND_DISTRIBUTE >>> as they were, and just use: >>> GF_OMP_FOR_KIND_DISTIRBUTE = 1 << 0, >>> GF_OMP_FOR_KIND_SIMD = 2 << 0, >>> GF_OMP_FOR_KIND_CILKSIMD = 3 << 0, >> Sounds good. Testing the following patch against my previous patch >> which had already been committed. >> >> If there are no regressions, I will commit. >> >> Aldy >> > Committed. Hi Aldy, The testcase c-c++-common/cilk-plus/PS/body.c needs an effective target check for fopenmp before adding -fopenmp to its options, otherwise it'll fail on bare-metal targets like arm-none-eabi. This patch adds that. Ok to commit? Thanks, Kyrill 2013-11-18 Kyrylo Tkachov * c-c++-common/cilk-plus/PS/body.c: Add fopenmp effective target check. diff --git a/gcc/testsuite/c-c++-common/cilk-plus/PS/body.c b/gcc/testsuite/c-c++-common/cilk-plus/PS/body.c index 9b10041..82c0a0c 100644 --- a/gcc/testsuite/c-c++-common/cilk-plus/PS/body.c +++ b/gcc/testsuite/c-c++-common/cilk-plus/PS/body.c @@ -1,5 +1,6 @@ /* { dg-do compile } */ /* { dg-options "-fcilkplus -fopenmp" } */ +/* { dg-require-effective-target fopenmp } */ int *a, *b, c; void *jmpbuf[10];