From patchwork Mon Nov 11 13:48:46 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kyrylo Tkachov X-Patchwork-Id: 290287 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 07E022C009E for ; Tue, 12 Nov 2013 00:49:07 +1100 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:content-type; q=dns; s=default; b=ZNtifrTuAiBeJrJl5Q7lrtkiNbmYgr32e1JuVZlUVmY VMghYGrFzZujWaEdd5Siun9IBrN107t46lK5BCUfPOGCz/MF01D6buof4F9xBuh5 ABI5ktsqe8iFjFTZb0HRDYxAMKtFR4fqyxyobbo5mx1KeNW3xaqA4M9Y6D02zOjk = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:content-type; s=default; bh=L/WBAzbOg+AqVJFjbabbgYxaywA=; b=cLLQjwnowpe/NFn6n oOYIp5ev4UoSSdRL9IEwVe4rtZPlsDXESoNEShthJIpfQ2nxPNNH8uq04v3TWSc3 kNzedDdEFBqRKFdIww6zN3SCCO5qnAZ0JWYywlK8rFFtJUxXIGkOTWvlYJn/yvtF NeLgRWBwrC8ESn8eM1jg6e1FTk= Received: (qmail 14199 invoked by alias); 11 Nov 2013 13:48:58 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 14186 invoked by uid 89); 11 Nov 2013 13:48:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL, BAYES_00, RDNS_NONE, SPF_PASS, URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: service87.mimecast.com Received: from Unknown (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 11 Nov 2013 13:48:57 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Mon, 11 Nov 2013 13:48:48 +0000 Received: from [10.1.208.24] ([10.1.255.212]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Mon, 11 Nov 2013 13:48:46 +0000 Message-ID: <5280E03E.1080705@arm.com> Date: Mon, 11 Nov 2013 13:48:46 +0000 From: Kyrill Tkachov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-Version: 1.0 To: GCC Patches CC: Ramana Radhakrishnan Subject: [PATCH][ARM] Fix "control reached end of non-void function" warning and boostrap X-MC-Unique: 113111113484808201 X-IsSubscribed: yes Hi all, My patch last Friday introduced a warning about reaching the end of a non-void function which breaks bootstrap. On second thought, instead of breaking at the end of the comparisons handling, we should just return instead. Tested arm-none-eabi on qemu and checked the build log to make sure the warning disappears. Ok for trunk? Thanks, Kyrill 2013-11-11 Kyrylo Tkachov * config/arm/arm.c (arm_new_rtx_costs): Return after handling comparisons. diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c index 2aa739d..62ec7f7 100644 --- a/gcc/config/arm/arm.c +++ b/gcc/config/arm/arm.c @@ -10154,7 +10154,7 @@ arm_new_rtx_costs (rtx x, enum rtx_code code, enum rtx_code outer_code, *cost = 0; return true; } - break; + return false; case ABS: if (TARGET_HARD_FLOAT && GET_MODE_CLASS (mode) == MODE_FLOAT