From patchwork Wed Jul 21 12:00:52 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Tytgat X-Patchwork-Id: 59434 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 5A303B70C9 for ; Wed, 21 Jul 2010 21:56:59 +1000 (EST) Received: (qmail 18146 invoked by alias); 21 Jul 2010 11:56:55 -0000 Received: (qmail 18119 invoked by uid 22791); 21 Jul 2010 11:56:54 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_LOW, RCVD_IN_JMF_BR, TW_YT X-Spam-Check-By: sourceware.org Received: from eir.is.scarlet.be (HELO eir.is.scarlet.be) (193.74.71.27) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 21 Jul 2010 11:56:48 +0000 Received: from hobbes (ip-83-134-174-13.dsl.scarlet.be [83.134.174.13]) by eir.is.scarlet.be (8.14.2/8.14.2) with ESMTP id o6LBuJbl028754; Wed, 21 Jul 2010 13:56:19 +0200 Date: Wed, 21 Jul 2010 13:00:52 +0100 From: John Tytgat To: gcc-patches@gcc.gnu.org Cc: nickc@redhat.com, richard.earnshaw@arm.com, paul@codesourcery.com Subject: Re: [PATCH, ARM, PING]: Remove superfluous test in arm_function_arg Message-ID: <527b493a51.Jo@hobbes.bass-software.com> References: <678f613751.Jo@hobbes.bass-software.com> In-Reply-To: <678f613751.Jo@hobbes.bass-software.com> X-Organization: BASS User-Agent: Messenger-Pro/2.62 (MsgServe/2.05) (RISC-OS/6.21) POPstar/2.05 MIME-Version: 1.0 X-DCC-scarlet.be-Metrics: eir 20001; Body=4 Fuz1=4 Fuz2=4 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org In message <678f613751.Jo@hobbes.bass-software.com> John Tytgat wrote: > Attached patch removes in arm_function_arg() a superfluous test on one > of its parameters as that test is already done at the beginning of the > routine and the parameter doesn't change during the function. Gentle reminder ping. In the meanwhile I've found another superfluous test in arm_override_options(). Updated patch attached. gcc/ John Tytgat * config/arm/arm.c (arm_function_arg): Remove superfluous test. (arm_override_options): Likewise. Please commit after positive review. John. Index: config/arm/arm.c =================================================================== --- config/arm/arm.c (revision 162370) +++ config/arm/arm.c (working copy) @@ -1526,9 +1526,6 @@ if (TARGET_ARM && TARGET_CALLEE_INTERWORKING) warning (0, "enabling callee interworking support is only meaningful when compiling for the Thumb"); - if (TARGET_ARM && TARGET_CALLER_INTERWORKING) - warning (0, "enabling caller interworking support is only meaningful when compiling for the Thumb"); - if (TARGET_APCS_STACK && !TARGET_APCS_FRAME) { warning (0, "-mapcs-stack-check incompatible with -mno-apcs-frame"); @@ -4479,10 +4476,6 @@ && arm_needs_doubleword_align (mode, type)) pcum->nregs++; - if (mode == VOIDmode) - /* Pick an arbitrary value for operand 2 of the call insn. */ - return const0_rtx; - /* Only allow splitting an arg between regs and memory if all preceding args were allocated to regs. For args passed by reference we only count the reference pointer. */