diff mbox series

install.texi (gcn): Suggest newer commit for Newlib

Message ID 5125f337-45c4-4777-a9e4-0f3f83f661df@baylibre.com
State New
Headers show
Series install.texi (gcn): Suggest newer commit for Newlib | expand

Commit Message

Tobias Burnus July 23, 2024, 10:05 a.m. UTC 
Hi Andrew, hi all,

to be compatible with C++ (and Thomas' WIP work for GCN C++ support), I 
suggest the attach patch that also suggest Thomas' Newlib commit (April 
4, 2024)

ed50a50b9   amdgcn: Implement proper locks: Fix 
'newlib/libc/sys/amdgcn/include/sys/lock.h' for C++

and not only your commit (March 25, 2024)

7dd4eb1db amdgcn: Implement proper locks

Comments or suggestions before I commit it?

Tobias

Comments

Andrew Stubbs July 23, 2024, 10:28 a.m. UTC | #1 
On 23/07/2024 11:05, Tobias Burnus wrote:
> Hi Andrew, hi all,
> 
> to be compatible with C++ (and Thomas' WIP work for GCN C++ support), I 
> suggest the attach patch that also suggest Thomas' Newlib commit (April 
> 4, 2024)
> 
> ed50a50b9   amdgcn: Implement proper locks: Fix 
> 'newlib/libc/sys/amdgcn/include/sys/lock.h' for C++
> 
> and not only your commit (March 25, 2024)
> 
> 7dd4eb1db amdgcn: Implement proper locks
> 
> Comments or suggestions before I commit it?

LGTM.

We should write the same thing on the Wiki Offloading page.

Andrew
diff mbox series

Patch

install.texi (gcn): Suggest newer commit for Newlib

Newlib 4.4.0 lacks two commits: 7dd4eb1db (2024-03-25) to fix device console
output for GFX10/GFX11 and ed50a50b9 (2024-04-04) to make the added lock.h
compilable with C++. This commit mentiones now also the second commit.

gcc/ChangeLog:

	* doc/install.texi (amdgcn-x-amdhsa): Suggest newer git version
	for newlib.

diff --git a/gcc/doc/install.texi b/gcc/doc/install.texi
index b5456992583..dda623f4410 100644
--- a/gcc/doc/install.texi
+++ b/gcc/doc/install.texi
@@ -3952,9 +3952,9 @@  Instead of GNU Binutils, you will need to install LLVM 15, or later, and copy
 by specifying a @code{--with-multilib-list=} that does not list @code{gfx1100}
 and @code{gfx1103}.
 
-Use Newlib (4.3.0 or newer; 4.4.0 contains some improvements and git commit
-7dd4eb1db (2024-03-25, post-4.4.0) fixes device console output for GFX10 and
-GFX11 devices).
+Use Newlib (4.3.0 or newer; 4.4.0 contains some improvements and git commits
+7dd4eb1db and ed50a50b9 (2024-04-04, post-4.4.0) fix device console output
+for GFX10 and GFX11 devices).
 
 To run the binaries, install the HSA Runtime from the
 @uref{https://rocm.docs.amd.com/,,ROCm Platform}, and use