From patchwork Thu Jan 10 05:15:10 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Law X-Patchwork-Id: 210935 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id EAEFC2C0216 for ; Thu, 10 Jan 2013 16:15:44 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1358399745; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Message-ID:Date:From:User-Agent:MIME-Version:To:Subject: Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:Sender:Delivered-To; bh=jR/ugNq Ikch/c8WkRSW+yTXQm/4=; b=wKWuKeRSK/qI7ZgRoHkZH8i6OGt+kBM5I7qixnZ 8wU/9KeZUv0qTe/mt1IyLG7I9wgLpbzRv1xFDeyYqMXK/cEf4fN7/rMT1t846oFh 95sSNkYKoICL+yIeqCa/dGYohSjFeHchAbQ4xwdA14FB++XdFMJnW46h2AjSuUol vTEk= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:Subject:Content-Type:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=WLc/DJ9juD7uy6Oj7b2fgqxEv5pDEzg3rhiawNQMbLfjp1AnrUFNxSdhQjj+ca ZFN+nI0d76NebPedxBu432CMDXh76ckQu7H9ZhQouNSCKLNtoXLFxFGH+1NVe8gk IZmKOoInUqFjbxkop35oWJt4Pi8BXK/69A04WCBEj2otg=; Received: (qmail 4602 invoked by alias); 10 Jan 2013 05:15:33 -0000 Received: (qmail 4578 invoked by uid 22791); 10 Jan 2013 05:15:30 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, RCVD_IN_DNSWL_HI, RCVD_IN_HOSTKARMA_W, RP_MATCHES_RCVD, SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 10 Jan 2013 05:15:21 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0A5FEYI025820 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 10 Jan 2013 00:15:16 -0500 Received: from stumpy.slc.redhat.com (ovpn-113-50.phx2.redhat.com [10.3.113.50]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r0A5FBU1026438 for ; Thu, 10 Jan 2013 00:15:14 -0500 Message-ID: <50EE4E5E.2060400@redhat.com> Date: Wed, 09 Jan 2013 22:15:10 -0700 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: gcc-patches Subject: Minor testsuite improvement X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Gary Funck noted that vrp06.c has two tests with the same output. After further investigation it was clear that expected output strings were too lenient and were in fact masking a missed optimization. This patch tightens the expected output from the vrp dump which has the side effect of making each test's string unique. Obviously the masked failure is xfailed. OK for the trunk? Thanks, Jeff * gcc/dg/tree-ssa/vrp06.c: Tighten expected output. Make each pass/fail message unique. diff --git a/gcc/testsuite/gcc.dg/tree-ssa/vrp06.c b/gcc/testsuite/gcc.dg/tree-ssa/vrp06.c index 1ef6c92..4edca36 100644 --- a/gcc/testsuite/gcc.dg/tree-ssa/vrp06.c +++ b/gcc/testsuite/gcc.dg/tree-ssa/vrp06.c @@ -25,7 +25,7 @@ foo (int i, int j, int a) return i + a + j; } -/* { dg-final { scan-tree-dump-times "Folding predicate i_.*to 0" 1 "vrp1" } } */ -/* { dg-final { scan-tree-dump-times "Folding predicate j_.*to 1" 1 "vrp1" } } */ -/* { dg-final { scan-tree-dump-times "Folding predicate i_.*to 0" 1 "vrp1" } } */ +/* { dg-final { scan-tree-dump-times "Folding predicate i_.*0 to 0" 1 "vrp1" } } */ +/* { dg-final { scan-tree-dump-times "Folding predicate j_.*0 to 1" 1 "vrp1" } } */ +/* { dg-final { scan-tree-dump-times "Folding predicate i_.*j_.* to 0" 1 "vrp1" { xfail *-*-* } } } */ /* { dg-final { cleanup-tree-dump "vrp1" } } */