From patchwork Fri Nov 9 17:12:57 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tobias Burnus X-Patchwork-Id: 198138 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 6C1082C01E5 for ; Sat, 10 Nov 2012 04:13:17 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1353085998; h=Comment: DomainKey-Signature:Received:Received:Received:Received: Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Content-Transfer-Encoding: Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:Sender:Delivered-To; bh=XdR5luOF+txsJs/5dhD4 m1DrzMc=; b=Jt6a2jYJplJaPa5IcSfxUERpmQOKEfLM2vN8FC7juJcqlnpF7jZ6 qPVGrZfHDsMKRzdLGH5wj0kmvo9wXYmjAW5H/zg6yX/pCa1LPz1Biodl7mODB2Zf 5AWtkvgIYaJVCKSFu222R4XGVKqBnHInTFjkXFpFWq+x9rCPk9qAAbw= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=Kjz6prjwj5Sd+OXPTXht+SfG7dwzM40TEnm3EdF88MwwD9OnqLzfZegwEuF9WD CQscZm4B8j2cLuA6T/y25dGzTIC9bey9oQqubAFUqEKxBTwF6aMKttw4nSi0L+SG dYEny5fG9VXrZICNvHbWpmzBBZ5SBxt+6iT1VMIQXAVA4=; Received: (qmail 2768 invoked by alias); 9 Nov 2012 17:13:10 -0000 Received: (qmail 2746 invoked by uid 22791); 9 Nov 2012 17:13:08 -0000 X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 tests=AWL, BAYES_00, KHOP_THREADED, RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mx01.qsc.de (HELO mx01.qsc.de) (213.148.129.14) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Nov 2012 17:13:00 +0000 Received: from [192.168.178.25] (port-92-195-110-241.dynamic.qsc.de [92.195.110.241]) by mx01.qsc.de (Postfix) with ESMTP id B1CD03CB51; Fri, 9 Nov 2012 18:12:58 +0100 (CET) Message-ID: <509D3999.1020704@net-b.de> Date: Fri, 09 Nov 2012 18:12:57 +0100 From: Tobias Burnus User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121025 Thunderbird/16.0.2 MIME-Version: 1.0 To: Jakub Jelinek CC: Dodji Seketeli , gcc-patches@gcc.gnu.org, dnovillo@google.com, wmi@google.com, davidxl@google.com, konstantin.s.serebryany@gmail.com Subject: Re: [PATCH 01/10] Initial import of asan from the Google branch into trunk References: <1351799566-31447-1-git-send-email-dodji@redhat.com> <87pq3v8vmi.fsf@redhat.com> <87ip9n8vi2.fsf_-_@redhat.com> <509D019C.7020505@net-b.de> <20121109135816.GB1886@tucnak.redhat.com> In-Reply-To: <20121109135816.GB1886@tucnak.redhat.com> Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Jakub Jelinek wrote: > On Fri, Nov 09, 2012 at 02:14:04PM +0100, Tobias Burnus wrote: >> I tried the 01/10 to 10/10 patch series but it doesn't trigger for >> the following test case: [...] > Can't reproduce that (admittedly with asan SVN branch rather than the patchset): I can reproduce both; comparing the asan0 dumps and the two asan.c files, I came up with the following patch. If I apply it on top of Dodji's branch, it now also aborts. Other remarks: * libsanitizer: It currently installs under "lib" even under a x86-64-gnu-linux system where it should be "lib64"; that's probably automatically fix by enabling the multilib support. Maybe, removing the "#" before "#AM_ENABLE_MULTILIB" in libsanitizer/configure.ac is sufficient * invoke.texi: The fbranch-target-load-optimize2 and fauto-inc-dec lost the "-", additionally, there are several "--f…" items. Tobias PS: Has someone an idea why I cannot run the -faddress-sanitizer executable on gcc20 of the GCC compile farm? Fails with the following message, but "ulimit -v" is set to "unlimited". ==4784== ReserveShadowMemoryRange failed while trying to map 0x20000001000 bytes. Perhaps you're using ulimit -v --- a/gcc/asan.c +++ b/gcc/asan.c @@ -1536,10 +1536,10 @@ static void asan_init_shadow_ptr_types (void) { asan_shadow_set = new_alias_set (); - shadow_ptr_types[0] = build_distinct_type_copy (unsigned_char_type_node); + shadow_ptr_types[0] = build_distinct_type_copy (signed_char_type_node); TYPE_ALIAS_SET (shadow_ptr_types[0]) = asan_shadow_set; shadow_ptr_types[0] = build_pointer_type (shadow_ptr_types[0]); - shadow_ptr_types[1] = build_distinct_type_copy (short_unsigned_type_node); + shadow_ptr_types[1] = build_distinct_type_copy (short_integer_type_node); TYPE_ALIAS_SET (shadow_ptr_types[1]) = asan_shadow_set; shadow_ptr_types[1] = build_pointer_type (shadow_ptr_types[1]); }