From patchwork Tue Jun 12 01:03:24 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 164292 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 392BFB6FBC for ; Tue, 12 Jun 2012 11:03:56 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1340067837; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Mailing-List:Precedence: List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=mTrsONBjjYGI7bKeZZnWYSt+FNI=; b=Awl8bMSB1kk1dBJ xMHoU6N92SqIXxjbgI3YK46Jgp1Exi6WcvwMSa9q3ZM+sZOtDksVI4zOK3Oqu+Je 42sxIlYPSIijmtQ1Hc4hBZk8WuNeBwFXEOS+Vgy9LZ094qqOZlsWu9mRUgo2zUGe UrCmbpu5d6/Qz957KGA0ztsuojeI= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=N03hI06JHdx0wpdcQMvjg6cIJWTZKM8CnIzF4YbjXMXkWLQfOq7Mi5ZaTbU6tS FPYiuGt3Arq/WNF7+EtSCOc1RPNlmfSp7F1/HTbhOj5sDZwiwLab3O7iIen/UCDG 4SNDW+pgIfXEX/FDCb1BIIYpzJwluIZ5+PS6NBG4B1nII=; Received: (qmail 11884 invoked by alias); 12 Jun 2012 01:03:53 -0000 Received: (qmail 11872 invoked by uid 22791); 12 Jun 2012 01:03:52 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, KHOP_THREADED, RCVD_IN_DNSWL_HI, RCVD_IN_HOSTKARMA_W, SPF_HELO_PASS, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 12 Jun 2012 01:03:35 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q5C13S3C005840 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 11 Jun 2012 21:03:28 -0400 Received: from pebble.twiddle.home (vpn-10-127.rdu.redhat.com [10.11.10.127]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q5C13RH9025623; Mon, 11 Jun 2012 21:03:27 -0400 Message-ID: <4FD6955C.4090904@redhat.com> Date: Mon, 11 Jun 2012 18:03:24 -0700 From: Richard Henderson User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Mike Stump CC: Jay K , GCC Patches Subject: Re: constant that doesn't fit in 32bits in alpha.c References: <4FD67990.1080904@redhat.com> <4FD679DB.7010105@redhat.com> <6641E578-5D47-48B6-9639-DCE2E45EABAE@comcast.net> In-Reply-To: <6641E578-5D47-48B6-9639-DCE2E45EABAE@comcast.net> X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On 2012-06-11 16:23, Mike Stump wrote: > On Jun 11, 2012, at 4:06 PM, Richard Henderson wrote: >> Bah. Wrong patch. >> >> >> r~ >> > > > Hum, I'm trying to see how this patch works... I feel like there is > something I'm missing, like a shift? Double-bah. That's what I get for changing the patch at the last minute. r~ * config/alpha/alpha.c (HWI_HEX2): Add missing shift. diff --git a/gcc/config/alpha/alpha.c b/gcc/config/alpha/alpha.c index 3dda9fb..2177288 100644 --- a/gcc/config/alpha/alpha.c +++ b/gcc/config/alpha/alpha.c @@ -5451,7 +5451,7 @@ alpha_trampoline_init (rtx m_tramp, tree fndecl, rtx chain_value) chain_value = convert_memory_address (Pmode, chain_value); #endif -#define HWI_HEX2(X,Y) (((HOST_WIDE_INT)0x ## X ## u) | 0x ## Y ## u) +#define HWI_HEX2(X,Y) (((HOST_WIDE_INT)0x ## X ## u << 32) | 0x ## Y ## u) if (TARGET_ABI_OPEN_VMS) {