From patchwork Thu Jan 5 09:51:42 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcus Shawcroft X-Patchwork-Id: 134450 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 3ACAB1007D6 for ; Thu, 5 Jan 2012 20:52:02 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1326361922; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Mailing-List:Precedence: List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=nPy+zbBMyCNdlE79f4d1TngqChU=; b=PvPUx52lX/knK34 ICKzXHvEGtOt80zfKpsKuEbhHUX6agaalxcmxyr2r2FdrHaP5FF9fY+3YS8+0gqV 4UybbaATjerNrENkT78DqTOE3p9+QEaXO358PO6YD/5z8ibpbPd9eUmNtJjx0tnI kgw9VtmHVSn+oZ4ARSXoI824uHho= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:X-MC-Unique:Content-Type:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=st+tbgdXOGhJas7t6NW8lcRtkchtaDn6xi2SFrbpH0fctMSLKRsT1OcPkrRoiQ MrgWNKe7blFgziv+Yc9oqAVXg65Ch84pFbEWIYBc0zPjZBGXy7GtXk7VvNVIyps3 vFoAA6CsX5tzub5f8bZfLYtRs/TBPX+pW3WBpFujj8NV8=; Received: (qmail 7573 invoked by alias); 5 Jan 2012 09:51:59 -0000 Received: (qmail 7565 invoked by uid 22791); 5 Jan 2012 09:51:59 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 05 Jan 2012 09:51:46 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Thu, 05 Jan 2012 09:51:44 +0000 Received: from [10.1.72.172] ([10.1.255.212]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 5 Jan 2012 09:51:41 +0000 Message-ID: <4F0572AE.40801@arm.com> Date: Thu, 05 Jan 2012 09:51:42 +0000 From: Marcus Shawcroft User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.23) Gecko/20110922 Thunderbird/3.1.15 MIME-Version: 1.0 To: Jeff Law CC: "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH] Add missed adjustment to label_nuses in reload. References: <4F045D38.7060204@arm.com> <4F04A6D4.3050502@redhat.com> In-Reply-To: <4F04A6D4.3050502@redhat.com> X-MC-Unique: 112010509514402201 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org > Approved after you fix some minor fomatting nits. Your code has: Thank you. I committed the attached nit adjusted patch. /Marcus diff --git a/gcc/reload.c b/gcc/reload.c index 53dcd2d..206fb36 100644 --- a/gcc/reload.c +++ b/gcc/reload.c @@ -4212,7 +4212,12 @@ find_reloads (rtx insn, int replace, int ind_levels, int live_known, && (!JUMP_P (insn) || !label_is_jump_target_p (XEXP (substitution, 0), insn))) - add_reg_note (insn, REG_LABEL_OPERAND, XEXP (substitution, 0)); + { + add_reg_note (insn, REG_LABEL_OPERAND, XEXP (substitution, 0)); + if (LABEL_P (XEXP (substitution, 0))) + ++LABEL_NUSES (XEXP (substitution, 0)); + } + } else retval |= (substed_operand[i] != *recog_data.operand_loc[i]);