From patchwork Fri Nov 4 18:54:31 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 123682 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 18EFDB6F7F for ; Sat, 5 Nov 2011 05:54:58 +1100 (EST) Received: (qmail 29365 invoked by alias); 4 Nov 2011 18:54:55 -0000 Received: (qmail 29357 invoked by uid 22791); 4 Nov 2011 18:54:53 -0000 X-SWARE-Spam-Status: No, hits=-7.0 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 Nov 2011 18:54:38 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pA4IsWGp023555 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 4 Nov 2011 14:54:32 -0400 Received: from anchor.twiddle.net (vpn-225-81.phx2.redhat.com [10.3.225.81]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pA4IsV6c021215; Fri, 4 Nov 2011 14:54:32 -0400 Message-ID: <4EB434E7.4040206@redhat.com> Date: Fri, 04 Nov 2011 11:54:31 -0700 From: Richard Henderson User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110927 Thunderbird/7.0 MIME-Version: 1.0 To: "Joseph S. Myers" CC: Aldy Hernandez , gcc-patches Subject: Re: [patch] 16/n: trans-mem: compiler parser/front-end References: <4EB2E588.1040806@redhat.com> <4EB2FD4B.4000306@redhat.com> In-Reply-To: <4EB2FD4B.4000306@redhat.com> X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On 11/03/2011 01:44 PM, Richard Henderson wrote: > On 11/03/2011 01:34 PM, Joseph S. Myers wrote: >> On Thu, 3 Nov 2011, Aldy Hernandez wrote: >> >>> +/* Parse a transaction attribute (GCC Extension). >>> + >>> + transaction-attribute: >>> + attributes >>> + [ [ any-word ] ] >> >> I don't see any syntax production comments including >> transaction-attribute. Please update the comments to include this in >> every case where it is permitted. > > Ah, the comment in question is currently > > __transaction_atomic attributes[opt] compound-statement > > where that should be transaction-attributes[opt] instead. > > Will fix. Like so. r~ * c-parser.c: Fix production comments using transaction-attribute. diff --git a/gcc/c-parser.c b/gcc/c-parser.c index 88bf08b..a44923d 100644 --- a/gcc/c-parser.c +++ b/gcc/c-parser.c @@ -10555,7 +10555,7 @@ c_parser_transaction_attributes (c_parser *parser) (GCC Extension). transaction-statement: - __transaction_atomic attributes[opt] compound-statement + __transaction_atomic transaction-attribute[opt] compound-statement __transaction_relaxed compound-statement Note that the only valid attribute is: "outer". @@ -10664,7 +10664,7 @@ c_parser_transaction_expression (c_parser *parser, enum rid keyword) /* Parse a __transaction_cancel statement (GCC Extension). transaction-cancel-statement: - __transaction_cancel attributes[opt] ; + __transaction_cancel transaction-attribute[opt] ; Note that the only valid attribute is "outer". */