diff mbox

[C++] BASELINK_P clean up

Message ID 4EA83852.4020105@oracle.com
State New
Headers show

Commit Message

Paolo Carlini Oct. 26, 2011, 4:41 p.m. UTC
Hi,

we have an inconsistent mix: shall we do the below? Test in progress on 
x86_64-linux.

Thanks,
Paolo.

//////////////////
2011-10-26  Paolo Carlini  <paolo.carlini@oracle.com>

	* typeck.c (cp_build_addr_expr_1): Use BASELINK_P.
	* class.c (instantiate_type): Likewise.
	* pt.c (convert_nontype_argument_function, uses_template_parms,
	tsubst_copy, resolve_nondeduced_context, type_dependent_expression_p):
	Likewise.
	* semantics.c (finish_decltype_type): Likewise.
	* decl2.c (mark_used): Likewise.
	* name-lookup.c (arg_assoc): Likewise.

Comments

Jason Merrill Oct. 26, 2011, 5:37 p.m. UTC | #1
On 10/26/2011 12:41 PM, Paolo Carlini wrote:
> we have an inconsistent mix: shall we do the below?

Sure, why not.

Jason
diff mbox

Patch

Index: typeck.c
===================================================================
--- typeck.c	(revision 180528)
+++ typeck.c	(working copy)
@@ -4946,7 +4946,7 @@  cp_build_addr_expr_1 (tree arg, bool strict_lvalue
       if (TREE_CODE (arg) == OFFSET_REF)
 	PTRMEM_OK_P (val) = PTRMEM_OK_P (arg);
     }
-  else if (TREE_CODE (TREE_OPERAND (arg, 1)) == BASELINK)
+  else if (BASELINK_P (TREE_OPERAND (arg, 1)))
     {
       tree fn = BASELINK_FUNCTIONS (TREE_OPERAND (arg, 1));
 
Index: class.c
===================================================================
--- class.c	(revision 180528)
+++ class.c	(working copy)
@@ -6873,7 +6873,7 @@  instantiate_type (tree lhstype, tree rhs, tsubst_f
 	}
     }
 
-  if (TREE_CODE (rhs) == BASELINK)
+  if (BASELINK_P (rhs))
     {
       access_path = BASELINK_ACCESS_BINFO (rhs);
       rhs = BASELINK_FUNCTIONS (rhs);
Index: pt.c
===================================================================
--- pt.c	(revision 180528)
+++ pt.c	(working copy)
@@ -5277,7 +5277,7 @@  convert_nontype_argument_function (tree type, tree
   fn_no_ptr = fn;
   if (TREE_CODE (fn_no_ptr) == ADDR_EXPR)
     fn_no_ptr = TREE_OPERAND (fn_no_ptr, 0);
-  if (TREE_CODE (fn_no_ptr) == BASELINK)
+  if (BASELINK_P (fn_no_ptr))
     fn_no_ptr = BASELINK_FUNCTIONS (fn_no_ptr);
  
   /* [temp.arg.nontype]/1
@@ -7801,7 +7801,7 @@  uses_template_parms (tree t)
 	   || EXPR_P (t)
 	   || TREE_CODE (t) == TEMPLATE_PARM_INDEX
 	   || TREE_CODE (t) == OVERLOAD
-	   || TREE_CODE (t) == BASELINK
+	   || BASELINK_P (t)
 	   || TREE_CODE (t) == IDENTIFIER_NODE
 	   || TREE_CODE (t) == TRAIT_EXPR
 	   || TREE_CODE (t) == CONSTRUCTOR
@@ -11993,7 +11993,7 @@  tsubst_copy (tree t, tree args, tsubst_flags_t com
 					 base, name,
 					 /*template_p=*/false);
 	  }
-	else if (TREE_CODE (name) == BASELINK)
+	else if (BASELINK_P (name))
 	  name = tsubst_baselink (name,
 				  non_reference (TREE_TYPE (object)),
 				  args, complain,
@@ -15197,7 +15197,7 @@  resolve_nondeduced_context (tree orig_expr)
       offset = expr;
       expr = TREE_OPERAND (expr, 1);
     }
-  if (TREE_CODE (expr) == BASELINK)
+  if (BASELINK_P (expr))
     {
       baselink = expr;
       expr = BASELINK_FUNCTIONS (expr);
@@ -19314,7 +19314,7 @@  type_dependent_expression_p (tree expression)
       if (TREE_CODE (expression) == SCOPE_REF)
 	return false;
 
-      if (TREE_CODE (expression) == BASELINK)
+      if (BASELINK_P (expression))
 	expression = BASELINK_FUNCTIONS (expression);
 
       if (TREE_CODE (expression) == TEMPLATE_ID_EXPR)
Index: semantics.c
===================================================================
--- semantics.c	(revision 180528)
+++ semantics.c	(working copy)
@@ -5115,7 +5115,7 @@  finish_decltype_type (tree expr, bool id_expressio
            step.  */
         expr = TREE_OPERAND (expr, 1);
 
-      if (TREE_CODE (expr) == BASELINK)
+      if (BASELINK_P (expr))
         /* See through BASELINK nodes to the underlying function.  */
         expr = BASELINK_FUNCTIONS (expr);
 
Index: decl2.c
===================================================================
--- decl2.c	(revision 180528)
+++ decl2.c	(working copy)
@@ -4174,7 +4174,7 @@  mark_used (tree decl)
      like the DECL for the function.  Otherwise, if the BASELINK is
      for an overloaded function, we don't know which function was
      actually used until after overload resolution.  */
-  if (TREE_CODE (decl) == BASELINK)
+  if (BASELINK_P (decl))
     {
       decl = BASELINK_FUNCTIONS (decl);
       if (really_overloaded_fn (decl))
Index: name-lookup.c
===================================================================
--- name-lookup.c	(revision 180528)
+++ name-lookup.c	(working copy)
@@ -5329,7 +5329,7 @@  arg_assoc (struct arg_lookup *k, tree n)
     n = TREE_OPERAND (n, 1);
   while (TREE_CODE (n) == TREE_LIST)
     n = TREE_VALUE (n);
-  if (TREE_CODE (n) == BASELINK)
+  if (BASELINK_P (n))
     n = BASELINK_FUNCTIONS (n);
 
   if (TREE_CODE (n) == FUNCTION_DECL)