Fix testsuite profiling support checks

The following change

	2011-05-26  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
	PR gcov-profile/48845

causes testsuite failures on C6X. Specifically,

@@ -495,11 +495,16 @@ proc check_profiling_available { test_wh
     # These conditions depend on the argument so examine them before
     # looking at the cache variable.

+    # Tree profiling requires TLS runtime support.
+    if { $test_what == "-fprofile-generate" } {
+       return [check_effective_target_tls_runtime]
+    }
+

skips all the further tests in that function if
check_effective_target_tls_runtime returns true. (I'm not sure why it
does that on C6X - it seems to link in emutls stuff?) We then fail with
unresolved __gcov symbols.

Fixed with the following patch. I've removed the new avr special case,
assuming it was intended to fix the same issue. Ok?


Bernd
* testsuite/lib/target-supports.exp (check_profiling_available):
	Don't rely solely on TLS tests for -fprofile-generate, fall
	through to the other code.

On 09/01/11 15:20, Bernd Schmidt wrote:
> The following change
> 
> 	2011-05-26  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
> 	PR gcov-profile/48845
> 
> causes testsuite failures on C6X. Specifically,
> 
> @@ -495,11 +495,16 @@ proc check_profiling_available { test_wh
>      # These conditions depend on the argument so examine them before
>      # looking at the cache variable.
> 
> +    # Tree profiling requires TLS runtime support.
> +    if { $test_what == "-fprofile-generate" } {
> +       return [check_effective_target_tls_runtime]
> +    }
> +
> 
> skips all the further tests in that function if
> check_effective_target_tls_runtime returns true. (I'm not sure why it
> does that on C6X - it seems to link in emutls stuff?) We then fail with
> unresolved __gcov symbols.
> 
> Fixed with the following patch. I've removed the new avr special case,
> assuming it was intended to fix the same issue. Ok?

Ping?


Bernd

On Sep 1, 2011, at 6:20 AM, Bernd Schmidt wrote:
> The following change
> 
> 	2011-05-26  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
> 	PR gcov-profile/48845
> 
> causes testsuite failures on C6X.

I was hoping that Rainer would comment...  or a profiling person, or an avr person....

> Ok?

Ok.  Watch for any hate mail from the avr folks.  :-)

Bernd Schmidt <bernds@codesourcery.com> writes:

> The following change
>
> 	2011-05-26  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
> 	PR gcov-profile/48845
>
> causes testsuite failures on C6X. Specifically,
>
> @@ -495,11 +495,16 @@ proc check_profiling_available { test_wh
>      # These conditions depend on the argument so examine them before
>      # looking at the cache variable.
>
> +    # Tree profiling requires TLS runtime support.
> +    if { $test_what == "-fprofile-generate" } {
> +       return [check_effective_target_tls_runtime]
> +    }
> +
>
> skips all the further tests in that function if
> check_effective_target_tls_runtime returns true. (I'm not sure why it
> does that on C6X - it seems to link in emutls stuff?) We then fail with

Right, this is always present and satisfies the tls_runtime test.  The
check was primarily meant for targets that have native TLS, but need
special switches to enable it.

	Rainer

Mike Stump <mikestump@comcast.net> writes:

> On Sep 1, 2011, at 6:20 AM, Bernd Schmidt wrote:
>> The following change
>> 
>> 	2011-05-26  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
>> 	PR gcov-profile/48845
>> 
>> causes testsuite failures on C6X.
>
> I was hoping that Rainer would comment...  or a profiling person, or an avr person....

I've just returned from a 3-week vacation and am slowly working through
my mail.

>> Ok?
>
> Ok.  Watch for any hate mail from the avr folks.  :-)

Looks good.  I'm just running a Solaris 8/x86 bootstrap, which will
notice if something's amiss for that target.

Thanks.
	Rainer