Message ID | 4E5CA6A1.4050302@oracle.com |
---|---|
State | New |
Headers | show |
Hi Pedro, The update of copyright date is ok. The rest of the patch doesn't look right. Why you have here a stray comma? Why you remove here leading spaces for comments? Kai 2011/8/30 Paolo Carlini <paolo.carlini@oracle.com>: > ... I committed the below because what we have now cannot possibly be right, > can easily break the build. Please the target maintainers double check the > whole thing, test it. > > Paolo. > > ////////////////////////// >
On 08/30/2011 11:18 AM, Kai Tietz wrote: > Hi Pedro, Paolo > The update of copyright date is ok. > The rest of the patch doesn't look right. Why you have here a stray > comma? Actually, *you* had wrong commas. Look closer. Paolo.
2011/8/30 Paolo Carlini <paolo.carlini@oracle.com>: > On 08/30/2011 11:18 AM, Kai Tietz wrote: >> >> Hi Pedro, > > Paolo >> >> The update of copyright date is ok. >> The rest of the patch doesn't look right. Why you have here a stray >> comma? > > Actually, *you* had wrong commas. Look closer. > > Paolo. Yes, saw it now. Thanks for catching it. Is ok. Thanks, Kai
Index: config/os/mingw32/error_constants.h =================================================================== --- config/os/mingw32/error_constants.h (revision 178284) +++ config/os/mingw32/error_constants.h (working copy) @@ -1,6 +1,6 @@ // Specific definitions for mingw32 platform -*- C++ -*- -// Copyright (C) 2007, 2008, 2009, 2010 Free Software Foundation, Inc. +// Copyright (C) 2007, 2008, 2009, 2010, 2011 Free Software Foundation, Inc. // // This file is part of the GNU ISO C++ Library. This library is free // software; you can redistribute it and/or modify it under the @@ -33,7 +33,6 @@ #include <bits/c++config.h> #include <cerrno> - namespace std _GLIBCXX_VISIBILITY(default) { _GLIBCXX_BEGIN_NAMESPACE_VERSION @@ -129,11 +128,12 @@ too_many_files_open_in_system = ENFILE, too_many_files_open = EMFILE, too_many_links = EMLINK - // too_many_symbolic_link_levels = ELOOP, +// too_many_symbolic_link_levels = ELOOP, #ifdef _GLIBCXX_HAVE_EOVERFLOW - value_too_large = EOVERFLOW, + , + value_too_large = EOVERFLOW #endif - // wrong_protocol_type = EPROTOTYPE +// wrong_protocol_type = EPROTOTYPE }; _GLIBCXX_END_NAMESPACE_VERSION