diff mbox

[testsuite] ignore irrelevant warning in two ARM tests

Message ID 4DDC16CB.20209@codesourcery.com
State New
Headers show

Commit Message

Janis Johnson May 24, 2011, 8:36 p.m. UTC 
On 05/24/2011 12:40 PM, Joseph S. Myers wrote:
> On Tue, 24 May 2011, Janis Johnson wrote:
> 
>> On ARM, two g++ tests trigger a warning about changed mangling.  The
>> warning is not relevant to the purpose of the test, so this patch
>> causes it to be ignored.
> 
> Various existing tests use -Wno-abi or -Wno-psabi on particular targets 
> for such cases.  E.g.
> 
> // { dg-options "-Wno-abi" { target arm_eabi } }
> 

Is this one OK for trunk and 4.6?  The failure occurs for arm-none-eabi
and for arm-none-linux-gnueabi.
2011-05-24  Janis Johnson  <janisjo@codesourcery.com>

	* g++.dg/template/stdarg1.C: Suppress a warning.
	* g++.dg/warn/Wunused-parm-3.C: Likewise.

Comments

Janis Johnson May 24, 2011, 9:01 p.m. UTC | #1 
On 05/24/2011 01:36 PM, Janis Johnson wrote:
> On 05/24/2011 12:40 PM, Joseph S. Myers wrote:
>> On Tue, 24 May 2011, Janis Johnson wrote:
>>
>>> On ARM, two g++ tests trigger a warning about changed mangling.  The
>>> warning is not relevant to the purpose of the test, so this patch
>>> causes it to be ignored.
>>
>> Various existing tests use -Wno-abi or -Wno-psabi on particular targets 
>> for such cases.  E.g.
>>
>> // { dg-options "-Wno-abi" { target arm_eabi } }
>>
> 
> Is this one OK for trunk and 4.6?  The failure occurs for arm-none-eabi
> and for arm-none-linux-gnueabi.

Sorry, I hadn't noticed that arm_eabi is an effective-target keyword;
I'll use that instead.
Joseph Myers May 24, 2011, 10:33 p.m. UTC | #2 
On Tue, 24 May 2011, Janis Johnson wrote:

> On 05/24/2011 12:40 PM, Joseph S. Myers wrote:
> > On Tue, 24 May 2011, Janis Johnson wrote:
> > 
> >> On ARM, two g++ tests trigger a warning about changed mangling.  The
> >> warning is not relevant to the purpose of the test, so this patch
> >> causes it to be ignored.
> > 
> > Various existing tests use -Wno-abi or -Wno-psabi on particular targets 
> > for such cases.  E.g.
> > 
> > // { dg-options "-Wno-abi" { target arm_eabi } }
> > 
> 
> Is this one OK for trunk and 4.6?  The failure occurs for arm-none-eabi
> and for arm-none-linux-gnueabi.

You should repeat all the original options from the main dg-options line, 
with -Wno-abi added, in the ARM EABI dg-options line, since only one 
dg-options line will be in effect.
Janis Johnson May 24, 2011, 10:42 p.m. UTC | #3 
On 05/24/2011 03:33 PM, Joseph S. Myers wrote:
> On Tue, 24 May 2011, Janis Johnson wrote:
> 
>> On 05/24/2011 12:40 PM, Joseph S. Myers wrote:
>>> On Tue, 24 May 2011, Janis Johnson wrote:
>>>
>>>> On ARM, two g++ tests trigger a warning about changed mangling.  The
>>>> warning is not relevant to the purpose of the test, so this patch
>>>> causes it to be ignored.
>>>
>>> Various existing tests use -Wno-abi or -Wno-psabi on particular targets 
>>> for such cases.  E.g.
>>>
>>> // { dg-options "-Wno-abi" { target arm_eabi } }
>>>
>>
>> Is this one OK for trunk and 4.6?  The failure occurs for arm-none-eabi
>> and for arm-none-linux-gnueabi.
> 
> You should repeat all the original options from the main dg-options line, 
> with -Wno-abi added, in the ARM EABI dg-options line, since only one 
> dg-options line will be in effect.

Oops, yet again.  I'll do that.

Janis
Mike Stump May 25, 2011, 12:49 a.m. UTC | #4 
On May 24, 2011, at 3:42 PM, Janis Johnson wrote:
>>> Is this one OK for trunk and 4.6?  The failure occurs for arm-none-eabi
>>> and for arm-none-linux-gnueabi.
>> 
>> You should repeat all the original options from the main dg-options line, 
>> with -Wno-abi added, in the ARM EABI dg-options line, since only one 
>> dg-options line will be in effect.
> 
> Oops, yet again.  I'll do that.

Ok with that change.  Also, if there are many of these exceptions, it might be better to add the flags to shut it up to the base set of flags, and then to add it explicitly to any testcase that really does want to test the warning.
Janis Johnson May 25, 2011, 3:15 p.m. UTC | #5 
On 05/24/2011 05:49 PM, Mike Stump wrote:
> On May 24, 2011, at 3:42 PM, Janis Johnson wrote:
>>>> Is this one OK for trunk and 4.6?  The failure occurs for arm-none-eabi
>>>> and for arm-none-linux-gnueabi.
>>>
>>> You should repeat all the original options from the main dg-options line, 
>>> with -Wno-abi added, in the ARM EABI dg-options line, since only one 
>>> dg-options line will be in effect.
>>
>> Oops, yet again.  I'll do that.
> 
> Ok with that change.  Also, if there are many of these exceptions, it might be better to add the flags to shut it up to the base set of flags, and then to add it explicitly to any testcase that really does want to test the warning.

These are the only tests I've found that get this message.

Janis
diff mbox

Patch

Index: g++.dg/template/stdarg1.C
===================================================================
--- g++.dg/template/stdarg1.C	(revision 174094)
+++ g++.dg/template/stdarg1.C	(working copy)
@@ -1,5 +1,7 @@ 
 // PR c++/47022
 // { dg-do compile }
+// Suppress a warning that is irrelevant to the purpose of this test.
+// { dg-options "-Wno-abi" { target arm*-*-*eabi } }
 
 #include <cstdarg>
 
Index: g++.dg/warn/Wunused-parm-3.C
===================================================================
--- g++.dg/warn/Wunused-parm-3.C	(revision 174094)
+++ g++.dg/warn/Wunused-parm-3.C	(working copy)
@@ -1,5 +1,7 @@ 
 // { dg-do compile }
 // { dg-options "-Wunused -W" }
+// Suppress a warning that is irrelevant to the purpose of this test.
+// { dg-options "-Wno-abi" { target arm*-*-*eabi } }
 
 #include <stdarg.h>