From patchwork Tue Apr 19 17:29:40 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Georg-Johann Lay X-Patchwork-Id: 92036 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 9430AB7022 for ; Wed, 20 Apr 2011 03:29:59 +1000 (EST) Received: (qmail 23213 invoked by alias); 19 Apr 2011 17:29:57 -0000 Received: (qmail 23202 invoked by uid 22791); 19 Apr 2011 17:29:55 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mo-p00-ob.rzone.de (HELO mo-p00-ob.rzone.de) (81.169.146.161) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 19 Apr 2011 17:29:41 +0000 X-RZG-AUTH: :LXoWVUeid/7A29J/hMvvT2k715jHQaJercGObUOFkj18odoYNahU4Q== X-RZG-CLASS-ID: mo00 Received: from [192.168.0.22] (business-188-111-022-002.static.arcor-ip.net [188.111.22.2]) by post.strato.de (klopstock mo54) (RZmta 25.17) with ESMTPA id N0665an3JFAq8V for ; Tue, 19 Apr 2011 19:29:40 +0200 (MEST) Message-ID: <4DADC684.5030908@gjlay.de> Date: Tue, 19 Apr 2011 19:29:40 +0200 From: Georg-Johann Lay User-Agent: Thunderbird 2.0.0.24 (X11/20100302) MIME-Version: 1.0 To: gcc-patches@gcc.gnu.org Subject: Re: [testsuite]: Skip some tests for avr References: <4DAD725B.6060405@gjlay.de> In-Reply-To: X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Hans-Peter Nilsson schrieb: > On Tue, 19 Apr 2011, Georg-Johann Lay wrote: >> This patchlet skips some tests for avr because int is just 16 bits there. > >> 2011-04-19 Georg-Johann Lay >> >> * gcc.c-torture/compile/pr43191.c: Skip avr due to 16-bit int. >> * gcc.dg/torture/pr43165.c: Ditto. >> * gcc.dg/torture/pr47228.c: Ditto. >> * gcc.dg/tree-ssa/pr45144.c: Ditto. >> * gcc.dg/ipa/pr45644.c: Ditto. >> > > (Cutnpasted instead of quoting because alpine can't quote > attached text; please inline patches.) > > Index: gcc.c-torture/compile/pr43191.c > =================================================================== > --- gcc.c-torture/compile/pr43191.c (Revision 172597) > +++ gcc.c-torture/compile/pr43191.c (Arbeitskopie) > @@ -1,4 +1,4 @@ > -/* { dg-skip-if "Ints are 16 bits" { "pdp11-*-*" } { "*" } { "" } } */ > +/* { dg-skip-if "Ints are 16 bits" { "avr-*-*" "pdp11-*-*" } { "*" } { "" } }*/ > > That pdp11 stanza was a bad precedent. Please instead use one of > > /* { dg-skip-if "Ints are 16 bits" { ! int32plus } { "*" } { "" } } */ > or > /* { dg-require-effective-target int32plus } */ > or > /* { dg-do X { target int32plus } } */ > (where X = {compile, run, assemble}) > > so we don't have to keep a steadily increasing target list > (decreasing only when targets are removed). > > brgds, H-P Thanks for that hint. There are some more test cases that imply int >= 32 bit Johann 2011-04-19 Georg-Johann Lay * gcc.dg/pr42629.c: Add dg-require-effective-target int32plus * gcc.c-torture/execute/cmpsi-2.c: Ditto * gcc.c-torture/execute/pr45262.c: Ditto * gcc.dg/torture/pr43165.c: Ditto. * gcc.dg/torture/pr47228.c: Ditto. * gcc.dg/tree-ssa/pr45144.c: Ditto. * gcc.dg/ipa/pr45644.c: Ditto. * gcc.c-torture/compile/pr43191.c: Ditto. Remove dg-skip-if for PDP11. Index: gcc.c-torture/execute/cmpsi-2.c =================================================================== --- gcc.c-torture/execute/cmpsi-2.c (Revision 172597) +++ gcc.c-torture/execute/cmpsi-2.c (Arbeitskopie) @@ -1,3 +1,5 @@ +/* { dg-require-effective-target int32plus } */ + #define F 140 #define T 13 Index: gcc.c-torture/execute/pr45262.c =================================================================== --- gcc.c-torture/execute/pr45262.c (Revision 172597) +++ gcc.c-torture/execute/pr45262.c (Arbeitskopie) @@ -1,4 +1,5 @@ /* PR middle-end/45262 */ +/* { dg-require-effective-target int32plus } */ extern void abort (void); Index: gcc.c-torture/compile/pr43191.c =================================================================== --- gcc.c-torture/compile/pr43191.c (Revision 172597) +++ gcc.c-torture/compile/pr43191.c (Arbeitskopie) @@ -1,4 +1,5 @@ -/* { dg-skip-if "Ints are 16 bits" { "pdp11-*-*" } { "*" } { "" } } */ +/* { dg-require-effective-target int32plus } */ + struct S0 { }; Index: gcc.dg/pr42629.c =================================================================== --- gcc.dg/pr42629.c (Revision 172597) +++ gcc.dg/pr42629.c (Arbeitskopie) @@ -2,6 +2,7 @@ took debug insns into account. */ /* { dg-do compile } */ /* { dg-options "-O1 -fsched-pressure -fschedule-insns -fcompare-debug" } */ +/* { dg-require-effective-target int32plus } */ int lzo_adler32(int adler, char *buf) { Index: gcc.dg/torture/pr43165.c =================================================================== --- gcc.dg/torture/pr43165.c (Revision 172597) +++ gcc.dg/torture/pr43165.c (Arbeitskopie) @@ -1,5 +1,6 @@ /* PR debug/43165 */ /* { dg-options "-g" } */ +/* { dg-require-effective-target int32plus } */ struct __attribute__((packed)) S { Index: gcc.dg/torture/pr47228.c =================================================================== --- gcc.dg/torture/pr47228.c (Revision 172597) +++ gcc.dg/torture/pr47228.c (Arbeitskopie) @@ -1,4 +1,5 @@ /* { dg-do run } */ +/* { dg-require-effective-target int32plus } */ struct S4 { Index: gcc.dg/tree-ssa/pr45144.c =================================================================== --- gcc.dg/tree-ssa/pr45144.c (Revision 172597) +++ gcc.dg/tree-ssa/pr45144.c (Arbeitskopie) @@ -1,5 +1,6 @@ /* { dg-do compile } */ /* { dg-options "-O2 -fdump-tree-optimized" } */ +/* { dg-require-effective-target int32plus } */ void baz (unsigned); Index: gcc.dg/ipa/pr45644.c =================================================================== --- gcc.dg/ipa/pr45644.c (Revision 172597) +++ gcc.dg/ipa/pr45644.c (Arbeitskopie) @@ -1,6 +1,7 @@ /* Verify that we do not IPA-SRA bitfields. */ /* { dg-do run } */ /* { dg-options "-O2" } */ +/* { dg-require-effective-target int32plus } */ extern void abort (void);