From patchwork Sun Apr 3 16:04:55 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tobias Burnus X-Patchwork-Id: 89529 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id C129BB6F9A for ; Mon, 4 Apr 2011 02:05:09 +1000 (EST) Received: (qmail 27083 invoked by alias); 3 Apr 2011 16:05:05 -0000 Received: (qmail 27062 invoked by uid 22791); 3 Apr 2011 16:05:03 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mx02.qsc.de (HELO mx02.qsc.de) (213.148.130.14) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 03 Apr 2011 16:04:57 +0000 Received: from [192.168.178.22] (port-92-204-58-2.dynamic.qsc.de [92.204.58.2]) by mx02.qsc.de (Postfix) with ESMTP id B3F701E4AE; Sun, 3 Apr 2011 18:04:55 +0200 (CEST) Message-ID: <4D989AA7.9010607@net-b.de> Date: Sun, 03 Apr 2011 18:04:55 +0200 From: Tobias Burnus User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; de; rv:1.9.2.13) Gecko/20101206 SUSE/3.1.7 Thunderbird/3.1.7 MIME-Version: 1.0 To: Rainer Orth CC: gcc-patches@gcc.gnu.org, fortran@gcc.gnu.org Subject: Re: [testsuite, fortran] Compile gfortran.dg/bessel_[67].f90 with -mieee References: In-Reply-To: Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Regarding Bessel_6: I have committed the attached patch. Rainer Orth wrote: > What about the following patch that fixes at least bessel_7.f90? > > Tested with the appropriate runtest invocations on the 4.6 branch > (couldn't test mainline since bootstrap was broken there). > > Ok for mainline, 4.6 and 4.5 branches once tested? OK. > I've also had a look at the other gfortran testsuite failures on Tru64 > UNIX V5.1B and IRIX 6.5 that couldn't be fixed that easily. > How to best report them and have them investigated? I suspect that > there might be only a few common issues, so a PR per failing testcase > might be overkill, while a single one for all failures is hard to deal with. No idea. I would go for only one or few PRs, one can still extend it to several. Maybe one could also restrict one to few issues as a starter. Tobias Index: gcc/testsuite/gfortran.dg/bessel_6.f90 =================================================================== --- gcc/testsuite/gfortran.dg/bessel_6.f90 (Revision 171911) +++ gcc/testsuite/gfortran.dg/bessel_6.f90 (Arbeitskopie) @@ -16,7 +16,7 @@ ! more tolerant ! * [0, 5, 3, 4, 6, 7, 7, 5, 5, 6, 66, 4 ] integer,parameter :: mymax(size(values)) = & - [100, 17, 23, 21, 27, 28, 32, 35, 36, 41, 47, 37 ] + [100, 17, 23, 21, 27, 28, 32, 35, 31, 41, 47, 37 ] integer, parameter :: Nmax = 100 real :: rec(0:Nmax), lib(0:Nmax) integer :: i @@ -39,8 +39,9 @@ do i = 0, mymax ! print '(i2,2e17.9,e12.2,f18.10,2l3)', i, rec(i), lib(i), & ! rec(i)-lib(i), ((rec(i)-lib(i))/rec(i))/epsilon(x), & -! rec(i) == lib(i) .or. abs((rec(i)-lib(i))/rec(i)) < myeps -if (.not. (rec(i) == lib(i) .or. abs((rec(i)-lib(i))/rec(i)) < myeps)) & +! rec(i) == lib(i), abs((rec(i)-lib(i))/rec(i)) < myeps +if (rec(i) == lib(i)) CYCLE +if (abs((rec(i)-lib(i))/rec(i)) > myeps) & call abort() end do Index: gcc/testsuite/ChangeLog =================================================================== --- gcc/testsuite/ChangeLog (Revision 171911) +++ gcc/testsuite/ChangeLog (Arbeitskopie) @@ -1,3 +1,7 @@ +2011-04-03 Tobias Burnus + + * gfortran.dg/bessel_6.f90: Reduce mymax for Tru64. + 2011-04-03 Richard Guenther Ira Rosen