| Message ID | 4CAB435C.8020700@picochip.com |
|---|---|
| State | New |
| Headers | show |
Hariharan Sandanagobalane wrote: > Hello all, > Is it alright to commit the following patch to fix the broken cmpsi-2 test? yes, thanks! > > Cheers > Hari > > ChangeLog: > gcc.c-torture/execute/cmpsi-2.c : Unsigned comparisons should use > unsigned values. > > Patch: > > Index: gcc/testsuite/gcc.c-torture/execute/cmpsi-2.c > =================================================================== > --- gcc/testsuite/gcc.c-torture/execute/cmpsi-2.c (revision 164991) > +++ gcc/testsuite/gcc.c-torture/execute/cmpsi-2.c (working copy) > @@ -49,7 +49,7 @@ > return F; > } > > -fltu (long x, long y) > +fltu (unsigned long x, unsigned long y) > { > if (x < y) > return T; > @@ -57,7 +57,7 @@ > return F; > } > > -fgeu (long x, long y) > +fgeu (unsigned long x, unsigned long y) > { > if (x >= y) > return T; > @@ -65,7 +65,7 @@ > return F; > } > > -fgtu (long x, long y) > +fgtu (unsigned long x, unsigned long y) > { > if (x > y) > return T; > @@ -73,7 +73,7 @@ > return F; > } > > -fleu (long x, long y) > +fleu (unsigned long x, unsigned long y) > { > if (x <= y) > return T; >
Committed as r165016. Cheers Hari On 05/10/10 20:35, Michael Eager wrote: > Hariharan Sandanagobalane wrote: >> Hello all, >> Is it alright to commit the following patch to fix the broken cmpsi-2 test? > > yes, thanks! > >> >> Cheers >> Hari >> >> ChangeLog: >> gcc.c-torture/execute/cmpsi-2.c : Unsigned comparisons should use >> unsigned values. >> >> Patch: >> >> Index: gcc/testsuite/gcc.c-torture/execute/cmpsi-2.c >> =================================================================== >> --- gcc/testsuite/gcc.c-torture/execute/cmpsi-2.c (revision 164991) >> +++ gcc/testsuite/gcc.c-torture/execute/cmpsi-2.c (working copy) >> @@ -49,7 +49,7 @@ >> return F; >> } >> >> -fltu (long x, long y) >> +fltu (unsigned long x, unsigned long y) >> { >> if (x< y) >> return T; >> @@ -57,7 +57,7 @@ >> return F; >> } >> >> -fgeu (long x, long y) >> +fgeu (unsigned long x, unsigned long y) >> { >> if (x>= y) >> return T; >> @@ -65,7 +65,7 @@ >> return F; >> } >> >> -fgtu (long x, long y) >> +fgtu (unsigned long x, unsigned long y) >> { >> if (x> y) >> return T; >> @@ -73,7 +73,7 @@ >> return F; >> } >> >> -fleu (long x, long y) >> +fleu (unsigned long x, unsigned long y) >> { >> if (x<= y) >> return T; >> > >
Index: gcc/testsuite/gcc.c-torture/execute/cmpsi-2.c =================================================================== --- gcc/testsuite/gcc.c-torture/execute/cmpsi-2.c (revision 164991) +++ gcc/testsuite/gcc.c-torture/execute/cmpsi-2.c (working copy) @@ -49,7 +49,7 @@ return F; } -fltu (long x, long y) +fltu (unsigned long x, unsigned long y) { if (x < y) return T; @@ -57,7 +57,7 @@ return F; } -fgeu (long x, long y) +fgeu (unsigned long x, unsigned long y) { if (x >= y) return T; @@ -65,7 +65,7 @@ return F; } -fgtu (long x, long y) +fgtu (unsigned long x, unsigned long y) { if (x > y) return T; @@ -73,7 +73,7 @@ return F; } -fleu (long x, long y) +fleu (unsigned long x, unsigned long y) { if (x <= y) return T;